From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2106.outbound.protection.outlook.com [40.92.89.106]) by sourceware.org (Postfix) with ESMTPS id 20F403858D32 for ; Mon, 15 Apr 2024 14:44:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 20F403858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 20F403858D32 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.92.89.106 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713192288; cv=pass; b=AnfiJFwgnLilTvcrlZhiJ6B3vgQa7QBqikidQ+SVn3gqYRZmPVZXccJ2b8Vk/+XZv83A9suDRMgK4c11yCN7mJFJwPhtMRrh1pVFR+Xn7vm4fsjJoVnLNXO0EHDcptbSEHnJKmAX1RSHnIi/EFicL2SGe8SU7CThHDRpLlXV4Z0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713192288; c=relaxed/simple; bh=jI6FDawNVxXynuuNU1ColZkOigYjTHILWdjsqYXPAWY=; h=DKIM-Signature:Message-ID:Date:To:From:Subject:MIME-Version; b=s/FSDpqUxmKKPUVUWm7D8AAepbUYsct/R85xWvOr55m4ImW3Hvn3Z7eeFNYyMoKbaxH1RRzpUVakOhFHEz8NulxC9+iJQcziw54Vq6K+vykhFdbY60YVBB57bI5pApiaHmKgJyiUXTqwH/jOGxaZJmRsIl/JuyveyOOBXSd68kE= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bGbfSDvrbX+w5BGf4wxXolbYPMwwjQsgPmp1R/HxDP5lK0LRtkA4AOQQrf0/mXp4GGYFIG70SnPRLShM3D7OdxjFgEM2Eu+dCYufcXbh7F9f27kkF8JDBR5XzizFchhRb+GbIJm5h8hE423i2hhzEX7dq+e4j+1u1EX9zY6TjNPHur92wHfWi94YFWzrd9fetrleO4DJbHB09PSotxP4at+2Qxi6sDTf4p8DCt1hXQTTRTscbTKUUCC047VdwhrHoE7PDcslmjh+gOH2FKqPxGI+MWpd1Cj3SqpCgcaFNyVRRJC+Gf6qRKW0jG15pWrMJFJ6s9lG5Tw8vLlBNG/euw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WkONdWAQBgJhnkb4xzYignZhn3IcCYqZ7+XeEoWc3CY=; b=k+u9bJn6ijpLRQWXf5PV9V9AG7oNOEupRQ3069bb0wx/Jj+fBo0bRq3cbIEEwv3AsIJRw/KyjOAVHaP78625HtKq0By6T8e2RD2xhsols8hMD8mZvy43p3H8IvuCuX2G+5M3eQGpgU9COCt/3vVEDW2gQdYMfr976gseMMvAi52Wg+WxvDK3kZiGM73ilb+C2EzV85CzW55a1sW7LhUZh33Bj6CSXQroCcMw1PPDd9Qb3JVFsWzormKGRQRCEwZvfChtFJs0Cgib/XtMYyMHdyRiRabpnOdiqEsioNQDIKKi/gPNBhsIF20z2J6g0/gYl4zfnXhyVOvKvTl/83ZvOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=HOTMAIL.DE; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WkONdWAQBgJhnkb4xzYignZhn3IcCYqZ7+XeEoWc3CY=; b=tpgBCcE33Hil68BC1gKtkEfz9JN0uxYX9uhSpVtZhbIg95yor+lp3paD7Lys2lB3fSgDK6NG7sMi/xej1F+ycSv8TIXzMyPEeZ0iGnvWJ8M2ruEx1cG9bZDUY+vF+TIHPuh5EKQx8xB3riofnqFUnmp2Pv7hHC2BP85/PDQYfKMUdVy/84Mna1jbnPrtAABNYdnCUYCEmDbyQDlNj4DC5SyJEuzQqJcxpD70Zfn4JzLovRn36IYQ+69AUu24nPb8afAle38Ga3unx1U+us/Ie7gcXVFrIsJsEqo0KrGcCywq9lx6upuiCLb2jjEy3SMEGPPXuOnjoOaYpxRUL7Dbkg== Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) by AS8P193MB1205.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:33d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Mon, 15 Apr 2024 14:44:45 +0000 Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::5403:f1ad:efaf:1f71]) by AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::5403:f1ad:efaf:1f71%4]) with mapi id 15.20.7452.049; Mon, 15 Apr 2024 14:44:45 +0000 Message-ID: Date: Mon, 15 Apr 2024 16:46:37 +0200 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "gdb-patches@sourceware.org" From: Bernd Edlinger Subject: [PATCH 1/2] sim: riscv: fix a divw division by -1 bug Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TMN: [Zt/pDQj5RjJM0lgK29wUyu9l4Xuk5mFwfhRWrxhaUz2wvB9XOGvADsJJgLUW7J5r] X-ClientProxiedBy: FR3P281CA0210.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::19) To AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) X-Microsoft-Original-Message-ID: <61f642db-5ede-4469-a1e6-29f1700afce9@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P193MB1285:EE_|AS8P193MB1205:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c2e9b5c-943c-4a3f-d16b-08dc5d5a9764 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HKrhLetVH+3+s8s24e6w3ClEj4YEIAtkdMCHxQlhIgbN2JdtNW2f/t9ciClq7VyAoFruysdCLMkhkZuAJFcnDSGNnw/DYsZcq9U5tyCkkfcS1TADjER6IokoDsfHQU/CXn03Ixm309sbL4+oxfC0GHDqHxMW+7G6IFUQ3OtN8oGdGM4oZIwzcaPjhGocymE6IwQC5bNm4I2lyEjZUB2Mk8oYKkbRlIFR/by/2pxD3JpnsVqICBfIx8ABTjQ3rcd5wSNGfnjeAFRvx9bNUorViXXAd1mVumA3vMm0EwdhOmSNbzxSm4OCEe9qCet53ndBggv2gPbj6zYNblcCLyeFl6ApRn072+J/hYeRtnC806FDF2F6BpXNJQPwYV7nDy4ZkGoT4s8T01Yb0eSxZY8BVhi3MLRfA8PL3FpNJnjx1W26nbt2bfu1U4iOtdfmDKwUNcOpv3Jzv42XkDO7a/osrZS5G8Z76GvrYjC0cz4Fy/Seo7k5gDNLPWYZeKw6okzbwrMWaibEnJfPocJiodgqhoLht/vQswHyOY1B+hEvZm9zZGs56MSDrs5qPX147274 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlV0UHpxVTRGWGE4NU5qdCt4MmJXa3N2WTRWSVZUVzVDYmZnMDU1U2FYV1Za?= =?utf-8?B?cjhpZkVOc091bjVXRTE3aW1Ed3ZPUlRpMFhieVcvRmZ2SzFZZlNkOC9waXlQ?= =?utf-8?B?T3FHRDRGZjVKL2o1Z0xtTFlDRDBsQmNGVUtaVytLM1FqbGpVVFpWVWJKdTBo?= =?utf-8?B?Um1MeGxwN1VoZTBZK2tzYkYvM2ZXcmc4VmF0Nzg2Z1JJS3RJTVVwM1lOTzZ3?= =?utf-8?B?WEo2MHdOQW1FNTFmUmxQT284aDdtRUY1TnNNNUtjY3ZYY0xpM0M3dXJkL1Jv?= =?utf-8?B?SWsvWUJtQlJNZnloeUs3VE5PZEg2Z1A0OGhwVllicllzRXo3QVE2bFIzN1Yx?= =?utf-8?B?bmxIRStYRWU5SS9ZMDlTekVOWmovOC9BdHpIREhwTWdBNVZTMExiYjZWUmt1?= =?utf-8?B?RTludW5SSmU1RHloeFUxMStPNkN0dy9DcWZyV28yUlpmVnJwYkEyMFhKQitr?= =?utf-8?B?T2YrVkpmZHM0aWxUNXFmTERiNDA5YXlIekxVREFTT0xRUXUxUWRwaWJmaVpI?= =?utf-8?B?d1RFNXFEcTlFZjlVdk9WdlRPdjgyYmt1cHZvUytHZ3BPOHk1WnNsMmQ5RWVl?= =?utf-8?B?TG42MXh5VVBpSjhOUWh0cFZzY2tKR2xQQ3Z5Yk43ekFYZERodzh3OGlCNkl6?= =?utf-8?B?bW5SaFpsbWNZcDQ2NnBibHEyNzByVEx5M0JCRUN5WkxBcjczejFJbEFRazdl?= =?utf-8?B?T2JPUTVSbkFWVjE5Rzl3SzFNOGNoSlE0RStCNnpqMlhHaHdJdjBoM2tMd0NP?= =?utf-8?B?Rnd3dzR3ZEYxMCtuVXltWUErWXJjZ0NyNjlOVDZpeWhQazNHZVhCMXpCdnVY?= =?utf-8?B?Ni9hcXI4ckE5YXpDQVFhUGJUQ1g2QlQzY2dzSG9IM1h3TVgvdkpvNTVidEpJ?= =?utf-8?B?N0VUTjRQMGtRZWxKRzNWMUl3Q2pJR1JzUSt4dXdqdE1TMit2VTQxaERHcW85?= =?utf-8?B?WTRhT2ZJa0VNNmFNQTNNcWVxR2ZCV2NEV3RHMmJkcCsvTUx1UXpvN1lJUkwv?= =?utf-8?B?S2h3NVhjcHRvUWVnNWJrM2Z6eWRvVWg2WWlkL2NBdTJadXlUSHc4MEY3Q09T?= =?utf-8?B?OXUySjhsakhXUFpNVFdObEpBelBuQi9CRWpGc3NPSkpMeHJveS9Zbk4wSnpa?= =?utf-8?B?amZzNENVbThRUlRTdjF1OHdYVlpsMkcvTHpmUFFaUVJwYzhHTWhDcVRQbFBl?= =?utf-8?B?Q2gvMDR6MHpueG1mR1h2OUxkWGpJeTlXenl1a0RwUnBLQlY3UlpsSm82ZHJi?= =?utf-8?B?dFh6a3JKbDBQd0h2RGpWbjZoeFF6Wi9VREVaY01iN2VWVjc3SGZJVEhqVGpa?= =?utf-8?B?QldwZVhLRytramxTWEFPVEVibndqbVdDaUlQSC9zKzFUaG9uL1ZabUY4OTNk?= =?utf-8?B?c3llZVNOaFUrV3d5WFJDeHg0NzU4SjRvZERWdmY2S3hROUtQbzltYm5aNnQ0?= =?utf-8?B?Y2ZYRnFHZHRTcDcyaVovd2syTGpaeGlXSEh5YTFDQ0dYMyt3WG1Ha2t3emJt?= =?utf-8?B?My9VVjREVUZ1cFZybm5wY1FZWERPaUNReFEzVFVKR1ltNkpTRUlNRFhjWDF3?= =?utf-8?B?dW1IQ0lVMWhJa0hzYzdMd1BDZzcvRFYxT3UwSzJNOXJlZnJkNTdvcFpoeDFu?= =?utf-8?B?cmQ4UlV0aGlYbUkzK3ZqV3VUOS9SUlZyL2l1dVRkVXllN0tMS1FQck1TaFFv?= =?utf-8?B?cnhtbndaUHcvcXFmMlhaaytjTkdWYWhjcmtmRHZmNnBaSFRKTUEwcFdxdHhy?= =?utf-8?Q?OUi4SrApDkGKqi8/7eK0MzI5Y2grW2ERA8AQqdQ?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-80ceb.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 4c2e9b5c-943c-4a3f-d16b-08dc5d5a9764 X-MS-Exchange-CrossTenant-AuthSource: AS8P193MB1285.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 14:44:45.2849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P193MB1205 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: There is a bug in divw for riscv64 target with dividing by -1, the result was always 0, when it should in fact be sign-extended -dividend. It did not affect the rv32 target, because these instructions are rv64 only. Since 1 << 31 is an integer overflow this avoids an undefined behaviour bug at the same time. This caused test failures in the gcc testsuite like: FAIL: gcc.c-torture/execute/arith-rand-ll.c -O0 execution test FAIL: gcc.c-torture/execute/arith-rand-ll.c -O1 execution test FAIL: gcc.c-torture/execute/arith-rand-ll.c -O2 execution test FAIL: gcc.c-torture/execute/arith-rand-ll.c -O3 execution test FAIL: gcc.c-torture/execute/arith-rand.c -O0 execution test FAIL: gcc.c-torture/execute/arith-rand.c -O1 execution test FAIL: gcc.c-torture/execute/arith-rand.c -O2 execution test FAIL: gcc.c-torture/execute/arith-rand.c -O3 execution test ... --- sim/riscv/sim-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c index c8adb65139b..515ff835223 100644 --- a/sim/riscv/sim-main.c +++ b/sim/riscv/sim-main.c @@ -724,7 +724,7 @@ execute_m (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op) rd_name, rs1_name, rs2_name, rd_name, rs1_name, rs2_name); RISCV_ASSERT_RV64 (cpu, "insn: %s", op->name); if (EXTEND32 (riscv_cpu->regs[rs2]) == -1) - tmp = 1 << 31; + tmp = EXTEND32 (-(uint32_t) riscv_cpu->regs[rs1]); else if (EXTEND32 (riscv_cpu->regs[rs2])) tmp = EXTEND32 (riscv_cpu->regs[rs1]) / EXTEND32 (riscv_cpu->regs[rs2]); else -- 2.39.2