From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02olkn2053.outbound.protection.outlook.com [40.92.48.53]) by sourceware.org (Postfix) with ESMTPS id E778E3858D34 for ; Mon, 15 Apr 2024 08:20:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E778E3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E778E3858D34 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.92.48.53 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713169213; cv=pass; b=scdCCs6Qg2p6SPI7+BB+MfaVnQju6yKkvX4bZLyrUa+C/lrOXmghy9CzXPTpB9fy/jMwz4+z9U+VzNO9XH0hvTB43gQ3O6QVfjV2dnG8bSeJEFKTOZGSIlpXrLEL7mkoJxyJj1k6qkdWNA11wiGKwyu7pV2Cddvm7YHHwiAhuFg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713169213; c=relaxed/simple; bh=iqOnTLn8HY1LVkPv3EQwhEN0nTRrTM36svTlPb75D3w=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=fgy+lwm3Gr3gS3M/CYGWUK4w/WEMwiMailO0+yIbJBgYUlwQjhEkSCQuMuLkVgau7rIO1RvadaZ7YWT7XoBSo2OD7/4+ZiliM9My3xZoU4jt52vTiZxrKIj4hLTGKA6/aHiiQ4/eyyXDNKNxtIpznpbYduyknYCvWeg5x5JXWxc= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IQZT/eo4MxLs/oU7J4TY60cIJnQCA5AeSTO4fAWV6H3yZItv2fel4Wu/tsd4BCQ75x1UFr256Nt7iHjle6TJ4R3KNnhOLudFp5fgs9VDgnSoJXwnpGhdK7rxhqvlRgac0wcOfM2NjjpdVSC86MOjhTz71uIzGwW7pNyXAUc7Ea6K1RuLYZnncRzPMs2S9Ba4zI7LFSbsj3VqJmhTte4dQbid5Qx/zQJD+lJOc2JcnhfI/Ssb9GTeUx5LQR4yznuxPNaZSTpbXrjAKniQ/BHnmSF0BTKfbvy7X5qK4bhG6J5EZquTptJf3To8libDGHlp0Z15XpB3cWUh5ENiFdJQQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nbDYDsb+mpkohgl3yLdPxRj/K1fRalz+kP9/WFn5RbM=; b=DPs0NaVFBAlxRZUb/JIMQ66Jrh7X1dcj1I34m6grr+k1D3DiOBAvD30oSKWrrWxuWAtHn+EvYi3UPjvazRPYl2o3ZX3tmeJlGsalD1tfJ0dRQCw8KYcWLuZ7uoDTvXVSMMNgcFTjVeWJrm0qQEgss8VcV906IaSKNGu0kFxBLlJAR/bwlfR5DJghF+rGZhhFVWqKY8bKuidHFITFU60uGtFGLaFZmBsIkYTAAJFeJ5TJXKvd1hY/UQhG2vmDoN0rTIE6/s5y5uMp7VG5wxXvDBm4pOs5Yt48DmeiRsf5ByrCuRsXtEuWst7NiEImPdHdjDbRt5d9ZeO2xdrsq8wzyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=HOTMAIL.DE; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nbDYDsb+mpkohgl3yLdPxRj/K1fRalz+kP9/WFn5RbM=; b=TksMSnKWi2xKfkBnbKe2KLSM3lj/aEdyEj34aQV+9+Rvi5kuxSCOrO+S9cdnOI8r837xbv/KIrlSjF0/5ycWA3m4T3kex57u8WXaFYrW1g9dXaiPuUh5+Oh7U68C4BOtP+6oO9ZydG6UvpzWIizAU0j/CAAlUtqfAjxA5w84YN3Q+uYL87XweiOk/CxlFe+mMdVmN4Nl0Kn8aW84RHrvPhMKfPjJZ4pOmUbgMMH+9dWdO1Vx0W/Bs36aaIugyvps7miEX8pSxgDNUXK9sxDCE6t0cggUzHdfmkuj9IWHl74lu9r975lYmxnnQ2VmzvPgQm1xUghZwfq5E7uXb+hs5w== Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) by AM8P193MB1201.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:356::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Mon, 15 Apr 2024 08:20:08 +0000 Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::5403:f1ad:efaf:1f71]) by AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::5403:f1ad:efaf:1f71%4]) with mapi id 15.20.7452.049; Mon, 15 Apr 2024 08:20:08 +0000 Message-ID: Date: Mon, 15 Apr 2024 10:21:59 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sim: riscv: Fix PC at gdb breakpoints To: Andrew Burgess , "gdb-patches@sourceware.org" References: <87h6g66hkv.fsf@redhat.com> Content-Language: en-US From: Bernd Edlinger In-Reply-To: <87h6g66hkv.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TMN: [Q0jFh1RgrQrD4actfKVInGd37QFP42n7IZnEVaX7TnGNlYLClveKxfhZN4v5ayLH] X-ClientProxiedBy: FRYP281CA0008.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::18) To AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P193MB1285:EE_|AM8P193MB1201:EE_ X-MS-Office365-Filtering-Correlation-Id: 25a3c139-b05d-4d16-afd6-08dc5d24dc7c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0jGdz2uE1G5yLcHDTyINE3zRvMmM55ou1LBaCD5q8x3cGZ0Yepmtpyhg0E0dN/TNAAaAo6NqhC0rP+svU/MrjV84ll+uqRYglGgeeSUBnn4MboTlfs2YOrh/CPW6A0kkDIXQQgHsnA09N0BwxyDgg61n4IS7PGKSZux29quhXCusQNnX0Gw+xXZJsjmjVA9aVbhWcXjTLg/6Stj4E8xA/qIoHSXBtZ2LV+4b3iv/98Bx1SdcLk2d4dIcw/x0jnxwsfziEawcdxzWXSPsp80dYDApWG87N1mKojV1/AuaY+iAmn1EP6UCwb6U+c3z4mk6ldNt9J5jgVDw/OpxrBlFNqPFtBnmu5TYxG9WnvGHoRqzy8kBrPM/3/ZUHk7d9tMMCeiFu+o1KOBqvK1KNcBtXPLJGsEP/TUZrUu5TnSUWzpEl3Fvg5qvYMe1TmLOL251HJ+Ljkn0XSnEZFOTDpJqZC+VqaWmrgslnx+mpCSvlx/W9FJXYUayiK2zYogU+xDtnJVVZ2MjWAVxJrKVK64my4/QE7BYF5Qx4Arst1lSI3yXwmCQw1L3bK7FB7L/aNFl X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGR0U0I2Y1poa0ptbG0wdDNVNDhwUkVucU9Ea3dta1ZpdGJXZ2ZQVFlhNjRI?= =?utf-8?B?cXAwSWovZFQzVXVXcU1NVFlGejRnMkFiQnFHM2trT0J1YUJIaDlQSFlneitH?= =?utf-8?B?WGhrUk5Oa1BiQmJPZ3RzRHFQSGtWcXpNbDZJR2dmbGdqenp2Ui9uWm84Zm0y?= =?utf-8?B?d1k3R3dkeUorbUh0NVVXU3dVaWJvR1VsSi9icjhNUVpGMSt0bm9wVGZQTGJZ?= =?utf-8?B?NitFM21zOHFVZm1ZRHFSeFljK3R4TmZlYWdDUEoyR01Mc1ZMbHRjZUh1UThL?= =?utf-8?B?ZmlaeXNUbWpEbDBmcjY5T2dML0Qxc0prSlh5VnpBRTRKdVpWVnhlZTNlZm15?= =?utf-8?B?K2N5TDVFNVN0d2NxMUJjd3FGVUpFR1MvRjZBR3o3TDRaNkdzRGJXdmFkYVlH?= =?utf-8?B?S3dxUkZFZFNpSFZ0d2orMlRsQkhsVnczaTU2VTdnUldZSFRsRGg4WmFyODdO?= =?utf-8?B?WHRBdCtRRnNuTGRkSDY3dEUxYXE4cWo1U0szclZhWnozcUZJWHRwZXBYeG1l?= =?utf-8?B?UG5ObnhKL0toNWxWVVhFZEdRU1lGU2d4RTJiSFQwb08wbW51ZUtjUzdkcCsx?= =?utf-8?B?OEoyWWRkc2I4ajNWVGxIb0szSUM1V3pkNXJoVDR1UWFYRDZjdVViWHk3NHhN?= =?utf-8?B?TCtCL095RHNJcUsva2k2d2FKclhZMzJMeGltWWlNa2prakVvb1FOZUtpeDVY?= =?utf-8?B?bjYzV3dVbFF4WlVDVTBxbEpNWGxPUW0yb1Q0NVZJRHdXdlZTbndiYjgyd3dj?= =?utf-8?B?NURlcnRKS0JoZ2kxLzV3Wnc2UkNNNUR0cEF6bUdMZ2hiZ0JEdTM0WmZ6U01Z?= =?utf-8?B?ZHFsM2g0bWg2MFc1RGFESXIyV3RtdGpHdFFvd2tYTXNIMTJnc1ExdFhRcjZO?= =?utf-8?B?UWUwT0tWWWptampwaldzbUQrYnd4MHhTeVJiZjFlSnZJV1QvYXUvbGxXQ2JV?= =?utf-8?B?d2h2YUJZaDM2ZmhMMGxKUFJsd1RYMmxVZlV6N1VrZzV0RXZoYW1FcDlWV0lw?= =?utf-8?B?UjAxQmVMc3pRN3Ztb2RqY3hwclJUM2lPMVMzWjR1eHlObGlkQ1lSTmkvYndr?= =?utf-8?B?b2UycGRGUi9BVGVJQlNBNTBOdGsxZ0o1L2N4OHVreHpoVzcxdGkvYmcxK1hN?= =?utf-8?B?NEd6ZTVjV0hCZ1hkZ01XZ1VZVlN2YTdWSEpWME1JYm56NlNFTVFxYmtjUkhS?= =?utf-8?B?eTNsVkVtMzNQdk9KeVVCeVpzaXRzb2FDM3NBQ2lab2RaOWJiWDZud2EzaXZ4?= =?utf-8?B?REYxYzlCb3IrUWltTncvbS9IeWNLcngxa1dVVFErV3BXTzh2K0R1N2d4YVYz?= =?utf-8?B?MkNlcDFEMmVQNGgxdHFQNkliQUlSZ2NxS2toSHRsbUJtQ01sZGg1OTB1d3Zj?= =?utf-8?B?TnJqb1d3bndBT1JHeE45WUJJeERVZE9oc1d5MmxkM2ZRUUYwdW1Gcm02Ri9q?= =?utf-8?B?WktjdHROOERhcTM4TFZMWEZjdHptbTk3emdhci8vVE94WlFIWFl2cFE0eTRC?= =?utf-8?B?RG95eDRMWnk1TXBGYWoyN25SR3pqVDdRVHlIeXNsa2syRVU4SzNRRWxPT1l0?= =?utf-8?B?WWw1K3puNHp5ZW4zZjJnekNQdWR5Yks3VVJOOWFrS3B0dTVPWkdEQ05Fckhz?= =?utf-8?B?ZGVZNGRGRW1KdkNsaVRYWmRDK0Jac3FFck5UOFJUZ2xPRU43UWpHMXFYdjIy?= =?utf-8?B?ZlNqWnFTU3pFM01Pb08xUHI1UlhpaXM5V1JIQ1lkUHhrcEYydkNGWkdScTZ6?= =?utf-8?Q?j5vn/8yXHjv7YCzaVBrexh3EHAHqHUUZ/TWcezE?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-80ceb.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 25a3c139-b05d-4d16-afd6-08dc5d24dc7c X-MS-Exchange-CrossTenant-AuthSource: AS8P193MB1285.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 08:20:08.3004 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P193MB1201 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/12/24 11:44, Andrew Burgess wrote: > Bernd Edlinger writes: > >> The uncompressed EBREAK instruction does not work >> correctly this way, and the comment saying that >> GDB expects us to step over EBREAK is just wrong. >> The PC was always 4 bytes too high, which skips one >> instruction at break and step over commands, and >> causes complete chaos. The compressed EBREAK was >> already implemented correctly. >> >> Tested by using gdb's "target sim" and single-stepping. > > Thanks for fixing this. > > For the record, in v1.12 of the RISC-V privileged architecture > specification, section 3.3.1: Environment Call and Breakpoint documents > that the $pc value should be the address of the EBREAK instruction, not > the address of the following instruction. > > Approved-By: Andrew Burgess > > Thanks, > Andrew > Pushed. Thanks Bernd.