Re: [PATCH] sim: fix a warning in dv-sockser.c at connected_p()

[Bernd Edlinger <bernd.edlinger@hotmail.de>]

On 5/2/24 18:15, Tom Tromey wrote:
>>>>>> "Bernd" == Bernd Edlinger <bernd.edlinger@hotmail.de> writes:
> 
> Bernd> In some O/S e.g. windows there is a warning here about the
> Bernd> unused variable flags which triggers a -Werror build failure.
> 
> Bernd> Fix that by making the variable declaration optional.
> 
> I think this would be better if this declaration were just removed and
> then stuck into the condition, like:
> 
>   /* Set non-blocking i/o.  */
> #if defined(F_GETFL) && defined(O_NONBLOCK)
>   int flags = fcntl (sockser_fd, F_GETFL);
>   ^^^ add this here
> 
> What do you think?
> 

This would not be compliant to C99, and it would be the first use of this
C11 feature in this file.  Therefore I did not want to go that way.
I did also consider adding braces { } around this whole block, but
actually I do think that guarding the declaration with one #if is also
acceptable and is looking not too ugly, since the function is not too complex.

Thanks
Bernd.

> Tom