From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01olkn2045.outbound.protection.outlook.com [40.92.66.45]) by sourceware.org (Postfix) with ESMTPS id 249F63858C60 for ; Fri, 26 Apr 2024 07:49:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 249F63858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 249F63858C60 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.92.66.45 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1714117744; cv=pass; b=dC1TV7KQwtWgAk1fJ6lbdW8zmV8J/HrEWK2fv7HkXkIjYk3cTfei8cCF0u8gmToDhrh88iy8QmGAcaCkI6oBvz02CCcSx03+2yN8pvGWUn0ipuiIHT4Lr/EL+hGt060mux7DRq3d1REtLYPLQeb0/3agP9RKZFU+GBeNtK8OoyU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1714117744; c=relaxed/simple; bh=hyJ1TbYvdHQ49FdM6qrw7kayZcUI6XHq3TtGn/mFyUA=; h=DKIM-Signature:Message-ID:Date:To:From:Subject:MIME-Version; b=cNK576MjnnoI37JQvNsxgJ5iywb+R9Re/0uTfTFrtltJ/N1fn9qleKyWkM/eKIAlYGw+Jq8JtEOrw/9JtIVfArvcXbYIcI3K3KFC3mc7rb7PRooI9V3LgPd2cCgxikXBFcitiKd8ytVdqqq0asfOd8mFQRaO+nuWcsCuicughog= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dm56p3eBaJ4s+7UM1Dut3TSF/EmwfJDVM9fKZz2ncHQ9+vQoDu7PDk3cALwmlp5COTeVzLi1s5HqHiDb8QSTuvHh3MV2aL0E13dGEQEDJR/ZDhI1XdBJzGCgxwglu+31+hOLNZcyLCj+ipWFy/gT2K+8TTOnKHNkFrZFTMKz75DSWqVQjMvG4IOkomKPYaESU0Id5NDE+D7OQe2SXlEwIlPb+GBah0qQ3xMHoImKZYWQq+rOrLOPEKNMIhrbKWaQGfAH6Ztm3cOrTLn6qceVnu48uCry4CDTlJRc0+s4cvo09+SQtNZsvmZO7tsUm8z0RZyHj0RW4TUZvUMAQ6r3uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M4cYdSYJzbhQQ46GJYPu1nwqzbdIZd2vmqFv6OsPTaw=; b=h4f2afwMiZOEHLjxMfHgZjFkZ9FezGvaFgyjc0FFnKh6ZLOWUJopXJYYAMBteQO2R7gtcRQUqACztHSCg7G4/GXWfzLL9sRwEQJEqlTsVf5NU0DVylsa5i4uoi6nom9COFADMnVEXJ2Iq3/JqG0jXg+gunDmbftrazPRTlnu2h1B71Xxtnh9rlMjslIxt8+hdPwm7bqDAJs6mmrnSnahJUKFwcDjdYRz9zuAgllcZHwR4wz+6eTfKC5rQ7ueD2v8UJjqW5PrGMBbHmaT+0dHMq70TerEDShI6UI8NIJbHP3sUxlfJAmaPtPUh0UTQ00Trb95b0HtCfeBdBR0XChcrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=HOTMAIL.DE; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M4cYdSYJzbhQQ46GJYPu1nwqzbdIZd2vmqFv6OsPTaw=; b=jxOtDlFSGgOZLAD7DY44Vi5+AQXQ0IsWDcCGsy9/vW4i1Co8QYDrLLVWuoN9bPz87wfqGolYvMrCuoPiFkYH+cigPYIrg4ZKlW6EX8s7nnGyrQpMdXe2mfriBfzZ3SdSltLzaqcmdPnUfptdbLP6mXwBcu4XZdCcYE3ASyFGuAMdFtLUlqc9dUqvaEOTKiYM9DPobyWIvoRUkFWAUYLYxiQsuMQnx+TPDGghDrzvOjWDXTjiibD0swrsrKhIrEiMQbpGmGO0mPz3ota2DgTwNuqqOrgnqy1P7Onhnd1EcgGJJd9AFZ+6knvnsQbLhpxnyJYRqzza7KLoc0i9JyWlRA== Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) by DU2P193MB2369.EURP193.PROD.OUTLOOK.COM (2603:10a6:10:2f5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Fri, 26 Apr 2024 07:49:00 +0000 Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::e65d:5dd2:5662:c61f]) by AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::e65d:5dd2:5662:c61f%4]) with mapi id 15.20.7472.045; Fri, 26 Apr 2024 07:49:00 +0000 Message-ID: Date: Fri, 26 Apr 2024 09:50:58 +0200 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "gdb-patches@sourceware.org" From: Bernd Edlinger Subject: [PATCH] sim: riscv: Fix undefined behaviour in mulh and similar Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TMN: [CfgC9azgdAhzVtrEDfVFigmeb3w72waKTz6ElNMkKeVWBPyxS3GC/6co5KFG73XP] X-ClientProxiedBy: FR5P281CA0045.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f3::12) To AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) X-Microsoft-Original-Message-ID: <3be04323-d436-40f1-b139-325e5cf57ef3@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P193MB1285:EE_|DU2P193MB2369:EE_ X-MS-Office365-Filtering-Correlation-Id: 921fb969-c20a-4c5c-9e31-08dc65c555e7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rQWf5PYL5LVH4h0PDCE1p3DMB0Cx3e0RjwHDcFNpmXxX9HkVdQ0ecitQkOG4uDqZUoDO/fuC5+N91SaUoTLw6nKJydFAthgAH6wNpSkc/8DI7iHo+pH6Z3oqU36TL5ryvU4zR+aCi1DLo/7muhIqMY0bs95gi1Wc7t7t5UuEVjg9+jv+dwVofcsOOQiQy0jMigL+H9JNMGZDwACoskwgbL+8rqgj0q3TOaUrh8P9fG+tgOCr6Pj9teLp3EmDCrjsSX43HGqIGd8+FUuFk7cHLfdtToQXfBEDGTc6QiA76KakCKs00/EjWyCVBKmQFQk1jLu2l8zJl9L0dVi1LbU6+uCvSGLFgJeR7LSc4+xLMGW5xTe1Z8MG8Wu5WGd2SU6JsIghLB+bQlanrGZmfWWDJQwVGOLzohuF72C+zwPxO1HhiqyeKy13HvGPYz4mpiOLQeDP7GKdNc7RMMMmbzWpBq7vVjDUU8xscZZt3rfZXeJv2jQMUZev8H+dUnw7q0NyJFmSpabdUKc2IMTY5UIxVvEdf5zWrtcWmWbnrqQXavLy59ZlGny/uG1C7VoIxVpQq8eHSRnhDIHM1sca3Zn0m5TyxI7sVi2oLkxxUJfj2937NqXCEV/FtcXqNjC8f9u0lFJBUTbmUhjmt76hv27kEl4GoOSmu2iiMQIAC/gjeLw= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0pKdnl6SUxydGJhOG8xSWwyb3JlTGRNR3lOWG9ORnNUNGxDS1E3SlhKQVNu?= =?utf-8?B?eVdyK0J4dUcrbERQak90SkdsMGhIZUZhbGQrbmV3STFHanNVdWF2YVhTQmpT?= =?utf-8?B?ZldCT2JMRE83N1ZRalR5L0g2Z0VsUG5SZFFUb0k0T0ZMRGhSTFRYRVZCMTl2?= =?utf-8?B?eGorS2JPZ1B3TndoUlFNOFY3QXgrUHFQc0xBb2t1bzZlczh3U2ZUb05ydFl5?= =?utf-8?B?VGdlWTVERTBBRW9FK1VUMWNIRkc3ZDFvelBGdVBmbXRPczM0OGdNeUM4OGNM?= =?utf-8?B?cDVGWXpnZ0RmTlNGazF3VC90RkpnMDZlU0pLSHB5RnR5dEIwa0w4dXNpNGVn?= =?utf-8?B?OTVUUDEvcmxiT1A1WTJFNGhLVERVMU56UGN1azVtdEw2MmJlSTZUZnRlLzc3?= =?utf-8?B?ZjhqYXF6cFg3aFdEQW9sQWozdWFVRTF6WjQyQ1lVRjNqNTBlb3JPZUpOaTY5?= =?utf-8?B?VW1pdWRkTVp2TEdmRy94Q1dWS2xhL01FWTFRZ2VCSHlqeTVVU3FWa3FTKzR3?= =?utf-8?B?SWFIeFVmM3VUUHExVnNmQ3V6MmdZTnM0SjdMRzFhWDVVTk5HZWtjSXczNmRs?= =?utf-8?B?Skw5Q1FUSmI3OXd0bFJBSWlnL3kvNkFzdEt2ZXV6a3hpU2hMVEpXaW4rQkFp?= =?utf-8?B?aGJUWnN3OTlocVVPK3VvL3FSY2wzWUo2NnpEajZCKzN4bkE5TDlvV1VpQk5N?= =?utf-8?B?Z0lGVjIrT3FMRUQ5dUczYnlhR2w1SlNMTEFPNnB4RlI3dU9qN2E1bTdSaDJG?= =?utf-8?B?TXY0d3M4OWd6NnRlNjlUa1dkTmR4ZEJsUkpLZjZDRDlWK2VxM0tVdUl3TTZN?= =?utf-8?B?MkRQTXYrRSsrb0lEaGtqbkVoL2NuVFEvMTM0b2E3bit4RFU2TlhzamUvcjY2?= =?utf-8?B?Z09qVHRxVk55YVg0Rkt5SGdCL2YxZDhuTHNxdjVVckVhMW5WWCs2ZFNzeTJZ?= =?utf-8?B?aU9QSCtiM1d3RWxjcjhLV1FyTG5kczg4bVRnK25SWjNlRCtCTUpvdGZteVY5?= =?utf-8?B?RmhrQ0YyVzlwbUFXcXVqMjVOR2h3UEx1MVdEdmtDM3R3aERFSnpMSjBwTEFB?= =?utf-8?B?L2ZkbitzWHdsUGxoWm9ONUhlOEZOOGRlVGIwMjB1bDFNc2F0WlRVQTJJWVZt?= =?utf-8?B?WGlROGpubzg2Z0lhRmV0MFM2bjYxM1pBb3UxNXFyRm5TbEtmeWFDbWJ4VGd1?= =?utf-8?B?ZmI4eWgwZE9YOWVFbmdGb0dRZGYrRWNLMjh5Vm8vc20zVXlhMWJpUjRkKzQ2?= =?utf-8?B?cWF6cWtrbWRwVkVIbS9lQisyMzhVR2Y1UWFkK2dTa1BEVG4xcDl3OWRiQmN2?= =?utf-8?B?TkEzaUZJWXdRSkhvSzA3c1NnazIyRm5PRFgvanhvQzZ0NXIva1licERhczky?= =?utf-8?B?MnltM21TdURRc3M3Mm1yZ2tpd0tJOHR5R1FBNUJNQzhxRWFPVjhVYzZPYmJw?= =?utf-8?B?NWVFcGhBT2tveWtlTUd4M2E0OUZ0T2tkdWRXcENGeExYeGlBbnRHb2hndXk5?= =?utf-8?B?SlR6VTVDem9Iamk4ZTU2QndaRDgrL0QrcmFqMXZZSDVjdm4xNlZYTzdwMU1B?= =?utf-8?B?anBxVjVocmpCWEg4OFhpcUpScmgrdXB1WGNPYldDQWdGUFh0YTFJVDQ2UWND?= =?utf-8?B?emUxckVWWUF1OE9RMkRVSkVEQkVYZUJvbXRnMmpBcXBSOVpzWXo5U2JHREh2?= =?utf-8?B?ZDViNW5LN3V6MmVMZkZMVEZwOUU3Q2Q1VWhXMEdUUDFyb0J2d2h6RVVzcGVi?= =?utf-8?Q?MOrSMBcjAgnouRqDBnN8cnP+1QNFRcZN1cTTOL4?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-80ceb.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 921fb969-c20a-4c5c-9e31-08dc65c555e7 X-MS-Exchange-CrossTenant-AuthSource: AS8P193MB1285.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 07:49:00.5902 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P193MB2369 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This fixes an undefined integer overflow bug in the mulh function, which caused a test failure in the gcc test suite for riscv64 target: FAIL: gcc.dg/ftrapv-3.c execution test Fix that by casting to unsigned when an overflow is possible. Also the __int128 multiplication in mulhu can overflow, and must be done with unsigned __int128 to be safe. And of course, the sign change in mulhsu can overflow too. And also in execute_m there are a couple of possibly overflowing multiplications in MULW, MULH and MULHSU. The latter is probably harmless, because the signed * unsigned type multiplication is done in unsigned, but it is at least clearer what is intended, this way. --- sim/riscv/sim-main.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c index f6f6e2384e8..1815d7f2a6c 100644 --- a/sim/riscv/sim-main.c +++ b/sim/riscv/sim-main.c @@ -651,7 +651,7 @@ static uint64_t mulhu (uint64_t a, uint64_t b) { #ifdef HAVE___INT128 - return ((__int128)a * b) >> 64; + return ((unsigned __int128)a * b) >> 64; #else uint64_t t; uint32_t y1, y2, y3; @@ -677,16 +677,16 @@ static uint64_t mulh (int64_t a, int64_t b) { int negate = (a < 0) != (b < 0); - uint64_t res = mulhu (a < 0 ? -a : a, b < 0 ? -b : b); - return negate ? ~res + (a * b == 0) : res; + uint64_t res = mulhu (a < 0 ? -(uint64_t)a : a, b < 0 ? -(uint64_t)b : b); + return negate ? ~res + ((uint64_t)a * (uint64_t)b == 0) : res; } static uint64_t mulhsu (int64_t a, uint64_t b) { int negate = a < 0; - uint64_t res = mulhu (a < 0 ? -a : a, b); - return negate ? ~res + (a * b == 0) : res; + uint64_t res = mulhu (a < 0 ? -(uint64_t)a : a, b); + return negate ? ~res + ((uint64_t)a * b == 0) : res; } static sim_cia @@ -757,16 +757,16 @@ execute_m (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op) TRACE_INSN (cpu, "mulw %s, %s, %s; // %s = %s * %s", rd_name, rs1_name, rs2_name, rd_name, rs1_name, rs2_name); RISCV_ASSERT_RV64 (cpu, "insn: %s", op->name); - store_rd (cpu, rd, EXTEND32 ((int32_t) riscv_cpu->regs[rs1] - * (int32_t) riscv_cpu->regs[rs2])); + store_rd (cpu, rd, EXTEND32 ((uint32_t) riscv_cpu->regs[rs1] + * (uint32_t) riscv_cpu->regs[rs2])); break; case MATCH_MULH: TRACE_INSN (cpu, "mulh %s, %s, %s; // %s = %s * %s", rd_name, rs1_name, rs2_name, rd_name, rs1_name, rs2_name); if (RISCV_XLEN (cpu) == 32) store_rd (cpu, rd, - ((int64_t)(signed_word) riscv_cpu->regs[rs1] - * (int64_t)(signed_word) riscv_cpu->regs[rs2]) >> 32); + ((uint64_t)(signed_word) riscv_cpu->regs[rs1] + * (uint64_t)(signed_word) riscv_cpu->regs[rs2]) >> 32); else store_rd (cpu, rd, mulh (riscv_cpu->regs[rs1], riscv_cpu->regs[rs2])); break; @@ -783,7 +783,7 @@ execute_m (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op) TRACE_INSN (cpu, "mulhsu %s, %s, %s; // %s = %s * %s", rd_name, rs1_name, rs2_name, rd_name, rs1_name, rs2_name); if (RISCV_XLEN (cpu) == 32) - store_rd (cpu, rd, ((int64_t)(signed_word) riscv_cpu->regs[rs1] + store_rd (cpu, rd, ((uint64_t)(signed_word) riscv_cpu->regs[rs1] * (uint64_t)riscv_cpu->regs[rs2]) >> 32); else store_rd (cpu, rd, mulhsu (riscv_cpu->regs[rs1], riscv_cpu->regs[rs2])); -- 2.39.2