From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03olkn2096.outbound.protection.outlook.com [40.92.58.96]) by sourceware.org (Postfix) with ESMTPS id F32753858C42 for ; Fri, 26 Apr 2024 05:07:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F32753858C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F32753858C42 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.92.58.96 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1714108028; cv=pass; b=bb5YuSjo30ReFDdBrRSSkgngiHYLqBuWUNUq6CxTz7hWeYkA5A1J+cBYzkQBix3cmo/KE7KBEHcx12032beOJXKqf9L7gbbQtGuOpr1gKmIP0MSTjpNc1i6RFIxPmysCbzeajYuBM4pTp8c+ELBG7g1DvzzjiM9SCnCZ2OuRlsI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1714108028; c=relaxed/simple; bh=7TkPZWbDxxSB/OBHRIv8puUVyRpk5GSsfz4c2bTTkmM=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=ZeMTOteUBpPBjzjqMgCwiLOri4PQItNtUf0+QRlvOlkPiSp6LU1l5CHgPUd84N7dorqVHIOZABEtaPn1d1y+Mn92ILAqhqAlhiZ7Z92y/2uJI4+o2ahfHkP87jhECYr9hrviKDECKOdHVw7TEMiHvw1jr8izrPoupTQSm7bQIrE= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yd9HRwYf+OJ+WoHcw3ZrAgYz9g8irGnpa/lbgsEOokXjoASmt1gy5LBDIYQ9wmd7FJH6OK8U2N4Tl8Zbtx1hTXDn+RReaVVYk4tc8bCzeAMxEO/19SKrkFU/P1cQjKw3JcUuzCAGrq4sW+YxhJadBW14smE4/yz+hdIsB6b8argLwgJvbayYV3E+Hgf/6RlqCSKfOdKq9nyCdqPFpbcGwGDAHyAL+/nNq+nacKUvcNGuAsRlQYLV4rhI6xfkRSGEy78vN0FiJAzIbjKhK/OE4DCdwwbrbNX8MVH47TsdgkQ2jOG6vhv1fqR/DmasqZ7rk0mipUZKBLNUn6PBuNErmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9v29zE+J2tcwPdxotlYbGeK/Fd+5Mc8kU1Le62szHGI=; b=bNzsuibw+/DfL89p8LRbXFKxneyK/lLA72BPJ9vpsSwfuri0H9dRcTpdXOiwDPEcYNuulG0VX7JTbXv9jIdz+kHZGJiEFY6WL5E909OEVA0yq4eh3KLkY4e/KCOKD3RPu4teM6r8pBl8xzcfH9K9r42RZmjFt5TjDKtTVWQOZCaWhUnrInPFYDx/sERA5SJRQNDfFoGfPY2XxzTTOtwSBA6GB6G3W5lhG+VO1PUiEHJSIcPVXDuUMd9ynYsHPlZWC5BLIcGS2Zu92RzOF9P9/PSuG39R+HhJbTuE5BBdWUHiFeVwTHALtqapduIdAebT67H6CYVUFqicg7KP+nqtRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=HOTMAIL.DE; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9v29zE+J2tcwPdxotlYbGeK/Fd+5Mc8kU1Le62szHGI=; b=kky+914C4ze1qtWaJ1qQaVCxhWKIApxf07QjjHpbCDfriyWFBr6SelPKc4x+1RT56+xD2Bj0n/g8sQ6ayssmKvpQPLorLf6Ejz7YKMWS0Wx77vW+sUghZiBgHPe4xiX9d3yN4yI/+UNGGrp+ht5R++/gBmTHrdd9wyItuxM17B3fJlGl9D3JwT6Ha0YGHSyZeUQf7t6Wd9StY3XKtZ4KlD2EOPPBo7zbJeJtEcN3B0tdoRXmgSZdNHpJSPrOtHhseyoeMmEdY4mlL7Q9+B0DkdkE8zpssGxDxRydMyuvzfPrF0Dxo22b/uj/3k5cEkWzl3TFxxP+VFrsJvGCMYoBog== Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) by AM9P193MB1410.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:2fd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Fri, 26 Apr 2024 05:07:03 +0000 Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::e65d:5dd2:5662:c61f]) by AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::e65d:5dd2:5662:c61f%4]) with mapi id 15.20.7472.045; Fri, 26 Apr 2024 05:07:03 +0000 Message-ID: Date: Fri, 26 Apr 2024 07:09:01 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: Fix libc_has_debug_info when there's no libc To: Thiago Jung Bauermann , gdb-patches@sourceware.org References: <20240426025251.1679310-1-thiago.bauermann@linaro.org> Content-Language: en-US From: Bernd Edlinger In-Reply-To: <20240426025251.1679310-1-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TMN: [84zojdT+6sR+j5YU/n2dkwnAY1lvkwR3FE6Cr3dh9xs7R6Cohr81If44OBuhdOIX] X-ClientProxiedBy: FR0P281CA0198.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ad::8) To AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P193MB1285:EE_|AM9P193MB1410:EE_ X-MS-Office365-Filtering-Correlation-Id: a9fc78f7-a359-46bf-0d7c-08dc65aeb5d7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +LbI0/lwdOPMvxSOyLFU1HQrBfRvMstRKR1L2FCWsDpsFQB8+qFo96jevBd8zADeqvonHztTTSM1f+bq6SwJX22QoZG9oaxTFfWYoa/Gunew2fSJaoKWKz6g/6Q8TDVUJTSSMi7yyHfehyxFTzTm07/Tolidu3up2yTZyZ4ao+mDWka2wKxhFe/jfM8gxKDCie2XbjbQUEymQTftiIMOX8QIjm8wc1Lp4cUUWJnEzWMjAb72lJHkEZg/OIKIrnuywiSWiG9Ke5jLJW3k4NgYGAYeM3pqCylo4I9wKtsjx9yESYBZb5dw6goo8F7IA8qMkuNrywIfZfpWLynnx5u3+n0hRTL7/u7vwEE5fgQzxnma/8TD2TsqwXuKQgjIXRlcpnZ3y2T5UktTvBNNYex1ThVYYvc4ZaYaxqhsxHyvjhRZ9/oI6jg2FvNs780hb4npMV8SjLO3GPOx9qkyZBkXUiXDIMLEcf7QkjP7aZ1Ue3HIPYcVCM7wkd/SfMYtazjpkTVbhH2eJ7nB6xpSoKBOAWH6fmHsXGKvJKLgXwEa7oFtQT4wkJ6tzgxDmdNIkbdGgtXlu0Cnph8bvmhAhb7iVIHKCDdVG1RViOvujj9H0yYRNHXZpvrQMU/eKz9f/WJQG71guV7s/um0wQF1r+aNEdTMQF2d0vy9yzborlBbdcQ= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFhyS0FlMjNqQU9tMlprWXVQbEpXa3piRXdINmJSbElQQ2dkVVB5Q2Z4VnpB?= =?utf-8?B?cVcxVWM3Sk8xYkZhSDVXamFHdVNSUGpQWGJNOVp0S1RuOVcwaHJJd0FjdXF2?= =?utf-8?B?eDFWMzdkbnBwampLSmV4TDBVb0hiQW9Zd28zRk5rclNkNHV3YU1PejlySlh2?= =?utf-8?B?RVAvS1U2WXJxbkVPK3phaWdSaTVsRnJmL0tDZjk0Z0wzTHpFS2N6REtWVWln?= =?utf-8?B?c0xCZndkeHlGMlNoRDBjRjN4Y3lMZEEyUnVTMXFPVHVuZjkyYnZZTjVkeXg4?= =?utf-8?B?T0J2TU1NZHVjdldNS2FPRm9zWGJMTUNxSmsxSjRrSUkrSUNRL00vZ1ZKZmpz?= =?utf-8?B?N2srNDM3NisyWHpCUHZ3cHUya2oxQmZnNmFSY0FKWGJiQlpjYWFFL2w2SjZv?= =?utf-8?B?VERicmNPV3ovcWxaMnQ0K290L2czblE0Z21HQ2lvNzJaY1N1bnNESi9jejZM?= =?utf-8?B?aUs3WkVtQWVtVjFaemhrZng1ek1UcXZ6NjRyVndLM1BLRjd1VHNDOW8vVjBL?= =?utf-8?B?ZlE5VUdaUjhUejBlbzQra1FmUUw3UHRUaFlxQzdSZkRUYThPM0kzRzBpdXQ0?= =?utf-8?B?eUV3OVN2c3RVTGk0KzRvUkZiS3MxK2hraWVTRFM1b2RyZkpEdXpPNTBWekh2?= =?utf-8?B?YklrL24xbitySklTZkFBRmlDaWdUKzRPYVdZS3YrWTMwYlpGWmRqazFOT1dM?= =?utf-8?B?WUsyRWZpbmtPSGZJN29vSCtNVDBzakJQTGJXc1FKMkNWSEdFcnZ3dEFMOU5O?= =?utf-8?B?M2kySDR2VlVKZkZpWjd0V0NvekxTV3JyVlg5SVNDYUJkSzZKNVA4NW1uNFM2?= =?utf-8?B?VDVIWm5YRUlSN2FMOTgzQmU1dS9rVVIyaDdPV2Q2Mno0ZjI1MVZhVVhEZTR1?= =?utf-8?B?VXRyMG9JZm1OOXlqS2xSTk5TVDI2K2FUVTBBb0srVDlBNVFuMzJ5SzUzT0Rq?= =?utf-8?B?NXRUMGgvekZuMTdhMGNRMDdJOW1EeGxpNGZHRUxNQ205dzBBNjJoZ0VhOHNq?= =?utf-8?B?d0FDMlZSVzdWK0RFL3FZV3dRWGx0STNvT3h0Q3dySlFyMkQ2Wk5KMHZpTXRE?= =?utf-8?B?S0NSZTVZRU1KZTJVRDhMMGZtNXJEVUxiVWRNWG9KZzc2VkxOeFp4MDBudUky?= =?utf-8?B?MHpwOXIrRG0zVGVDR2xSTU93NEJ0SWJmem8vM0tUMUZIdExYYkRlQmJ2R1VX?= =?utf-8?B?TXVZcHZiMlkzZFVWdmF0MU1taXRWT3dhZEFhSC9ZOXU5U1orUzZNVnNGdTVt?= =?utf-8?B?UEo4S1NtVDg2UUUyNUtBZUhxYkdYSlcwT20vRWRvOEFxendOT3h3aUJidlRX?= =?utf-8?B?bDlZY1RwU3BCYi95djBhVk5HcjBSbEhCUmt5TExCWnhiWGNPbHdCeGhVbzFX?= =?utf-8?B?eHA3c090NkpQVGZkcEhaLytLcXp5ZFN2WE81RzZzK2VMMXZ2aEw1dWNjdlM4?= =?utf-8?B?RzZlUVdsU0RGQlVXRGlZbEhGdzUvRHFhdDdPZ01LVGQrNlFCblZ4L1g1VHZF?= =?utf-8?B?WjRmaG13a3ZCS1J5aXBHZ1NqWjVVR1FoK3E3R1lnRFFRSUlaZG93SGhPMUhh?= =?utf-8?B?Q2NPd05zZ3AyTDZYU2x6Qzc2R0pqR0pmL0orU3VMd3lLeElDUkZrVEl3SFow?= =?utf-8?B?dHhnMnJ1MjBWRlVwbDlvNGwrdDhLZHJKc3RHTkR1UnZQMlRqTUpQN0tyMXlI?= =?utf-8?B?ZEhzWFVUSndGNG43b3Mvc1F4WWJQWENiY1dvQm1vb2taVG43dDN0Q0ptZmJL?= =?utf-8?Q?+FSz+DHvpLgjDVbWv40zamLHBtLk2XQNy2S8ZkY?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-80ceb.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: a9fc78f7-a359-46bf-0d7c-08dc65aeb5d7 X-MS-Exchange-CrossTenant-AuthSource: AS8P193MB1285.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 05:07:03.1321 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9P193MB1410 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/26/24 04:52, Thiago Jung Bauermann wrote: > Bernd reported a Tcl error when running gdb.base/relativedebug.exp with > a riscv-unknown-elf target with newlib (so there is no libc) because of > commit f5ef12c3f1af ("gdb/testsuite: Add libc_has_debug_info require > helper"): > > Running /home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.exp ... > FAIL: gdb.base/relativedebug.exp: info sharedlibrary libc.so > ERROR: tcl error sourcing /home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.exp. > ERROR: tcl error code TCL READ VARNAME > ERROR: can't read "libc_has_debug_info": no such variable > while executing > "verbose "$me: returning $libc_has_debug_info" 2" > (procedure "gdb_real__libc_has_debug_info" line 47) > invoked from within > "gdb_real__libc_has_debug_info" > ("uplevel" body line 1) > invoked from within > "uplevel 2 [list $real_name {*}$args]" > invoked from within > "gdb_do_cache_wrap $real_name {*}$args" > (procedure "gdb_do_cache" line 48) > invoked from within > "gdb_do_cache libc_has_debug_info" > (procedure "libc_has_debug_info" line 1) > invoked from within > "libc_has_debug_info" > ("uplevel" body line 1) > invoked from within > "uplevel 1 $fn" > (procedure "require" line 11) > invoked from within > "require {!target_info exists gdb,nosignals} libc_has_debug_info" > (file "/home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.exp" line 16) > > The problem is that when there's no libc.so in the inferior, > "info sharedlibrary libc.so" responds with an output that doesn't match > any of the patterns provided in libc_has_debug_info so gdb_test_multiple > matches an internal pattern for the GDB prompt and thus the > $libc_has_debug_info variable doesn't get set in the default pattern. > > Fix by: > > - always defining libc_has_debug_info and message with a default > value, > - adding a pattern for the case where there's no libc.so in the > inferior, and > - removing the default pattern, which doesn't serve a purpose anymore. > > Also, remove a couple of verbose messages which aren't really useful > because they're redundant with the $message variable. Tested-By: Bernd Edlinger Thanks Bernd. > --- > gdb/testsuite/lib/gdb.exp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 1e26937c0dcf..35e4de9e3b9d 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -3726,20 +3726,20 @@ gdb_caching_proc libc_has_debug_info {} { > gdb_reinitialize_dir $srcdir/$subdir > gdb_load "$obj" > runto_main > + set libc_has_debug_info 0 > + set message "unable to get information on libc.so" > set test "info sharedlibrary libc.so" > gdb_test_multiple $test $test { > -re ".*\(\\*\)\[^\r\n\]*/libc\.so.*$gdb_prompt $" { > # Matched the "(*)" in the "Syms Read" columns which means: > # "(*): Shared library is missing debugging information." > - verbose -log "$me: libc doesn't have debug info" > set libc_has_debug_info 0 > set message "libc doesn't have debug info" > } > -re ".*Yes\[ \t\]+\[^\r\n\]*/libc\.so.*$gdb_prompt $" { > - verbose -log "$me: libc has debug info" > set libc_has_debug_info 1 > } > - default { > + -re -wrap "No shared libraries matched." { > set libc_has_debug_info 0 > set message "libc not found in the inferior" > } > > base-commit: cd0dbe767775fdbfdc875a14f9080fdea0841c92