From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2079.outbound.protection.outlook.com [40.92.59.79]) by sourceware.org (Postfix) with ESMTPS id 7344F3849AD9 for ; Fri, 19 Apr 2024 20:19:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7344F3849AD9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7344F3849AD9 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.92.59.79 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713557987; cv=pass; b=Smnqn4XRxW3MUAxveFVlp0Lmm8HgYY+Rlpqe8lsSjTMpxzlNiqOJuc/Tntp95/Y1dh6NjPeCiRPT8y0q1ktAkqDgB5sCvrWGOTfnUca6w9TKYByoMA4LVbV5H4RL1VyJGEX4njo9BCM4Gv0af2eEonpgTjxzkrQ7dTDZsH0YZZE= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713557987; c=relaxed/simple; bh=OUXEQ7AwaE6I/0a316lOcXwEf65tqRxlOogzoI8Bxqc=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=X5BR3t8dNDmQl81ycC+ccCIwAo/oaWBj0+lwGRYi1UJlqCoGvv+pTrbJ5FWpTqSg0Z6SDoqbBw/TB4Wxta1GT5f9tVY84O+6AflbH+WEe3Amm95dl+nhqNeen2+udJ86JOSsCdh+OoQelWGDAFopBT9CdvkhUkH1ZIgXvQtU9/c= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZKAHjGv0B77+OX2FvfljX70EYlph1FHC7+9wR1CbRkeIwne7Ul9PEwZgidmJFLFTeQdGyHnCQQUxDDI2ZUVtjjU5bHZB6yKQWAKT/8F85/aTt+w9IReAERJQbcVcDHDY0CL6Qi65j4mu4WwTEA6phZchnL1uCcsMkovIOKeajnispZM2HsYk9osygIpnFycSv0+kW5u1gIMdkvz5x+2syGzmzeGiMD70EED5cVdTbfL4TThRqMpc5HE1UFaFNpGIzoj8DvzHitdlSWxuio0IlhynbmVoMkZGCAOB2QoRXT3THklKYPsoStkwbeN668UtoWMzgYZ4+V/aEfTl2G/Dfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8n9ROHbmsMoruGWBQvOMYpqTAIiz7eBQ309TFPGWlU0=; b=WdP0QB/0Ya0lnx8+c+MkzCEpaXMDL2Q5JljcyH6vzIhdIRn4L3oYvBABO8/v/0Y9FPegyjO+Ckifl3GpJ+PRfNmbwWHMVeUXEIbLzPT6GN+1Amh6Oz3GEMGup472D+GOy/z5yuei/Ig0HgCznrYP/1wOavFTjhz7Eg04YMpyDbV11X05lU/fuItpP+FTJsLLrZXezarsIG3LeHBKTmvx0uH/WZurwU53z93WyUHMrkTqCN6trzf2BHRD0RvkOXDvehF568MJMGpPuhNzquJTXV/LVn3OaFMZ7ZnQ4Bp4n8ltmaS9meazk+dWCqR9rxUvx3tWNcNbi9AKIgj4F8ABFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=HOTMAIL.DE; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8n9ROHbmsMoruGWBQvOMYpqTAIiz7eBQ309TFPGWlU0=; b=Ktbci0+ihfDVjA1qEbPAH+vVeudE6dNEAukLAHOgBJnrET7g7df5Qvjdgs+IzQwzuLGw8VZN12qrxQRaONjKhG+g1TLdi9wlpbRctVXbEFhdeBkQLodWT0SMXJRN5AZqpKDOFiCu5Ewe3xUSzQ/fQllUp7PXlorYWiXHfc0j5JXcSg5ouBWMpDLq6443bBiaxmBX/MZIukKUpkqeAjSIuVJyGPuQ642gJya2vH3wPKlUoNO5AqUmvCW/dLPXI0SApNI9g++xXKvCRNwT3VBsMb42HEU66X8nufIoaoNc+U21JvKQ/CKycS/lSgr3d28agTvl/srlyzEU8c1T7hgU9Q== Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) by AS8P193MB1367.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:39f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.43; Fri, 19 Apr 2024 20:19:43 +0000 Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::5403:f1ad:efaf:1f71]) by AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::5403:f1ad:efaf:1f71%4]) with mapi id 15.20.7472.042; Fri, 19 Apr 2024 20:19:43 +0000 Message-ID: Date: Fri, 19 Apr 2024 22:21:37 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix random dejagnu test abort with simulator target To: Tom de Vries , "gdb-patches@sourceware.org" References: <140d448b-56cf-4cbc-88c8-e77573797179@suse.de> <52bbb92c-5bf1-4c1f-a89c-6de46be82dd5@suse.de> Content-Language: en-US From: Bernd Edlinger In-Reply-To: <52bbb92c-5bf1-4c1f-a89c-6de46be82dd5@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TMN: [ocaqLWboT9rjm0kXbZGzXAjOggJ3wqHM2URcLBmeIi4pz773EnHNkn2HnN7gdiqF] X-ClientProxiedBy: FR4P281CA0364.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f8::12) To AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) X-Microsoft-Original-Message-ID: <6c6b2d76-0cc7-47af-9e44-6e621a3189ef@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P193MB1285:EE_|AS8P193MB1367:EE_ X-MS-Office365-Filtering-Correlation-Id: 76611f4e-c9a3-4fba-7022-08dc60ae0c88 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UI1IN6/R09OmFpGBqcagM9wAuLFbwXbpML8diwY9Qwud+xROpwbyJNSBfnkelZbPO0yHd5A8uswqkktC+Rc60loqPkrtKEoghbTTW0J/56K8gpnmMaoW2brRsTq3cy9rzCMmhDys/10JJ4k+ROkJgec7PYYRsHRhXoQmu70Va0QmgYEgkopRRszFIBKz8/+lfnopLnQI8TK4f/tjEJyV8st22D+i62Q0TH7Q+UK/+qfd38VRWpQ4sIG6hIZR96AaQcvGlGxIxhlf7dGnQzgrj4ArspqgmpGveNMsKEIbOQxJTDQimh+6FmzbHtjTQuOM2raAcHussv/QeVHwF3msICbg2RO0bkEcyOhLvXkcQrg5OrfTiR5UjTK2xuLnNum/JFWhfbgEO8enUMKCT1VFv3CJLiB1ve6ybO3aT1CXVXcbhxU5Oz88P/+kVENeLjMz+yNZKDogh1Vj73dxeVafhQjcIdZMNv0mv5ri+Eh585iYfpWZyyA0cRabRAnFoyl2XPac6pvrZl9gboNd1xFnE0R9zwGPD696HzDNBs/tdGMhXp4lwLfZ82+FlfgpzkswEbHyYOidNYfm3tXW1Gt24GOA3G4vXYN+xsZAY5skZsBizzozhrbtjajzv32w4KUCm2g30+Naj6yFg5EfpzYGzeAC4bxZ8Vk4OWNcL2VsL8s= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QTJqMmc1K1Bma3VONHMwVU5SRWJnVkZHQ1JuakRWa1hnWDVVelJKOHdpZnA0?= =?utf-8?B?akZqeGg4ZDFPek9ma082RzhDYXpKSXE4M3Q2OURqZS8yYlVlRC84SGF6ekVJ?= =?utf-8?B?ZW5WK1Y0cWFNZlFRdmNzMHdXelZ5NS9XbEFHZHN0TVlTenFJdURxZm9leFp4?= =?utf-8?B?SU5aQlhGTWwzTEM4L1QzWmtSeXVBM0Q0Sk1hRWExU3VXREZONktNUEtxNHBh?= =?utf-8?B?TDdOYUhvYUNZSWFkUkU2TFVyYThLclpyR1RWNUxBRFduQTJqWS8rcm83SjVw?= =?utf-8?B?MDVEVlJUNmxQQzJwcXp3TkUzNXRsanJBQVYzbTk5T2RPK0tnZkhEVUt0RUJh?= =?utf-8?B?SldFSS96UnVzbnNoZTBIdzBwRzFOLzIxbmdZNzlPRXZVNk5EanNzSEZ5Tm9F?= =?utf-8?B?YVFyS3lPZkN6ZlNtVTRSRGJBT0dZdzhqZ0dIbnZyRTFoWjdxQm1ZUEp4MVBk?= =?utf-8?B?aExmK2VOTlZkeVFtQmUxTU9ZRDllYi9OZERuUW9lRnNicktpK2c0ZCs3eDBF?= =?utf-8?B?MlpSbEVGL1lBdjlJbVFoR0dNbU1qTS9qemx5b0RtdkZSOW14emZ1Uko2YUc5?= =?utf-8?B?Nk9FRTdPQmM2empnR2xiZWJBSjQ0R2xYNWFzMDUvSFVybWVRUi9yQnZOTGRh?= =?utf-8?B?MFhkYWgwZGFhTG1teDlYaTJUekhaRTRxclJEMXg2OVhPTUEzeWZJazh5M01D?= =?utf-8?B?SHBBL2E5QVBxRjdXajNBT243L0dJSngwYldUWk4vVVdVMnBWYnFkLzJzSUxt?= =?utf-8?B?Yk83NnBtR0o2SzZxQXcycWFlV2oxbmRudUg0QzFwSlFhUXVzT2w2dElRY1M3?= =?utf-8?B?Q0E5MVlKbE1aZ1hid2VXak9TK2ZrQzhsRkRKenloTlhhS1dwQk82OW5TOUxu?= =?utf-8?B?SkNMYnhLUGFLV3pGZFF5L2o3N0tOU25YMHpoTWZqeStCM2FUdklLTlNDY0Zm?= =?utf-8?B?TVBXbk5JenBNanVnZzN4eEVpci9Gc3YwaUpreU95UkFuaXZjeU9KUlREOC9s?= =?utf-8?B?bGlLSTFDYXZncEt4Tjd3QUt3dFdSQlpUOVpQVnZwWHIxMGpLREJmbGYzdU0w?= =?utf-8?B?MWNDU01PZUM3WkxGYVJVclpNOFI0N2ZSZ0hNelVha0JlUHRROW93WW1sQVlj?= =?utf-8?B?ZGYxMHk0L0d4c0xINUNqL2pJZ09hQlkvUVJmUXV3b1BCOTR6ZGcwbWNDc0hh?= =?utf-8?B?SHVrYStiSXdOK09Kb3Z3UHFrOW93MXhjcFIxL3QvN3RxV1c5TDkrWU13d05Y?= =?utf-8?B?aCtQNHNZTUl5bTYvRG9HaS9CZVVLWjV2Zk5xd2NrTFFNNXN0Y1hSNm5qY2xK?= =?utf-8?B?UStUQ1Y1ZHVhOGtnMEpvZHRiVXBHNzRnekxpRDJqeWlNUGFyb25DbkQrS2F4?= =?utf-8?B?NkZJMFc4WUdkdjZneG9rL2U4SEpCei9yK1VBc25YUXlFRGo3TW5WTFE3WFFp?= =?utf-8?B?emt4cGFkRGhGNmFpbjlnc0tSZFJWM3dvK0l1S2RoYVBwTG1LbDdtM3Zoai94?= =?utf-8?B?VG5Hb0tqNE1ETG90bWd1YkVTRUpXQUU2UDNFeEw2VU1JVG8xaG5ZV0swa2Zt?= =?utf-8?B?a3BiSWtwYUdHVVY2N0x3M3I5V0RiL1JaOXRuRzNRT2Z1ZFJobUlsbWJXZ0xZ?= =?utf-8?B?dmY3M09ncS9DcW9zbWwrMHo3MmlGdEZiSFR1cDBJbExJS1ZnWFY5Q2F1RkJJ?= =?utf-8?B?Njk2c0VRRlBqdTdIT0d3T0s4dFoxVzY1bnJpYXlXaFVESUExemFzbXQyWUpR?= =?utf-8?Q?4yQce7n/wUTwjgGq5mDxfT+xkNCbz2aTtALuy/H?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-80ceb.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 76611f4e-c9a3-4fba-7022-08dc60ae0c88 X-MS-Exchange-CrossTenant-AuthSource: AS8P193MB1285.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 20:19:43.4141 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P193MB1367 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/19/24 18:30, Tom de Vries wrote: > > OK, I see now. > > We spawn gdb on host to spawn sleep on target. > > So I get to: > ... > # The test-case relies on "run" from the command line, so it only works > # with "target native", so we need host == target. > # > # The test-case uses "exp_pid -i $gdb_spawn_id" which doesn't work with > # remote host, so we need build == host. > # > # In other words, we need build == host == target. > require {!is_remote host} {!is_remote target} > > # Check that we have "target native" as opposed to native-gdbserver etc. > require {string equal [target_info gdb_protocol] ""} > ... > > Having said that, I'm not sure if that addresses your problem, since I don't have experience with simulator setups. > > Perhaps "require isnative" is also necessary for simulators?  That proc seems to check for target triplet == build triplet, while I think we're more interested in target triplet == host triplet, but it may be a sufficient proxy. > hmm... [target_info is_simulator] is explicitly set for simulators. see /usr/share/dejagnu/baseboards/basic-sim.exp: set_board_info is_simulator 1 I use RUNTESTFLAGS="--target_board=multi-sim" I tried your suggested change, and it worked for me: --- a/gdb/testsuite/gdb.base/sigwinch-notty.exp +++ b/gdb/testsuite/gdb.base/sigwinch-notty.exp @@ -19,11 +19,17 @@ require {!target_info exists gdb,nosignals} -# The testfile relies on "run" from the command line, so only works -# with "target native". -if { [target_info gdb_protocol] != "" || [target_info is_simulator] != ""} { - return -} +# The test-case relies on "run" from the command line, so it only works +# with "target native", so we need host == target. +# +# The test-case uses "exp_pid -i $gdb_spawn_id" which doesn't work with +# remote host, so we need build == host. +# +# In other words, we need build == host == target. +require {!is_remote host} {!is_remote target} + +# Check that we have "target native" as opposed to native-gdbserver etc. +require {string equal [target_info gdb_protocol] ""} gdb_exit Running /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/sigwinch-notty.exp ... Executing on build: rm -rf /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/outputs/gdb.base/sigwinch-notty (timeout = 300) builtin_spawn -ignore SIGHUP rm -rf /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/outputs/gdb.base/sigwinch-notty^M UNSUPPORTED: gdb.base/sigwinch-notty.exp: require failed: !is_remote target testcase /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/sigwinch-notty.exp completed in 0 seconds so that would be acceptable. Thanks Bernd.