From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Tom Tromey <tom@tromey.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix gdb crash due to SIGPIPE when the compile command fails
Date: Mon, 14 Jun 2021 16:36:47 +0200 [thread overview]
Message-ID: <AS8PR10MB47120E4C22BA3F70201A65DAE4319@AS8PR10MB4712.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <yddo8c8bnzw.fsf@CeBiTec.Uni-Bielefeld.DE>
On 6/14/21 2:59 PM, Rainer Orth wrote:
> Hi Bernd,
>
>>> and I have a very hard time deciding where <signal.h> needs to be
>>> included given the enormous range of headers included by compile.c.
>>>
>>
>> Oh, I see, looks like it did only work by chance.
>> Maybe just include it after all other headers:
>
> that's what I've been using myself to fix the build locally. However,
> as I said I'm completely uncertain if that's the right fix, especially
> given that gdb/compile files don't include any system headers directly.
>
Are you concerned, that it might be unavailable on some platfroms?
I seems to be included where needed in many gdb source files.
It's not the plain system header anyways, actually it seems to be
a gnulib-enhanced version which tries to improve the portability.
Bernd.
next prev parent reply other threads:[~2021-06-14 14:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 17:31 Bernd Edlinger
2021-06-02 18:21 ` Tom Tromey
2021-06-02 22:19 ` Christian Biesinger
2021-06-03 5:45 ` Bernd Edlinger
2021-06-04 13:39 ` Tom Tromey
2021-06-05 11:44 ` Bernd Edlinger
2021-06-05 12:04 ` Andrew Burgess
2021-06-05 12:27 ` Bernd Edlinger
2021-06-05 14:04 ` Tom Tromey
2021-06-14 11:41 ` Rainer Orth
2021-06-14 12:57 ` Bernd Edlinger
2021-06-14 12:59 ` Rainer Orth
2021-06-14 14:36 ` Bernd Edlinger [this message]
2021-06-14 14:39 ` Rainer Orth
2021-06-14 15:07 ` Tom Tromey
2021-06-15 11:10 ` Rainer Orth
2021-06-14 15:04 ` Tom Tromey
2021-06-14 23:35 ` Pedro Alves
2021-06-15 5:14 ` Bernd Edlinger
2021-06-15 11:16 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR10MB47120E4C22BA3F70201A65DAE4319@AS8PR10MB4712.EURPRD10.PROD.OUTLOOK.COM \
--to=bernd.edlinger@hotmail.de \
--cc=gdb-patches@sourceware.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).