From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-oln040092069106.outbound.protection.outlook.com [40.92.69.106]) by sourceware.org (Postfix) with ESMTPS id 7A01A3938C11 for ; Mon, 14 Jun 2021 14:36:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A01A3938C11 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fEMjcHqCvnJq2YG5SCkUOEaVrxuPLdp+wAaG86sSEdOgmkdvSGn2mwwGnyeWFbPjftQMOIf28AW7nDDnbHJEVpnqj1iaoJvwyblSRPRbUdx6jh/cNDW2SkgwkEZq0pU5XujJ/aJaWpSHywtBLTuv8LfXQ87Aek7k8ZST9vZdXWqbeFzdZ/tI/SXoEcRrTkaweH+T6IrhpDra1ewQVyezRZm5QNBaHPmupY6HQNAXmt6dQaUvkoAL0HtgUNwzHK8J1XtWL1fhOOnU+KMIVLSE3c1DcLCP0u6w92ETkbAkqjpaRB0CxFFG4OVz+jes/DpmK+jFzU7d0SDdoI6MvRUlow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nyl6k94eL+AepZQR4cfq1cmRgLazNDeJlw9Dek7JBSk=; b=CQT61le20bWdQ4SrGnjolp/Ev9BkCC1vWipiygPSPQgeN5j5YD9QT4RgdnLAYr0zGxne36XbWF+T3UooclgNuiToib1LQ7lPZaW0kLJbUGSHQg4FkBSn+/X7qHqWJCCp00lGG42shmjh5JvQyVeogr+jV2jpYBoNjU8TOkjPvDp858Q9F5mxqGJGq26ferrTgWxuNMlThMTd+DPm4jFGVlIoetg1i/NShfsSMEB/QKcbsigpS+Z5s4XWn8wQntsP79dKY5hPMlfj78BjuRzfc61zZ7369DrA2s9NZS3x1Bscp66hmQRaWIhIjesqluh41dgkP14i/oBnj9JwKwcSlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from AM5EUR02FT065.eop-EUR02.prod.protection.outlook.com (2a01:111:e400:7e1c::49) by AM5EUR02HT041.eop-EUR02.prod.protection.outlook.com (2a01:111:e400:7e1c::492) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21; Mon, 14 Jun 2021 14:36:50 +0000 Received: from AS8PR10MB4712.EURPRD10.PROD.OUTLOOK.COM (2a01:111:e400:7e1c::40) by AM5EUR02FT065.mail.protection.outlook.com (2a01:111:e400:7e1c::281) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Mon, 14 Jun 2021 14:36:49 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:7C06CC1146CBB12E1CD5003164743491930DAE958077DE93080D4716D47C6361; UpperCasedChecksum:01D00542819BBFEDCCB698EE8AFE8DF8A1081CED9791264BE15B586AD8C2EBE1; SizeAsReceived:8383; Count:48 Received: from AS8PR10MB4712.EURPRD10.PROD.OUTLOOK.COM ([fe80::844c:ffa:7f96:bdc8]) by AS8PR10MB4712.EURPRD10.PROD.OUTLOOK.COM ([fe80::844c:ffa:7f96:bdc8%5]) with mapi id 15.20.4219.025; Mon, 14 Jun 2021 14:36:49 +0000 Subject: Re: [PATCH] Fix gdb crash due to SIGPIPE when the compile command fails To: Rainer Orth Cc: Tom Tromey , "gdb-patches@sourceware.org" References: <87tumgp1ob.fsf@tromey.com> <87zgw5oijf.fsf@tromey.com> From: Bernd Edlinger Message-ID: Date: Mon, 14 Jun 2021 16:36:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TMN: [iJKbkZf1/X3TJWL1pVvkjfi1eBU2KqMf] X-ClientProxiedBy: FR0P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::16) To AS8PR10MB4712.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:31d::16) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (92.211.178.34) by FR0P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.9 via Frontend Transport; Mon, 14 Jun 2021 14:36:48 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: cb7db18c-7f3e-4a46-04d2-08d92f41d7f6 X-MS-TrafficTypeDiagnostic: AM5EUR02HT041: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p3rC4dJRck83F3avxj8eIOAjucPlsZD61mIAJy9eGB8H8JjFQShyKuRt6jBYkxC0Ml8ynLACBVYO4ZqN8a6FWYfZaJ7L4hMqU7UyPpRsrNeFJ0ULCf2BERmBDdbYCF9B5/RMW9LhjmMf8/TQspPqk7tGQse2335WO/wvJYm63fqhhga4bP8a9mzsVCK7JD4IBpImNI70Qyl+Mp+a+vzKITQ++2rWwa50e7/ouGNwZQ7KaiwEYa+QdVAMtNBO9ybFXfkLKYHBZpUo6VQcza/6EOn2+EF8r7WBgfaZKopKoCK1PG2zV8ySWDPiLmOyVAsnu7wm6uq4Cv/KCV+HDU9QYAfjj6SZpkUAmNbHtpkn5TtxmBGI+wKpq29rQbaQOv24KPQoWaq+spTHNRxYWg1VPg== X-MS-Exchange-AntiSpam-MessageData: V3BadtybMnpBywoPkNDiG6AOivMEUv3KOYFLAZ1GyOG0y+WMYG1vQJCtBE4+52ABLMxeRR/YLrvr2y5is/NXCUcVQp2g8sg6GMVrnKL47d+/xnzM8VLwuUFa4jVoNry78EJv3R+YJqFw0kaDgzwG9Q== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb7db18c-7f3e-4a46-04d2-08d92f41d7f6 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2021 14:36:49.9000 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: AM5EUR02FT065.eop-EUR02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5EUR02HT041 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jun 2021 14:36:52 -0000 On 6/14/21 2:59 PM, Rainer Orth wrote: > Hi Bernd, > >>> and I have a very hard time deciding where needs to be >>> included given the enormous range of headers included by compile.c. >>> >> >> Oh, I see, looks like it did only work by chance. >> Maybe just include it after all other headers: > > that's what I've been using myself to fix the build locally. However, > as I said I'm completely uncertain if that's the right fix, especially > given that gdb/compile files don't include any system headers directly. > Are you concerned, that it might be unavailable on some platfroms? I seems to be included where needed in many gdb source files. It's not the plain system header anyways, actually it seems to be a gnulib-enhanced version which tries to improve the portability. Bernd.