* [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o
@ 2011-01-19 21:20 Kevin Buettner
2011-01-19 21:39 ` Paul Koning
0 siblings, 1 reply; 14+ messages in thread
From: Kevin Buettner @ 2011-01-19 21:20 UTC (permalink / raw)
To: gdb-patches
I spent some time last year fixing bitrot in remote-mips.c, but
forgot to update configure.tgt so that it's actually used by mips
targets.
Any objections to the patch below?
Kevin
* configure.tgt (mips*-*-*): Add remote-mips.o to gdb_target_obs.
Index: configure.tgt
===================================================================
RCS file: /cvs/src/src/gdb/configure.tgt,v
retrieving revision 1.241
diff -u -p -r1.241 configure.tgt
--- configure.tgt 14 Jan 2011 18:16:34 -0000 1.241
+++ configure.tgt 19 Jan 2011 20:51:20 -0000
@@ -373,7 +373,7 @@ mips64*-*-openbsd*)
;;
mips*-*-*)
# Target: MIPS
- gdb_target_obs="mips-tdep.o"
+ gdb_target_obs="mips-tdep.o remote-mips.o"
gdb_sim=../sim/mips/libsim.a
;;
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o
2011-01-19 21:20 [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o Kevin Buettner
@ 2011-01-19 21:39 ` Paul Koning
2011-01-19 21:50 ` Michael Snyder
2011-01-19 21:55 ` Kevin Buettner
0 siblings, 2 replies; 14+ messages in thread
From: Paul Koning @ 2011-01-19 21:39 UTC (permalink / raw)
To: Kevin Buettner; +Cc: gdb-patches
Shouldn't that just be for the MIPS based targets (if there still are any left) that use this protocol?
A lot of them probably just use the standard GDB remote protocol (I know ours does -- NetBSD based).
paul
On Jan 19, 2011, at 4:14 PM, Kevin Buettner wrote:
> I spent some time last year fixing bitrot in remote-mips.c, but
> forgot to update configure.tgt so that it's actually used by mips
> targets.
>
> Any objections to the patch below?
>
> Kevin
>
> * configure.tgt (mips*-*-*): Add remote-mips.o to gdb_target_obs.
>
> Index: configure.tgt
> ===================================================================
> RCS file: /cvs/src/src/gdb/configure.tgt,v
> retrieving revision 1.241
> diff -u -p -r1.241 configure.tgt
> --- configure.tgt 14 Jan 2011 18:16:34 -0000 1.241
> +++ configure.tgt 19 Jan 2011 20:51:20 -0000
> @@ -373,7 +373,7 @@ mips64*-*-openbsd*)
> ;;
> mips*-*-*)
> # Target: MIPS
> - gdb_target_obs="mips-tdep.o"
> + gdb_target_obs="mips-tdep.o remote-mips.o"
> gdb_sim=../sim/mips/libsim.a
> ;;
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o
2011-01-19 21:39 ` Paul Koning
@ 2011-01-19 21:50 ` Michael Snyder
2011-01-19 21:55 ` Kevin Buettner
1 sibling, 0 replies; 14+ messages in thread
From: Michael Snyder @ 2011-01-19 21:50 UTC (permalink / raw)
To: Paul Koning; +Cc: Kevin Buettner, gdb-patches
It won't hurt anything, but it probably won't be used. AFAIK, that file
is just for monitor debugging on a bare-metal eval board.
Paul Koning wrote:
> Shouldn't that just be for the MIPS based targets (if there still are any left) that use this protocol?
>
> A lot of them probably just use the standard GDB remote protocol (I know ours does -- NetBSD based).
>
> paul
>
> On Jan 19, 2011, at 4:14 PM, Kevin Buettner wrote:
>
>> I spent some time last year fixing bitrot in remote-mips.c, but
>> forgot to update configure.tgt so that it's actually used by mips
>> targets.
>>
>> Any objections to the patch below?
>>
>> Kevin
>>
>> * configure.tgt (mips*-*-*): Add remote-mips.o to gdb_target_obs.
>>
>> Index: configure.tgt
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/configure.tgt,v
>> retrieving revision 1.241
>> diff -u -p -r1.241 configure.tgt
>> --- configure.tgt 14 Jan 2011 18:16:34 -0000 1.241
>> +++ configure.tgt 19 Jan 2011 20:51:20 -0000
>> @@ -373,7 +373,7 @@ mips64*-*-openbsd*)
>> ;;
>> mips*-*-*)
>> # Target: MIPS
>> - gdb_target_obs="mips-tdep.o"
>> + gdb_target_obs="mips-tdep.o remote-mips.o"
>> gdb_sim=../sim/mips/libsim.a
>> ;;
>>
>>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o
2011-01-19 21:39 ` Paul Koning
2011-01-19 21:50 ` Michael Snyder
@ 2011-01-19 21:55 ` Kevin Buettner
2011-01-19 21:55 ` Michael Snyder
2011-01-19 22:02 ` Paul Koning
1 sibling, 2 replies; 14+ messages in thread
From: Kevin Buettner @ 2011-01-19 21:55 UTC (permalink / raw)
To: gdb-patches; +Cc: Paul Koning
On Wed, 19 Jan 2011 16:20:50 -0500
Paul Koning <paul_koning@Dell.com> wrote:
> Shouldn't that just be for the MIPS based targets (if there still
> are any left) that use this protocol?
I want remote-mips.o to be enabled for the various mips*-elf targets.
Would the patch be more palatable if I were to add a mips*-*-elf pattern
for this case?
> A lot of them probably just use the standard GDB remote protocol (I
> know ours does -- NetBSD based).
Keep in mind that adding remote-mips.o doesn't prevent the use of GDB's
remote serial protocol. The "target remote" command will continue
to work just as it always has.
Also, I see the pattern "mips*-*-netbsd* | mips*-*-knetbsd*-gnu" in
configure.tgt. So NetBSD wouldn't be affected by my change anyway.
Kevin
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o
2011-01-19 21:55 ` Kevin Buettner
@ 2011-01-19 21:55 ` Michael Snyder
2011-01-20 0:55 ` Kevin Buettner
2011-01-19 22:02 ` Paul Koning
1 sibling, 1 reply; 14+ messages in thread
From: Michael Snyder @ 2011-01-19 21:55 UTC (permalink / raw)
To: Kevin Buettner; +Cc: gdb-patches, Paul Koning
Kevin Buettner wrote:
> On Wed, 19 Jan 2011 16:20:50 -0500
> Paul Koning <paul_koning@Dell.com> wrote:
>
>> Shouldn't that just be for the MIPS based targets (if there still
>> are any left) that use this protocol?
>
> I want remote-mips.o to be enabled for the various mips*-elf targets.
> Would the patch be more palatable if I were to add a mips*-*-elf pattern
> for this case?
>
>> A lot of them probably just use the standard GDB remote protocol (I
>> know ours does -- NetBSD based).
>
> Keep in mind that adding remote-mips.o doesn't prevent the use of GDB's
> remote serial protocol. The "target remote" command will continue
> to work just as it always has.
>
> Also, I see the pattern "mips*-*-netbsd* | mips*-*-knetbsd*-gnu" in
> configure.tgt. So NetBSD wouldn't be affected by my change anyway.
I think mips-*-elf is appropriate.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o
2011-01-19 21:55 ` Michael Snyder
@ 2011-01-20 0:55 ` Kevin Buettner
2011-01-20 5:58 ` Michael Snyder
2011-01-20 16:19 ` Ulrich Weigand
0 siblings, 2 replies; 14+ messages in thread
From: Kevin Buettner @ 2011-01-20 0:55 UTC (permalink / raw)
To: gdb-patches; +Cc: Michael Snyder, Paul Koning
On Wed, 19 Jan 2011 13:54:58 -0800
Michael Snyder <msnyder@vmware.com> wrote:
> I think mips-*-elf is appropriate.
Below is a revised patch which adds a mips*-*-elf stanza.
Kevin
* configure.tgt (mips*-*-elf): New; just like mips*-*-*, but
with remote-mips.o added to gdb_target_obs.
Index: configure.tgt
===================================================================
RCS file: /cvs/src/src/gdb/configure.tgt,v
retrieving revision 1.241
diff -u -p -r1.241 configure.tgt
--- configure.tgt 14 Jan 2011 18:16:34 -0000 1.241
+++ configure.tgt 19 Jan 2011 23:34:33 -0000
@@ -371,6 +371,11 @@ mips64*-*-openbsd*)
gdb_target_obs="mips-tdep.o mips64obsd-tdep.o \
corelow.o solib.o solib-svr4.o"
;;
+mips*-*-elf)
+ # Target: MIPS ELF
+ gdb_target_obs="mips-tdep.o remote-mips.o"
+ gdb_sim=../sim/mips/libsim.a
+ ;;
mips*-*-*)
# Target: MIPS
gdb_target_obs="mips-tdep.o"
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o
2011-01-20 0:55 ` Kevin Buettner
@ 2011-01-20 5:58 ` Michael Snyder
2011-01-20 16:19 ` Ulrich Weigand
1 sibling, 0 replies; 14+ messages in thread
From: Michael Snyder @ 2011-01-20 5:58 UTC (permalink / raw)
To: Kevin Buettner; +Cc: gdb-patches, Paul Koning
Kevin Buettner wrote:
> On Wed, 19 Jan 2011 13:54:58 -0800
> Michael Snyder <msnyder@vmware.com> wrote:
>
>> I think mips-*-elf is appropriate.
>
> Below is a revised patch which adds a mips*-*-elf stanza.
That looks good.
> * configure.tgt (mips*-*-elf): New; just like mips*-*-*, but
> with remote-mips.o added to gdb_target_obs.
>
> Index: configure.tgt
> ===================================================================
> RCS file: /cvs/src/src/gdb/configure.tgt,v
> retrieving revision 1.241
> diff -u -p -r1.241 configure.tgt
> --- configure.tgt 14 Jan 2011 18:16:34 -0000 1.241
> +++ configure.tgt 19 Jan 2011 23:34:33 -0000
> @@ -371,6 +371,11 @@ mips64*-*-openbsd*)
> gdb_target_obs="mips-tdep.o mips64obsd-tdep.o \
> corelow.o solib.o solib-svr4.o"
> ;;
> +mips*-*-elf)
> + # Target: MIPS ELF
> + gdb_target_obs="mips-tdep.o remote-mips.o"
> + gdb_sim=../sim/mips/libsim.a
> + ;;
> mips*-*-*)
> # Target: MIPS
> gdb_target_obs="mips-tdep.o"
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o
2011-01-20 0:55 ` Kevin Buettner
2011-01-20 5:58 ` Michael Snyder
@ 2011-01-20 16:19 ` Ulrich Weigand
2011-01-21 1:14 ` Kevin Buettner
1 sibling, 1 reply; 14+ messages in thread
From: Ulrich Weigand @ 2011-01-20 16:19 UTC (permalink / raw)
To: Kevin Buettner; +Cc: gdb-patches, Michael Snyder, Paul Koning
Kevin Buettner wrote:
> * configure.tgt (mips*-*-elf): New; just like mips*-*-*, but
> with remote-mips.o added to gdb_target_obs.
remote-mips.o should then also be added to ALL_TARGET_OBS in Makefile.in,
so that it is available with --enable-targets=all builds.
Also, for some reason the ARI scripts specifically ignore remote-mips.c,
see the gdb_find.sh script ... This probably should be removed as well if
remote-mips.c is now regularly built.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o
2011-01-20 16:19 ` Ulrich Weigand
@ 2011-01-21 1:14 ` Kevin Buettner
2011-01-21 12:44 ` Ulrich Weigand
2011-01-24 21:52 ` Kevin Buettner
0 siblings, 2 replies; 14+ messages in thread
From: Kevin Buettner @ 2011-01-21 1:14 UTC (permalink / raw)
To: gdb-patches; +Cc: Ulrich Weigand
On Thu, 20 Jan 2011 15:51:25 +0100 (CET)
"Ulrich Weigand" <uweigand@de.ibm.com> wrote:
> Kevin Buettner wrote:
>
> > * configure.tgt (mips*-*-elf): New; just like mips*-*-*, but
> > with remote-mips.o added to gdb_target_obs.
>
> remote-mips.o should then also be added to ALL_TARGET_OBS in Makefile.in,
> so that it is available with --enable-targets=all builds.
>
> Also, for some reason the ARI scripts specifically ignore remote-mips.c,
> see the gdb_find.sh script ... This probably should be removed as well if
> remote-mips.c is now regularly built.
Hi Ulrich,
Thanks for letting me know about the other files that require updating.
I've appended an updated patch below. I did an --enable-targets=all
build to verify that the target commands implemented in remote-mips.c
are available in the resulting gdb binary. (They are.) I also wanted
to make sure that the build didn't blow up as a result of adding this
file. (It didn't.)
Note the separate ChangeLog entry for the GDB admin script
gdb_find.sh. I don't see a ChangeLog file among the admin scripts, so
I'll just use it as the commit message when I commit it.
I'll wait another day or so for further comments before committing.
Kevin
* configure.tgt (mips*-*-elf): New; just like mips*-*-*, but
with remote-mips.o added to gdb_target_obs.
* Makefile.in (ALL_TARGET_OBS): Add remote-mips.o.
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.1146
diff -u -p -r1.1146 Makefile.in
--- Makefile.in 14 Jan 2011 13:38:23 -0000 1.1146
+++ Makefile.in 20 Jan 2011 23:22:18 -0000
@@ -554,7 +554,7 @@ ALL_TARGET_OBS = \
solib-frv.o solib-irix.o solib-svr4.o solib-target.o \
solib-som.o solib-pa64.o solib-darwin.o \
dbug-rom.o dink32-rom.o ppcbug-rom.o m32r-rom.o dsrec.o monitor.o \
- remote-m32r-sdi.o \
+ remote-m32r-sdi.o remote-mips.o \
xcoffread.o \
symfile-mem.o \
corelow.o \
Index: configure.tgt
===================================================================
RCS file: /cvs/src/src/gdb/configure.tgt,v
retrieving revision 1.241
diff -u -p -r1.241 configure.tgt
--- configure.tgt 14 Jan 2011 18:16:34 -0000 1.241
+++ configure.tgt 20 Jan 2011 23:22:18 -0000
@@ -371,6 +371,11 @@ mips64*-*-openbsd*)
gdb_target_obs="mips-tdep.o mips64obsd-tdep.o \
corelow.o solib.o solib-svr4.o"
;;
+mips*-*-elf)
+ # Target: MIPS ELF
+ gdb_target_obs="mips-tdep.o remote-mips.o"
+ gdb_sim=../sim/mips/libsim.a
+ ;;
mips*-*-*)
# Target: MIPS
gdb_target_obs="mips-tdep.o"
In /cvs/gdbadmin/ss:
* gdb_find.sh: Don't prune remote-mips.c.
Index: gdb_find.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_find.sh,v
retrieving revision 1.14
diff -u -p -r1.14 gdb_find.sh
--- gdb_find.sh 8 Oct 2009 13:07:31 -0000 1.14
+++ gdb_find.sh 20 Jan 2011 22:29:35 -0000
@@ -12,5 +12,4 @@ find "$@" \
-name '*-exp.c' -prune -o \
-name ada-lex.c -prune -o \
-name cp-name-parser.c -prune -o \
- -name remote-mips.c -prune -o \
-type f -name '*.[lyhc]' -print | sort
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o
2011-01-21 1:14 ` Kevin Buettner
@ 2011-01-21 12:44 ` Ulrich Weigand
2011-01-24 21:52 ` Kevin Buettner
1 sibling, 0 replies; 14+ messages in thread
From: Ulrich Weigand @ 2011-01-21 12:44 UTC (permalink / raw)
To: Kevin Buettner; +Cc: gdb-patches
Kevin Buettner wrote:
> I've appended an updated patch below. I did an --enable-targets=all
> build to verify that the target commands implemented in remote-mips.c
> are available in the resulting gdb binary. (They are.) I also wanted
> to make sure that the build didn't blow up as a result of adding this
> file. (It didn't.)
>
> Note the separate ChangeLog entry for the GDB admin script
> gdb_find.sh. I don't see a ChangeLog file among the admin scripts, so
> I'll just use it as the commit message when I commit it.
Looks good to me, thanks!
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o
2011-01-21 1:14 ` Kevin Buettner
2011-01-21 12:44 ` Ulrich Weigand
@ 2011-01-24 21:52 ` Kevin Buettner
2011-01-24 21:58 ` Joel Brobecker
1 sibling, 1 reply; 14+ messages in thread
From: Kevin Buettner @ 2011-01-24 21:52 UTC (permalink / raw)
To: gdb-patches
On Thu, 20 Jan 2011 17:37:48 -0700
Kevin Buettner <kevinb@redhat.com> wrote:
> * configure.tgt (mips*-*-elf): New; just like mips*-*-*, but
> with remote-mips.o added to gdb_target_obs.
> * Makefile.in (ALL_TARGET_OBS): Add remote-mips.o.
I've committed this part.
But...
> In /cvs/gdbadmin/ss:
>
> * gdb_find.sh: Don't prune remote-mips.c.
I was unable to commit this change. Here is the error that I saw
when I attempted the commit:
Checking in gdb_find.sh;
/cvs/gdbadmin/ss/gdb_find.sh,v <-- gdb_find.sh
new revision: 1.15; previous revision: 1.14
cvs [commit aborted]: could not open lock file `/cvs/gdbadmin/ss/,gdb_find.sh,': Permission denied
Kevin
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o
2011-01-24 21:52 ` Kevin Buettner
@ 2011-01-24 21:58 ` Joel Brobecker
2011-01-24 23:01 ` Kevin Buettner
0 siblings, 1 reply; 14+ messages in thread
From: Joel Brobecker @ 2011-01-24 21:58 UTC (permalink / raw)
To: Kevin Buettner; +Cc: gdb-patches
> > In /cvs/gdbadmin/ss:
> >
> > * gdb_find.sh: Don't prune remote-mips.c.
>
> I was unable to commit this change. Here is the error that I saw
> when I attempted the commit:
No comprendo why it worked for me but not for you. I looked at the
permissions, and none of them made sense to me, so for sure I'm missing
something. Nevertheless, I checked the change in, and updated the
checkout on sourceware.org (this has to be done manually).
--
Joel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o
2011-01-24 21:58 ` Joel Brobecker
@ 2011-01-24 23:01 ` Kevin Buettner
0 siblings, 0 replies; 14+ messages in thread
From: Kevin Buettner @ 2011-01-24 23:01 UTC (permalink / raw)
To: gdb-patches
On Mon, 24 Jan 2011 16:51:54 -0500
Joel Brobecker <brobecker@adacore.com> wrote:
> > > In /cvs/gdbadmin/ss:
> > >
> > > * gdb_find.sh: Don't prune remote-mips.c.
> >
> > I was unable to commit this change. Here is the error that I saw
> > when I attempted the commit:
>
> No comprendo why it worked for me but not for you. I looked at the
> permissions, and none of them made sense to me, so for sure I'm missing
> something. Nevertheless, I checked the change in, and updated the
> checkout on sourceware.org (this has to be done manually).
Hi Joel,
Thanks for commiting the gdb_find.sh patch for me.
Kevin
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o
2011-01-19 21:55 ` Kevin Buettner
2011-01-19 21:55 ` Michael Snyder
@ 2011-01-19 22:02 ` Paul Koning
1 sibling, 0 replies; 14+ messages in thread
From: Paul Koning @ 2011-01-19 22:02 UTC (permalink / raw)
To: Kevin Buettner; +Cc: gdb-patches
On Jan 19, 2011, at 4:50 PM, Kevin Buettner wrote:
> On Wed, 19 Jan 2011 16:20:50 -0500
> Paul Koning <paul_koning@Dell.com> wrote:
>
>> Shouldn't that just be for the MIPS based targets (if there still
>> are any left) that use this protocol?
>
> I want remote-mips.o to be enabled for the various mips*-elf targets.
> Would the patch be more palatable if I were to add a mips*-*-elf pattern
> for this case?
>
>> A lot of them probably just use the standard GDB remote protocol (I
>> know ours does -- NetBSD based).
>
> Keep in mind that adding remote-mips.o doesn't prevent the use of GDB's
> remote serial protocol. The "target remote" command will continue
> to work just as it always has.
>
> Also, I see the pattern "mips*-*-netbsd* | mips*-*-knetbsd*-gnu" in
> configure.tgt. So NetBSD wouldn't be affected by my change anyway.
Ok, that sounds good, thanks much.
paul
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2011-01-24 22:04 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-19 21:20 [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o Kevin Buettner
2011-01-19 21:39 ` Paul Koning
2011-01-19 21:50 ` Michael Snyder
2011-01-19 21:55 ` Kevin Buettner
2011-01-19 21:55 ` Michael Snyder
2011-01-20 0:55 ` Kevin Buettner
2011-01-20 5:58 ` Michael Snyder
2011-01-20 16:19 ` Ulrich Weigand
2011-01-21 1:14 ` Kevin Buettner
2011-01-21 12:44 ` Ulrich Weigand
2011-01-24 21:52 ` Kevin Buettner
2011-01-24 21:58 ` Joel Brobecker
2011-01-24 23:01 ` Kevin Buettner
2011-01-19 22:02 ` Paul Koning
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).