RE: [PATCH] [patch] gdbserver assert error on arm platform

["Yan, Zhiyong" <Zhiyong.Yan@windriver.com>]

Hi,
    Did this patch get a chance of review ?

Thanks!
Zhiyong



-----Original Message-----
From: zhiyong.yan@windriver.com <zhiyong.yan@windriver.com> 
Sent: Thursday, May 11, 2023 2:20 PM
To: gdb-patches@sourceware.org
Cc: tom@tromey.com; Yan, Zhiyong <Zhiyong.Yan@windriver.com>
Subject: [PATCH] [patch] gdbserver assert error on arm platform

From: Zhiyong Yan <zhiyong.yan@windriver.com>

Bugzilla 30387 has given the steps of producing this issue on arm platform.
Gdb should not assume pending threads always generate “a non-gdbserver trap event”, a “Signal 17” event could happen.
Now that resume_stopped_resumed_lwps() -> may_hw_step() assumes that the break point must already exist, resume_one_thread() should ensure the software breaking point is installed although the thread is pending.

LINK: https://sourceware.org/bugzilla/show_bug.cgi?id=30387

Signed-off-by: Zhiyong Yan zhiyong.yan@windriver.com
---
 gdbserver/linux-low.cc | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc index e6a39202a98..543daf66376 100644
--- a/gdbserver/linux-low.cc
+++ b/gdbserver/linux-low.cc
@@ -4670,8 +4670,16 @@ linux_process_target::resume_one_thread (thread_info *thread,
 
       proceed_one_lwp (thread, NULL);
     }
-  else
-    threads_debug_printf ("leaving LWP %ld stopped", lwpid_of (thread));
+  else{
+	threads_debug_printf ("leaving LWP %ld stopped", lwpid_of (thread));
+	if(thread->last_resume_kind == resume_step){
+	    /*
+	    * If resume_step is required by GDB, install single-step breakpoint.
+	    */
+	    if (supports_software_single_step())
+	       install_software_single_step_breakpoints (lwp);
+	}
+  }
 
   thread->last_status.set_ignore ();
   lwp->resume = NULL;
--
2.25.1