From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by sourceware.org (Postfix) with ESMTPS id 0089D3857BB2 for ; Fri, 15 Jul 2022 10:30:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0089D3857BB2 X-IronPort-AV: E=McAfee;i="6400,9594,10408"; a="349721583" X-IronPort-AV: E=Sophos;i="5.92,273,1650956400"; d="scan'208";a="349721583" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2022 03:30:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,273,1650956400"; d="scan'208";a="699160214" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 15 Jul 2022 03:30:45 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 15 Jul 2022 03:30:44 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 15 Jul 2022 03:30:44 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 15 Jul 2022 03:30:44 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 15 Jul 2022 03:30:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QuNo6BkQIUtJRVTVs9d3NqIqcJ37Gv9Jvfei6pl60dtZ547fZ8g5bIWKqZTEqTvV+UzTc9XFLkPuC750Ahk8h4/7DwleX6g3TQyjkNZyxzSgzQl5jkB3qdnCfhfHWt9gcqVq7cu92yrOc4XJpF9GMS/DhHMne9NYCY1oirau3d+KJzkOgYhH5CsHQNwv1SkZNURGm/yGj9F6dVzdrCEiqYeZRG6o+jDWCjGAwIjLN9Uh0lkC3Gww/Ogb2X5fBFOW/n8lvWf+jJFX2yZOFOQ2CSfS/R6WyAPUdFqmY5tmN9px18pDLBvCa8LXgjSCHJxa0FQuLoIdiwIG9X2YXARk3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NrActZ/DXRDvPtMMWbMu1KDb3GqmDOaw9zg55UL9MaM=; b=WWfny2eukt8jZQSw5qKwtaoHA9FIRpmi/WVVFwuXSmmjXWpFt4zFjAA8axTD0HjOsiueUbqndIvSOurlhqIG/wfbJA0y1YXJ/2jnrY2eEfHnCyZqBcTygzdojBebWhUQT1KmkIgl3Ig0L9KwiX1nZDRJE/fG1BSJ3QlSlR8icTzAKk5y6zz85uAUrXgp3hESdPwFyVIRC+APY9UNNpuz21gbZakVsLwar8oMyVr/LwXEBT6SC8tqlbqnbTSGtGrtNii4cgJLMiZ+z4ZEDfSM8aC88ri3LzxyQ/Lx2UG+cqrzuZBoExZkjoF/dViIz3oTNui5vir/E9B39bc8lA/FdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN0PR11MB5757.namprd11.prod.outlook.com (2603:10b6:408:165::23) by MW5PR11MB5907.namprd11.prod.outlook.com (2603:10b6:303:1a1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Fri, 15 Jul 2022 10:30:42 +0000 Received: from BN0PR11MB5757.namprd11.prod.outlook.com ([fe80::3d3f:98aa:2ea6:33f4]) by BN0PR11MB5757.namprd11.prod.outlook.com ([fe80::3d3f:98aa:2ea6:33f4%4]) with mapi id 15.20.5438.017; Fri, 15 Jul 2022 10:30:42 +0000 From: "Metzger, Markus T" To: "gdb-patches@sourceware.org" Subject: RE: [PATCH v5 00/15] basic linker namespace support Thread-Topic: [PATCH v5 00/15] basic linker namespace support Thread-Index: AQHYdo0WisrWAWeqJUyL3/kVJAKe/q1/UB3Q Date: Fri, 15 Jul 2022 10:30:42 +0000 Message-ID: References: <20220602132514.957983-1-markus.t.metzger@intel.com> In-Reply-To: <20220602132514.957983-1-markus.t.metzger@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ade21155-af9e-4fc0-ba02-08da664d11ca x-ms-traffictypediagnostic: MW5PR11MB5907:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: X5FAd4Eza+VmmvR3m1Ia3zpOL+WI7xma7jfNtDufa3SYwU+dmyeezn+F20oUoH1UpvvdbBCbk+ou6qgiezPIvPsFU/I7cDHj/RWH0MXLnMSRyC2p4Gnav4+BHimiqVG1wnUmTFH7ptlZyjgU3XlURm166k3srXFt1RgE+wQk7UPrBysNp2JoWMcNQagIHMX0WADM4WRejpJ+vl+asLTi97H45HXQ9MVN21UnkVFWbbPXHqWhmk2Rl49A4enpsMNeEg//KxTA1c9F5sAFh/cMvjFczJR9VRSMo2i0DQyQmAorWB/cuLvjRBbQrvEs0hKIu3WJAWPrB7tE4krC/HY1NkabK1bUh0K9knf4KzA1+pQDrYzgOqFTjZlha18lDTBZOuO4RY6FxrGKcyWe+AR5S2xfyWNm3pG1C+wT5heU2u+PZaPajv/5YzRmBOOhn8RcS61XW6grHO7P4waCu7GAEukE5/+KyQ3tLBcObWO1fa6qYMUFHJuwxP4b92vJo0qNr6EviwAkBHyA3oDiQk9elrRrM2QAstaJ3dvk+vw3KszV+0zlFV7gID+r0k6mvUH00eGTfSJppCjC8fDn3zSRgETY/wIOtFLO+tayOcAu4M1IBum9IWEcx/aLo9dxKDD5y8SlZn6idhMitr1ub0TTC0wSfEA3e0cgQGOPsG37gsLigOFqwpH33CB0wlEGr9SSaF5I0QRqlDAcZPuI3XOPN/NCvGO1j/W3Xcgzq/5+dAHMSOCZTxjid3iXDsCmst8KqVvF0ceFqEEGsJHdIdPaZuBHhGKNRS82AQADMWSQUd57k+bPhv3uKQx9+Gh4T9Q6KGoHOqMvygostCkRsOOflTE2TY9a6L2Pvfo9CFkbCR8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR11MB5757.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(376002)(366004)(136003)(346002)(396003)(8936002)(2906002)(82960400001)(7696005)(9686003)(26005)(6506007)(66476007)(76116006)(64756008)(8676002)(66556008)(66946007)(66446008)(4326008)(5660300002)(33656002)(38100700002)(38070700005)(122000001)(52536014)(86362001)(316002)(84970400001)(6916009)(71200400001)(41300700001)(478600001)(83380400001)(55016003)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q42TIvEyrgQu4RdNYHKH6CgQITjl8fLu5tJ80gcDj/pnxMJELZf8n/lhj4UM?= =?us-ascii?Q?R2M9+vEjrsjUQO41Kt/lc52u9bd1vyt6WuIqh1MSnkfHTnDZ6Kluq1qW2FR8?= =?us-ascii?Q?mZQ7wN75FdnS+bfQs2wJVxdRXZ0v7p9BY8DflEMONg5LCIqlhFM1rXXloIZU?= =?us-ascii?Q?V3MhkarlZmpg3wYpvtF4jwO/cE5jy5UPuJzlgCHmDJ98keYCnGfqb22otYR5?= =?us-ascii?Q?rjkdiKpjxGthDBvzb3JB5kWo3VwU/upHuU8oypwEFB8hzOrun/QuTmhafNUC?= =?us-ascii?Q?ICs/b2UbJAMI0akeAXRpWpoSo0Y/34piD7Z9XefBP3DJ50OWBaxYqOHzYiOy?= =?us-ascii?Q?oElRLca9wyZEu7FttRzE8cLdv4Ij1qX5zX2koKXTeSeJHrzxuW2wJpvUiF+W?= =?us-ascii?Q?pf8WNGXQlr+lPWDdnWiD+BmJuYACkMg/8XUWwXshd+CLHWIywpdEbNkPoKMv?= =?us-ascii?Q?Zj6icJz6X27xXpT1JxKEc+ulzHrI5qoxcXVwzHpWHggZyYZic0mChKdjJ2Y6?= =?us-ascii?Q?hG4YVtKSC9E2+MAd63DeXM+dEsO0V7XLi40nT8KGANGjFbFn7GgaC3W47o4B?= =?us-ascii?Q?IlYrCy1MusBbVfSIzvOz1+3NLJpLs4fI9lqN+/fvZm9FHWoqXDwvImRF2MeQ?= =?us-ascii?Q?WC9A+nbsDi3zKacoEKiah8+JLMNU77bstNwmzjFwHRcM1YJL2K58c02+IYM5?= =?us-ascii?Q?Hs9AamqXgCH811opKtcjZdshTVnFErAdinS+ypcMsQ5BBnf1IlYQVj5vevcp?= =?us-ascii?Q?DxoE3/wzVfG5UECJdRnCBqZZEnGfxHPINImGP9b3poQuYS+i5dexJvTI48h4?= =?us-ascii?Q?HSIgFbDlKOj3Ypg6H1zEJZq8Oe9P+TJOonbyKiC9j+WfCgnv1f2eZW5z9rGQ?= =?us-ascii?Q?TuqukuUVHxgtehUverqOD3QO+jtieg3soEMXl63mHkuesxGd+isFKVGV+hij?= =?us-ascii?Q?CQ+SajANoPiHo/jVhEzDH9CoZ0q5uS9x3iAM7W/eOSQKCvcso2ykj2HsW4z+?= =?us-ascii?Q?xkitgv8sI7PqB/cx3TyCCny6pRn8mig8e9ktaT3ShLo4F7X+Rps/MHs2757C?= =?us-ascii?Q?B37CuPqhzzfJpkNogxjmi9JC2clqmMrLgsMItzfR04q3FWKkYp7ShBELLfP/?= =?us-ascii?Q?pXPkd12e32aKH8gUd0Exb1SsFo/cxEJ3zJr9L1WuL3haN5IVGKlWV3E6InN/?= =?us-ascii?Q?4y/EqRC48ZNFIiPr2Kilm7SKxT2fv1Oa3BflkABYPbKkksQsW/RATvXQ99lz?= =?us-ascii?Q?1fl4sXPd7YvoTBAFwWZCe3i0Uw37c+f4uLODS/niDYTKTFz8uwgiz6Jd1J5W?= =?us-ascii?Q?9/AYwZ2D9cbH8swO/OXd0jxLXV6qgyFXCDOm4zoK/iMS9aUyFhIFs2SRfcvj?= =?us-ascii?Q?i5s3pZcgHPZuUPBioRUHGx4Yza9TaFmEahmnPCb/dfI3ZRGAqfPT6VCoXP27?= =?us-ascii?Q?o4DJrXZd1hXoQAVSC1BxNswBQuvwYwQOwMRccTkttRgi7N3psvedMVflIxav?= =?us-ascii?Q?JTi0eEprBX6j5HoSh6Q/CtTSvSwWkSAuD0UefE1GBRpAlmtnzvBD+5dgPwRj?= =?us-ascii?Q?EI4mfwMvKaNxNcYhaz1H1iQHs2HhKVXK3A8qzCWsGG1wzt86wCX/zMy+c/gH?= =?us-ascii?Q?7A=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5757.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ade21155-af9e-4fc0-ba02-08da664d11ca X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 10:30:42.3047 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kYsmyovLa/Ub6YI9ckoJeyJSWcWE/Tj/rrAWHnEbhTb7OUMnlwj+Df2kNsKLvNHOq3H0a3IdwUBK0hbjVVJbFhbOPbBbGlSuDIiAXYYPYZE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5907 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2022 10:30:51 -0000 Hello, Reviews have slowed down. Here's the current status: OK'ed by Kevin: > gdb, solib-svr4: remove locate_base() > gdb, gdbserver: support dlmopen() > gdbserver: move main_lm handling into caller > gdb, gdbserver: extend RSP to support namespaces > gdb, compile: unlink objfile stored in module > gdb, ada: update ada_lookup_simple_minsym > gdb, hppa: remove unused hppa_lookup_stub_minimal_symbol > gdb, symtab: inline find_quick_global_symbol_language > gdb, solib-svr4: support namespaces in DSO iteration Reviewed by Kevin but asking for another reviewer: > gdb, ada: update ada_add_all_symbols Not reviewed: > gdb, testsuite: extend gdb_test_multiple checks > gdb, python: use gdbarch_iterate_over_objfiles_in_search_order > gdb, ada: collect standard exceptions in all objfiles > gdb, cp: update add_symbol_overload_list_qualified > gdb: update gnu ifunc resolve Another question is what to do about those known issues: > - get_symbol_address() and get_msymbol_address() search objfiles for a > 'better' match. This was introduced by > > 4b610737f02 Handle copy relocations > > to handle copy relocations but it now causes a wrong address to be > read after symbol lookup actually found the correct symbol. This can > be seen, for example, with gdb.base/dlmopen.exp when compiled with > clang. > > - gnu ifuncs are only looked up in the initial namespace. > > - lookup_minimal_symbol() and lookup_minimal_symbol_text() directly > iterate over objfiles and are not aware of linker namespaces. Can they be accepted and addressed one-by-one? Or would they all need to be addressed before the series can be merged? I had to adjust two expec= ted outputs but otherwise, tests pass on x86-64. We know that namespace support is incomplete, though. For get_symbol_address() and get_msymbol_address() I believe we need to remove the objfiles iteration and trust that the symbol is the right one and just return its value. That means we need to find another way to handle copy relocations. I was hoping that someone could help with that. regards, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928