From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2043.outbound.protection.outlook.com [40.107.223.43]) by sourceware.org (Postfix) with ESMTPS id C34103969031 for ; Thu, 5 Aug 2021 16:38:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C34103969031 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nPrZKdGcIo3SpGJBwhzuXtUHpDhXca4BliNlJfrfpClba3AN2kZnfYO6+GD9rgt159tH64rmaeYwionZfXueUyWPlZn7SNcS17iqKgHwDnKeWAVW81LMIPDSIQWY6diHO5n34uL3Yu3+oeeGolbHP6RKLKwr+hwkMREGh7E4glvd+VbwpORQ53HLnh9497LerNLlRVPaAbeiqhJrviq97paiA12sFKvYFk1cDcwJu/g4kPfpwIhqJ1l1w9g+9P2fzMjGOzRPMJFWoFknkrMd2DddMNG7x2gTNI//AbGY737gV0xk/aedA0PltwGYt05YAmkiBO9s0YXJ9zD+eBXTYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hAb3O6TDKjspd/aEFMRaaa5sBx2fkzEB11BZ3lvHGck=; b=F431xo128hCAp6rECvkhBO9SqEsddukEpFgsv6kTO0qqQEZenglbbCmt0+67hr+BbSo18gLxai7iH38VJJESiqKQdR/4M+qtxZmAK6rByITxc4KB9RTk+SHwVXzvzDyYL18vXBf2AVFXyXPxARIJL14i8YtqHYGH+8U6EwK6qt17KBw4rCbOTzjPSYmwUEq8tEwmlk2Q74u2g7O3KzfsEJvP96OTk3gvShDKjDn9rjNB3sP3pZcXHN5UZBv6QNhIZ2syZZUi7+ZBqC1UL8dLRM0I0QPO+hfHML6Dn1AW26euWEjgRw32EMYIvf95RhKXi6Jd+WE6UTPc6gOAk+27SQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) by BN9PR12MB5209.namprd12.prod.outlook.com (2603:10b6:408:11a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17; Thu, 5 Aug 2021 16:38:07 +0000 Received: from BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::6c6b:ca91:7ef4:ce23]) by BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::6c6b:ca91:7ef4:ce23%9]) with mapi id 15.20.4373.027; Thu, 5 Aug 2021 16:38:07 +0000 From: "Zaric, Zoran (Zare)" To: Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH v3 00/17] DWARF expression evaluator design cleanup Thread-Topic: [PATCH v3 00/17] DWARF expression evaluator design cleanup Thread-Index: AQHXU9i4LVQr9j4/aEyaWl991JZI+6sK7xQAgFqZc+A= Date: Thu, 5 Aug 2021 16:38:07 +0000 Message-ID: References: <20210528154648.60881-1-zoran.zaric@amd.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=true; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2021-08-05T16:38:34Z; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only-AIP 2.0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ActionId=05989be3-90b8-4e95-8877-8729163ff920; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 49c14894-9112-4ccb-a33b-08d9582f67b4 x-ms-traffictypediagnostic: BN9PR12MB5209: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ClKANzk/LpQk7gm4rsqtxtxYlTYrHXJkyKdBW+jr17PwJm7pntXPlpdmrKtWUtpWqQasbJyLyJwpOhX0+8+Gm37jzUyVitP8kAC8PqAWKtEbiF0W0qEo77QSIFwTAdLPcpBanAbhhSQmSr6EiU3EZJ181Dq5iuF7rUf/iW8UgMFJXl2x7ZaGuAB9ucj2YWdGsGhNeGe1vd1d/4svF4HykPUJszGDqrDejYInBxZteVaI0by4NjJGs/ofvSJ5DdZHyRssY9zNdbIhhvEzSJ8f3zA38JRemPnFVacdQ0y/reIm79Pt712K2O9soNiVn7WdCrLzY8vgTseNeLifvSeZPSNsm5I6jIW3CeLNO7h709Fz+GNg8YDrbLcDYkFIkqlHMakaiL29AhtRXaOkQWXHFx08JZ2ZvaJvabqOB3/ht82QRrnydeKKna7gy2v+HurmiASy66qJd2gEYViiddZcr+7v1XrbQ7A1rmYP8FbSm6qL5NnFHwBh7Hx+JsgtxvbaRP8cVFIUuwcw63iV0XuSWhSokhNgLzmT5jxbIlSxgEUItY8/QWD3YSxWsgUoRy4pzPMD62rETRjTlrn0AaRiJFyXvQXZ2tYvbnG3Jj4WgqxZ+N1gCqnh8AwKBeKk6IsRmbV0uBR0wyw6IeYcd4dP6gi9+zzwmvKZ0FWsinlALdRiLY4CNIWA2UMAPrdm1kW3vxlBZmFAFtjPPyoCu15J3Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5065.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(366004)(39850400004)(136003)(52536014)(110136005)(26005)(316002)(86362001)(5660300002)(66476007)(7696005)(478600001)(38100700002)(66946007)(66556008)(64756008)(122000001)(66446008)(38070700005)(8676002)(2906002)(71200400001)(76116006)(558084003)(9686003)(186003)(55016002)(6506007)(33656002)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LfOWbD6MxlyGLtCSyIiRCGu6fWAPTT0GTqiblcgmF4H5D2rePf0Bdfv4aUNz?= =?us-ascii?Q?7T34lXMigJNzuXZCfEW0pOeUjbrnpBbU8/+nnZrxU7YjyDEDLXoKS9ZwSseP?= =?us-ascii?Q?CLzWKV5g+abE/GjcpF7iUY0IpVFEB68c3at+vpDfLJDKQxim9Wnh/cBCAS05?= =?us-ascii?Q?A+UgeZXZJ+DiyV6PKPtRfovxZNyQLDf90rKkR4b1+eGgy3Ch9LblXiSSirrM?= =?us-ascii?Q?ZrmLx/D2voAFjCVf0ljcilFdIovxb/uzoCg1dUblrKwiufnYxuXpG7VPl34E?= =?us-ascii?Q?EtCEa2T78wB/u2wBavS+PTGfBSKNK44JreGag9pQz3twJyDmfnxPqeBQLfB9?= =?us-ascii?Q?NPbVtkhXoEJMfhrVzumAWOQCSgBC39JAuS37UUFh4lWuzMuij7+k7wLMEbbx?= =?us-ascii?Q?zG8SqZFyZSVTwP3KAC36zSgVQRI2hDuKB4nVWZj2Eeo/l2jilLZZbp0XPXcA?= =?us-ascii?Q?gz5K5Og4KTSAi/3+zXcu8MdJ7IJDY4vqjWcQoAkDQMGjV/mJH+YIgrUXY78v?= =?us-ascii?Q?+5IYC4JlZe0KQIeQm6TCIH5DI4ztLzMIlk5HhvqhlsClA52N32bOP4dyFK7E?= =?us-ascii?Q?KAhj1cP9I6xoNas8nmw1mfvXBp+rhaw4ycrRcfeAon9woj2zpH0HExLrb3uP?= =?us-ascii?Q?Q1AKlZCuWTyClC8+gPj2E6HtHxB8ftgFcOtBQOqxdI8duVpvWWFfDTHD0KLu?= =?us-ascii?Q?2eOy0FDGjOYFvmIRONAA9ZgRiWyTEqZB1I9dp0nd8xJnXeT3VbrM5AvPzh9v?= =?us-ascii?Q?kgoSDZozEBviTFnpI7Aq0DVDUTe3qOP4VxORr2d5aPP7bl4WCuyO8Cj+5KnT?= =?us-ascii?Q?oeQwLdKtvzbaHz8QAieLe75SsrKdAn6Vl2RFyS6Lw+st7OJfhB4SPHjlyr5d?= =?us-ascii?Q?uV0t3NZ0dRYYlGnfwuoBSfk+qX12g2tggk/VPe09EL9davcPr4IKoL5ZI9aW?= =?us-ascii?Q?ZGbxBK+r9kMUcvfUZcIrir4P9jQir3V6M6C6EDBIOTrFOcIG2Eyd3LaSO2Cy?= =?us-ascii?Q?4dhQPl7QAEqRpgddncFgbM+6dugQDk5QRo8e/xdF5Xlc5GbbRneASJbK2mUA?= =?us-ascii?Q?89TGuR9w0eiSeX+kQ4+95HGPIKtV7kk/D/2xPg2C+PcNSbGSrAFwsvoR24J4?= =?us-ascii?Q?t3pZLH4WM2TRTA36DRJIk0+jJjijZvlVIuSF5MD+nPXdXrRbfzR9gdiRDx67?= =?us-ascii?Q?A+sAoBlL7J1feNJdBvOxOTvbIiEAztyIU0cvy7GCsH16A2LfxhtZ84DohoqO?= =?us-ascii?Q?/JBZgzkpuf/urMXrlx3jKJwp2kaotdoAYlzq1dndsio3N1PpR0GUHqlVaE3e?= =?us-ascii?Q?xUk=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5065.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49c14894-9112-4ccb-a33b-08d9582f67b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2021 16:38:07.5268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2Ol7Uf3UBc6Heure8zfozj39/JavVQJE7SbQFeTi2WrxHnU361rRgIvIAvGuDl93viiwQSmE/z3QSdasXAwBFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5209 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Aug 2021 16:38:14 -0000 [AMD Official Use Only] >=20 > Hi Zoran, >=20 > I sent some minor comments, just a few nits that need to be fixed or > questions answered, but otherwise this LGTM, it's ok to push once all the= se > are addressed. >=20 > Simon This patch set has been submitted just now. Thanks for all the reviews guys, Zoran