From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2085.outbound.protection.outlook.com [40.107.244.85]) by sourceware.org (Postfix) with ESMTPS id 46AFA3857BAA for ; Tue, 14 Jun 2022 07:23:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 46AFA3857BAA ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=doxBnNah70eCSo98rjqo3CzIGJFOGRkXzOvowBwe0vIZbkFiSL3nmSYliClujGfzJZQQqgMXG0Rg0EgcdyIIZSG/DssHMk7tKTBgvGS4BkiXUw8JtH+woxlzoN2wdRNVucKs0VbsxfuBppFMl6GBwj303ojXaMCScNs106p8MIFLiOeD0IksRimOQIYZAGqybeZNMuyshJ+vzMmQWXVPJw7Cn49UiKWwMpMGp5Vj3XdQFJENNrgSJ+9kJ0CN+jtcP674R2RaBE/ALRSBwylOglffbEzUfm7PozPI1h5/D0uh1RFGZFiROV7iLmKObHBVdSF0LMOWqgMjBfWSvY45Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u56R0BIZB+9FxkrR1YZ0VhuGZKjXsau/6DK9DPPESsg=; b=QpfCLxzT4BemNU04FezO2/9AADZFWZlcCRIn+iUdlyggUBYM7Z9d1+tsV8IboGgJcWa1lCOP21LjTjZpHFFgLwBpwJNXJddbPGuYbLlAJl7v+oBnIVqNvu9YXYbpQernCU2heCRy4G2dJF+R2UQUdUS8Qt/2z1dulNX7RnhKpAUFTqUUrtif9t2c/xsoqXBcG3ov7xMIHO2ZGGIvliwpT6S2RRomEpyvDEMs3hkzLSFK3qr96hFgYH5Cn7VSjUASeAMb2StvBuLVp7mbnTw3ol3Khe6Iue+bSl/6SS/UAZBAs8lhXgre61oPp2ni5v285Txvth9WaHufjKRPKNC2Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from BY5PR12MB4965.namprd12.prod.outlook.com (2603:10b6:a03:1c4::16) by DM5PR1201MB2488.namprd12.prod.outlook.com (2603:10b6:3:e1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.13; Tue, 14 Jun 2022 07:23:43 +0000 Received: from BY5PR12MB4965.namprd12.prod.outlook.com ([fe80::d4f3:dba1:2d07:4d90]) by BY5PR12MB4965.namprd12.prod.outlook.com ([fe80::d4f3:dba1:2d07:4d90%8]) with mapi id 15.20.5332.020; Tue, 14 Jun 2022 07:23:42 +0000 From: "George, Jini Susan" To: Andrew Burgess , Bruno Larsen , "gdb-patches@sourceware.org" CC: "Natarajan, Kavitha" Subject: RE: [PATCH v3 03/14] change gdb.base/symbol-alias to xfail with clang Thread-Topic: [PATCH v3 03/14] change gdb.base/symbol-alias to xfail with clang Thread-Index: AQHYcRMVRnj1GTD3tk6iLHHx7PAnuK1DeMkAgACAUYCABJeXgIAGCDlAgAADllA= Date: Tue, 14 Jun 2022 07:23:42 +0000 Message-ID: References: <20220607125346.14861-1-blarsen@redhat.com> <87a6akg4u4.fsf@redhat.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=3da7a91e-6155-4bb8-9886-1fbadb86d22a; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-06-14T07:10:59Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1b6234b4-9f0e-4309-ed2f-08da4dd6cfb4 x-ms-traffictypediagnostic: DM5PR1201MB2488:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G35S60J8NcKxDljxCqofL3NEMGzGuyLU3quCggbVT53R0qQrLB4L7jp2Dr5ytRvDQJ+YL5qt9UJySayHhWHp6aLlU0G8o4AAmQt8ntlTrqJx5E2D6alLK5mVH3rl2Bzs+l42s8FUsD4kUXutD+96ARftEZr3YEqatiHmAN94PxfheFdrrJOEs/PTy2dReIn5RHuwqz84oRiKk7L0eDkzAP1qzIpqhO6+ggnlGC+OYOaiLf+3+q2ykluAq9JACXc+ROCfqT6K4P9usuRC26O2yBao0i01Qdq+5wxyCJp+SKnY1WlWM7UKk3BkhmuXiDgB9CB0+3btOn3OvdSB0FH+0HUD4Pa0FnUk49lRRpYOvYyh4k7G5k+iCsq3dv7BEh2lPxlSRhDTCyU/hT/k290xvMJkCwdhcz49erfwwnpeKXMdAs0aNn0TEaosl/yoNCuxQIUNYyWRXNUkyKA5oavv5foMDB2//d3Iy9JX1Z+UbBavypV6q96fpnbb8SZSkncyfFUCPCY+WQV0QID1vSjXwSch2knxd7fvAGi3UtD92KztQDqLLp626bzOTSLj0VmE4nAwaal3++piMlntZsEtbwV3tXuVMz+tcMIwIYZbVodhDMf0y6GUN4BfyM7W+AfW+jPkGiQKogpqHuRJrz3G6c6ufhnHtoEyqcJjNmsK6NjB5nb2lwTM7mXP3ADwaXljpBq4sSJuuCNQCEzcIJt7q8oku1aq+MIxLlkXbhJu8YzKzwEAmIWajWprD4rdqZ9CVZk478LH1R6/BOwZrtzBHvHlATiZlrcvx+JeDfRvXkcHHFgxFaj3ScH1rv1DChbC x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB4965.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(4326008)(64756008)(66476007)(8676002)(66446008)(84970400001)(76116006)(66946007)(8936002)(5660300002)(66556008)(122000001)(86362001)(45080400002)(508600001)(38070700005)(71200400001)(186003)(52536014)(316002)(38100700002)(33656002)(26005)(9686003)(83380400001)(2940100002)(55016003)(110136005)(2906002)(6506007)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TSTEE43wYvjbY7p+Lq0n/10Ur+NQ1jrYr6G2ilI5lCEbSJcxY5hanSalKzME?= =?us-ascii?Q?IznWZ6zRK/7w5O/JCQdS3ctN5o2Wo/jY7op6SCPxwD7KuiUNTu0Xg+xStpn1?= =?us-ascii?Q?C0MxnJsjD/xQSpx1wVfIOXJJ5HK97hWtut1GrvTdu/cGAqKHAX/zptkjypL2?= =?us-ascii?Q?TNDJWAGHdC4adWBB9gW32g/dOK81dwyEpjX/myHzmCHTSfhSnxhbv4kKQ0qH?= =?us-ascii?Q?C6zPv+23v2o5eNEGRQ8o2SOt/T+dV7W+FSMaSVJdIJqM3geXsbCwqm6ekX7u?= =?us-ascii?Q?Q6HHbrsdqdw6eA/rUZLRoROPAF+hVGOLvn7Shu5Dw069vN3KMvae0vZW99i8?= =?us-ascii?Q?ItLF79wAS3r86uevceeXar0JZ7zJZs/48Y3XroSNIYlDqnUH2olW4vLJpQb9?= =?us-ascii?Q?/8zX1IyMGcZZy0cBLwg/IqkzKTXyhO8vTTJOz5s+oI9u5VTbDq+7XDnOiEkk?= =?us-ascii?Q?Hlarg55KNVXORTVW0SBuAsmWNqD/HxX/oEqHnXsUrHfnOuT5N1kFNEMczBf8?= =?us-ascii?Q?AbR3wI1b+DNNF0z92ORtSAWV9CEJrMqPoKn9E4amYrGBGTsmn1qLFzGM3vk1?= =?us-ascii?Q?MXYh2H0OCfVgUrvh95JEugL8PKTEJHTLCDLtEBjGs+cDKxSyCBn4yT5i/VS2?= =?us-ascii?Q?rhwQDBMoufpUb/qPYt3m8dza3QEanjm8OkE5UHMGz+KxT16xAEeoyeGiDuKH?= =?us-ascii?Q?yeQmDCA47CiKXVr56pnDqBlYkaQkDp1F6CG40IazIWTiLNTNhzQTJ0sVhhUO?= =?us-ascii?Q?GRLFRZ469WY1N8OEAOcBgPCVKDNeGXVIM02hHPBWYjJxYeG/8Zjl8CG2jl4K?= =?us-ascii?Q?F/GmDXdPPaVERILaMRDKKM6ZG5pc5l0vTvMNvtbct2V+Ksa1/GPj7DG2GPNT?= =?us-ascii?Q?f41tZqKxAkete+GFprATlOlWPqU1CCyKfhkXHQ/o0StSdOx7N3fENQc18nt4?= =?us-ascii?Q?8ELzTAeVvvGpwuhLA63eEd9FB/iJPkx594IJuq4ghs7Lqa7SY0TiWv6nWiyO?= =?us-ascii?Q?hht6pnm44xrkunAzlZGTQvV/PgYa2yxKFz6iirb9qD7FyX5BvS6eF3BCJ1h8?= =?us-ascii?Q?Wc6/5j4iui/mpRh5jRxGk1lxeDhVVhhDs3kdq4imz47+Aty4BBnkVnI9GLr+?= =?us-ascii?Q?A6nOhSE2wIDvMzhIxplr+MACbiWt3iV6j9FGVQXTJ4o102uDMeck2PjPbzgQ?= =?us-ascii?Q?T8cKkrpMobvYgdN30PdEMPhA3JuMf0DCBAHZVWX39WfYCnqttrnWUiDScUep?= =?us-ascii?Q?fUPfDxrg4SV1a/Dg9NyG7yaeGPCTtUcbuslWYVvHe2/e2u5DCerRcSBwFi+X?= =?us-ascii?Q?6sLFxR59PPYQIPBAakhzdc72wktyHSUl4hEo72IvrkQhrsQE8k8MB8HCE+xt?= =?us-ascii?Q?Rr/h5e3JSFdob2EM5ndpmUdEXmN8fhAkhSkDbqmko6cCSgQSM1PLZf8dQ2Xb?= =?us-ascii?Q?gF07d4Df8pQgP64fA5/w9R4ngL0pIUfX1dEbioSGn8VsYyYib/Rzpoa+Rupj?= =?us-ascii?Q?zYRDkd3VdO5nmR1t56iZxJLCk/gFOGqEmBFGlJhK+oeI53z8nQwfdLPwp9dX?= =?us-ascii?Q?0E0CqzXJMsRNfRh6F6SVWo4m4SUWpCX1hRCFatiVHN8V/t/4hXrzsCG5YQtM?= =?us-ascii?Q?pLTeqMBon6iCWH5XHnhsVD38228I4p9TvCsTs77LJneAP9pa2KaU6rSYz2aU?= =?us-ascii?Q?d7ilXBt9G0MlMtP6gKo88j8jkIZR4waD7qM9+ki9KM4/4qMXlR71UmzKJv+9?= =?us-ascii?Q?7r0CXMI39g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4965.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b6234b4-9f0e-4309-ed2f-08da4dd6cfb4 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2022 07:23:42.8802 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ajgV3T2xAUy0ykg8sUpGZDWPFvbrXafHh1N13sY+dupqMS5RU48LgF0AL8ygSNFZigS3E8KqJ21ySajj4jvi0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB2488 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2022 07:23:49 -0000 [Public] I missed mentioning that Kavitha's patch takes care of making symbol-alias.= exp xfail for clang versions less than 15. Thanks, Jini. >>-----Original Message----- >>From: Gdb-patches >bounces+jigeorge=3Damd.com@sourceware.org> On Behalf Of George, Jini Susa= n >>via Gdb-patches >>Sent: Tuesday, June 14, 2022 12:44 PM >>To: Andrew Burgess ; Bruno Larsen >>; gdb-patches@sourceware.org >>Cc: Natarajan, Kavitha >>Subject: RE: [PATCH v3 03/14] change gdb.base/symbol-alias to xfail with = clang >> >>[Public] >> >>[CAUTION: External Email] >> >>[Public] >> >>Now that Kavitha's patch just got committed (details below), guess we mig= ht not >>require this. >> >>commit 6df97c56ea0f3086c96743ec47148ee69fd8cf71 (HEAD -> master, >>origin/master, origin/HEAD) >>Author: Kavitha Natarajan >>Date: Tue Jun 14 10:37:46 2022 +0530 >> >> Debug support for global alias variable >> >> Starting with (future) Clang 15 (since >> >>https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Frevie= ws. >>llvm.org%2FD120989&data=3D05%7C01%7CJiniSusan.George%40amd.com% >>7Ce7ea873468214efcf9d908da4dd648a2%7C3dd8961fe4884e608e11a82d994e >>183d%7C0%7C0%7C637907879987330246%7CUnknown%7CTWFpbGZsb3d8eyJ >>WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C >>3000%7C%7C%7C&sdata=3DbNOSusnr0cUBWttQ1PM8JrnijdjPJl2ee7lBpPsStY >>A%3D&reserved=3D0), Clang emits the DWARF information >> of global alias variables as DW_TAG_imported_declaration. However, >> GDB does not handle it. It incorrectly always reads this tag as >> C++/Fortran imported declaration (type alias, namespace alias and >> Fortran module). This commit adds support to handle this tag as an >> alias variable. >> >> This change fixes the failures in the gdb.base/symbol-alias.exp >> testcase with current git Clang. This testcase is also updated to >> test nested (recursive) aliases. >> >>Thanks, >>Jini. >> >>>>-----Original Message----- >>>>From: Gdb-patches >>>bounces+jigeorge=3Damd.com@sourceware.org> On Behalf Of Andrew Burgess >>>>via Gdb-patches >>>>Sent: Friday, June 10, 2022 4:31 PM >>>>To: Bruno Larsen ; gdb-patches@sourceware.org >>>>Subject: RE: [PATCH v3 03/14] change gdb.base/symbol-alias to xfail >>>>with clang >>>> >>>>[CAUTION: External Email] >>>> >>>>Bruno Larsen via Gdb-patches writes: >>>> >>>>> Hi Jini, >>>>> >>>>> Great to hear that Kavitha's changes have landed on clang! I do >>>>> think that it is still important to have xfails, however, since only >>>>> new clangs would add the information, and GDB is tested in all >>>>> manner of systems. >>>>> >>>>> I have changed the patch to assume that clang 15 has Kavitha's >>>>> patches, and changed the clang compiler test. Does this look accepta= ble? >>>>> >>>>> [PATCH v4 03/14] gdb/testsuite: Change gdb.base/symbol-alias to >>>>> xfail with old clang >>>>> >>>>> Clang didn't use to add alias information, even when using -gfull. >>>>> This commit checks if the clang version being used is already >>>>> providing alias information (15 or newer), otherwise it adds an XFAIL= . >>>> >>>>My understanding from Jini's email was that for this test to pass we >>>>would also need this gdb patch: >>>> >>>> >>>>https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fsou= r >>>>ce >>>>ware.org%2Fpipermail%2Fgdb-patches%2F2022- >>>>April%2F188354.html&data=3D05%7C01%7CJiniSusan.George%40amd.com >>% >>>>7Ca2aaecea2df0476d781808da4ad0988b%7C3dd8961fe4884e608e11a82d99 >>4e >>>>183d%7C0%7C0%7C637904557029019597%7CUnknown%7CTWFpbGZsb3d8e >>yJ >>>>WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D% >>7C >>>>3000%7C%7C%7C&sdata=3D8%2FUKHMbpyAKXN4HOPHRJ2vP62yKK5i5Qe >>au >>>>v0GQtWHo%3D&reserved=3D0 >>>> >>>>So, if I had clang 15 right now, this test would still fail, right? >>>> >>>>I guess you either need to hold this patch back until the above is >>>>merged, or put this in with a generic "all clang" pattern (like you >>>>originally had) and then assume someone will spot the KPASS and fix up = the >>test later. >>>> >>>>Also... >>>> >>>> >>>>> --- >>>>> gdb/testsuite/gdb.base/symbol-alias.exp | 9 +++++++-- >>>>> 1 file changed, 7 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/gdb/testsuite/gdb.base/symbol-alias.exp >>>>> b/gdb/testsuite/gdb.base/symbol-alias.exp >>>>> index 289f49bbc3f..078158dc101 100644 >>>>> --- a/gdb/testsuite/gdb.base/symbol-alias.exp >>>>> +++ b/gdb/testsuite/gdb.base/symbol-alias.exp >>>>> @@ -31,6 +31,11 @@ foreach f {"func" "func_alias"} { } >>>>> >>>>> # Variables. >>>>> -foreach v {"g_var_s" "g_var_s_alias"} { >>>>> - gdb_test "p $v" "=3D {field1 =3D 1, field2 =3D 2}" >>>>> +gdb_test "p g_var_s" "=3D {field1 =3D 1, field2 =3D 2}" >>>>> + >>>>> +# Clang didn't include alias information until version 15. >>>>> +if {[test_compiler_info {clang-[1-9]*}] >>>>> + || [test_compiler_info {clang-1[0-4]*}]} { >>>> >>>>Wouldn't clang-15 match the first of these patterns? >>>> >>>>Thannks, >>>>Andrew >>>> >>>> >>>>> + setup_xfail "clang/52664" *-*-* >>>>> } >>>>> +gdb_test "p g_var_s_alias" "=3D {field1 =3D 1, field2 =3D 2}" >>>>> -- >>>>> 2.31.1