From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2077.outbound.protection.outlook.com [40.107.93.77]) by sourceware.org (Postfix) with ESMTPS id 01DDE383E69D for ; Tue, 14 Jun 2022 07:14:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 01DDE383E69D ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fJ0gB0NWj0Wr1rdl9CgSluU4/XIRNIP5fQYmDnzCnLeqrRIC65e3AMZefg+Yk0OA5ZLv4Zj7PQfMFd/RaB8XectLvIH4fBNIYv12vwnW0Lczo1hGIh0I5XgEen7Lv67m4TaSRywJrfG5Bfk5/Tk0NduKGREQrxbC8MTPvEfS16cK3YE+aecQNV7cWssh0/UD8SaozjJWrmjhmHjUS/4EBcYkNEhiXmHUaqf4lX/3iHCTtpIFtSsSGBo0icGISCVK5/iufSR8a7V8cW/oqxdNZ2tOHjTbkzgHst5EnB49LUQXTqypGxfzAnT0HCLuA5cRfFVQoDYcPNisz7GRjEY+mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IO1meaHAAKMONpFmD8THtt7Vj+auzAB2jl1ns2CO4is=; b=c0IrUI+2qP9amlEE7QJIN2VabaI3UNFhTW7OpOVkJyDkMdgsVyPb4ni4Nu0E7UJbAsFIwARCK3EnDYsgNM7NklKcKlRMeW8vwF5YkriFyrtCQM+JFuIfLfOuAv9eG0dYpIkr7SiyqEzjhRl3ag/fdw25j7ttoqI7+HlGwRXt1hMIvpXWFxziOIkrs7/Ft0gv3S8e5SUj0Py6222swyoJzJ/OiqEILWSIDKc/+N/b3t6FeFezh7X5p3IfUmUEIH4Xft3Wb/VxN8kjgSG65NhPMxoyjT3ibmoSuclUlquZQg2iLHflbjIU9zS/wrgWA4UpVlvZaDfQmQcnt8D4WaoYvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from BY5PR12MB4965.namprd12.prod.outlook.com (2603:10b6:a03:1c4::16) by CY4PR12MB1765.namprd12.prod.outlook.com (2603:10b6:903:120::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.20; Tue, 14 Jun 2022 07:14:07 +0000 Received: from BY5PR12MB4965.namprd12.prod.outlook.com ([fe80::d4f3:dba1:2d07:4d90]) by BY5PR12MB4965.namprd12.prod.outlook.com ([fe80::d4f3:dba1:2d07:4d90%8]) with mapi id 15.20.5332.020; Tue, 14 Jun 2022 07:14:07 +0000 From: "George, Jini Susan" To: Andrew Burgess , Bruno Larsen , "gdb-patches@sourceware.org" CC: "Natarajan, Kavitha" Subject: RE: [PATCH v3 03/14] change gdb.base/symbol-alias to xfail with clang Thread-Topic: [PATCH v3 03/14] change gdb.base/symbol-alias to xfail with clang Thread-Index: AQHYcRMVRnj1GTD3tk6iLHHx7PAnuK1DeMkAgACAUYCABJeXgIAGCDlA Date: Tue, 14 Jun 2022 07:14:07 +0000 Message-ID: References: <20220607125346.14861-1-blarsen@redhat.com> <87a6akg4u4.fsf@redhat.com> In-Reply-To: <87a6akg4u4.fsf@redhat.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=3da7a91e-6155-4bb8-9886-1fbadb86d22a; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-06-14T07:10:59Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 823525fa-b50f-409b-7e40-08da4dd57891 x-ms-traffictypediagnostic: CY4PR12MB1765:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iLxDG2tHdrMJSb5JdvjxKerBCjQ7lvDeK9lWpE2wrJxRdHRlcq88AbV7P9fnCzF2EO+MHEEwYyJoX2VZGdwdvsMiJLTBzNrMP7/9pnyXeYKWlLp2/eCDuqAf9MUUf9Oc2jyCf4kHnEJL9qP0uWE7k6RzxswSo+F5IlxuIZJGs4+t2y1O9320B2EueLPdNK/DctNSlJ4wakLL8UyTNWaL9r3tsNFZj+s6ly1HU323ueNgfRRFwN2urMPTshuaMuz9fJ70NRGCDm6yX2tLhR8Z8E21UllzQfwSneroevpG/nqr17JBUlQOrByW3AEa2MZFZkxhX87ZwMKRS+F2EI4Y/GZHDmFqLcD7JBip5cXp6X/u01jtQOForoS4irkObmmBqorLBts5PEDH/h7FM9ifG//U5VII8wbyof0kWy1AL5MgxzLM6CLnkcfDmE/rKaalIKHlBzA6upR4eMF2fW9iZnlHNfn1S/ielQyRoz2kJRvYuxyUqKkLeEs4IuIBwF0NlQvmKB2r7og5CC/wAtF3/ve6q95D5e1oJZqNCXgX//5GltNuQTW28P5vQl1efZnqAYLFZ4h7pKXFcK+iK/cf/cMiIXrv3jzB4Ke5aPtD0sNvRRCPsKDXitEqGw4AavtEqdyDMzkoneMkxA8HQYXCQmocWRsDNUeZK1hj7P/Rr4jHA/sP/zxlkMqreKet0xiZ8EteaAbgtpy4OZ9vIHRM+2PJADyw0zq4Hbk3lqDolyglJSkmSH02zwIfxWCVl4Dc+nhEsvEbpICeqJOUs0c4JjRYY1qxGDe9lqJlKZqMsSLb+Or/9wP0X5sjhNgyUgYaBC9ie13wXvM581OC2sHypw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB4965.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(2906002)(33656002)(71200400001)(5660300002)(9686003)(7696005)(6506007)(52536014)(45080400002)(86362001)(966005)(122000001)(508600001)(8936002)(26005)(38070700005)(84970400001)(110136005)(4326008)(83380400001)(316002)(55016003)(38100700002)(186003)(66946007)(66476007)(64756008)(66556008)(8676002)(66446008)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Y/IM/oPJhjkXljwc0XsanwCOCLdhE51tD/osrZtTJ2s0tNlAe3ThofXgYKz+?= =?us-ascii?Q?VX/ciwemkqCchv9Cjx1+PXxHD1BZk6606toZxK1LNNJCpYgQjAF+NJ96TWlZ?= =?us-ascii?Q?Ya1BokjAGfEMAquw+La/5odviT9ML8nG95mD0egSwPYTlJXXWqZmpmJ6VHYy?= =?us-ascii?Q?BpdADyLZqD7XMZVi8LzLe/Lh4lrmO3qfhFcIVjVGmqUSxj5xBjGFndp5+RqN?= =?us-ascii?Q?YcaGiGCQzMENfRXcAHbRQF70O39hNURAMv61ZPmX9VgOpOmuJb6wkW13oU5y?= =?us-ascii?Q?o/BhPjSeWtWWOeRXntfxTaUU85OPCiQthdXkOfe1aXB835s/yP1zHHWE+wGk?= =?us-ascii?Q?1rNflPVG3eDGmhc4Nb4dLk+TCWeVFPe+DfZlwfQA9BVWit7RPuIJTMHvhXbS?= =?us-ascii?Q?aGFecn73O8O8vHJtFnn6HjKTg1biRA8MNGlWgzu2FBxrtXRZkp/mmEdmuvii?= =?us-ascii?Q?L0qeZWSj0idgjZFhzY1+5lbRNwIlmYz4wXeK9YDDcSZd66GastV1Fjm8iW7t?= =?us-ascii?Q?kSgFKopqWHrt7DuXrx/OeGFtjlURSH4I9WS2U3dSluuFHb6OIiTttvIZNmTE?= =?us-ascii?Q?Qcwml4+6DW0frXhC1jhclbwSJkKeGYi8sx/t2yRDd+6ywdXgNZf4DkCFwAig?= =?us-ascii?Q?6386XHkBz8tF8N1fcEiWLJIIE8GwvnMW3nd2SPk7ozWzm2PAQs0FGTs9zLxz?= =?us-ascii?Q?tPbJX3GW4Zk0Ys2iBTJuuyHlkDQURLQ6KgFSZlHs6ZXq1otg81PIpeFx7Xh5?= =?us-ascii?Q?pgN5hjb7wECyugUuz1w/1qmYIRGvmc1FkkV9Ojpeg3htIXK+1wpgokWdf+7T?= =?us-ascii?Q?CTWDHL40W1AnlOu2URcHHtwWOV+jK3tOvflivQkvCV4X4WJxSJlS8fKNAe8q?= =?us-ascii?Q?EvclagqJnvGsmpbADhAAL9AXb1xj7ocmeACDiqXWULGPQwaziidHUwt5ZDTO?= =?us-ascii?Q?n8DmB+TjwYfcLtNUSVs8mCGHkobe22uwFxK+RRkJ84Ub/R/kSXXjsSQ8XRwf?= =?us-ascii?Q?V7lf5Pu2Y/Hc6QGeoBUu0tp85srj2GDWRDdSmR39G1oyf6AYEfs3lvefizWU?= =?us-ascii?Q?yvk6d4NrzUVAqVC8JsVZlHEXYgFjFm3dmdMC77siCxDPuEZIfLCOjVsQgtQd?= =?us-ascii?Q?5MPdOvfQRPXrVRa6FIziiDXov2i7oCIDdgYZBrX+/SDH8FOGjXTU9eM/twql?= =?us-ascii?Q?2+GcKsiMFxj0PGamDD6JrW90JfVd8WVSljtnf1QaeZ2mU8pi11RZoaMpkI9B?= =?us-ascii?Q?fCHaKCmxJBqQoHT45Odu4eL7L4Z8ZCRfYYoZuIsSohn3CAYtCTLKZu1AABOX?= =?us-ascii?Q?LgWsO4bADTzqXrYd4hZnhMQKXej5KhCchwTMmOYu6z6MRRpQ2SmBmCrdQrB/?= =?us-ascii?Q?3KK3LYFYMCAtCSGr5DAUhltDucZ6paNWocvv3aIXMwKPADAynxVKQC1q23Wu?= =?us-ascii?Q?PQNyNU6QrMKc/8y8T++6sbO0yDGdyVeGBU075lafiuGuuzKtCotesNFaT6IE?= =?us-ascii?Q?t/CpcYSNMO0eGnIYJauZcXs8DgiXM0jqYyLw9eni3n24TpHMr1KCD50iTlpH?= =?us-ascii?Q?A1oKRTr/55uvMKqJD1jVXOdCzh5xD5Ck6RCLt/4A6OnFYqyiL7xk7rSI2uwT?= =?us-ascii?Q?fbSs7YWwcA5AbimgkDPxAtYBwKkhYAdSrrLKTqNs/bC0NUOunQeY4zUCmmcY?= =?us-ascii?Q?uOvKGY756GepHODNIdslHjg+7jch5qCyrUhkIL+eWCmSbyzAkLAEwM45FN9o?= =?us-ascii?Q?wrAFWcH4vw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4965.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 823525fa-b50f-409b-7e40-08da4dd57891 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2022 07:14:07.2207 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gOb6U2mhJoy5YBaI0FoRqSHPPePLe6EmPYFkjqekxOSgnrNKR0IT1ZKdvgbDhC5r48LvAZBDnzbou8BwVecyug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1765 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2022 07:14:12 -0000 [Public] Now that Kavitha's patch just got committed (details below), guess we might= not require this. commit 6df97c56ea0f3086c96743ec47148ee69fd8cf71 (HEAD -> master, origin/mas= ter, origin/HEAD) Author: Kavitha Natarajan Date: Tue Jun 14 10:37:46 2022 +0530 Debug support for global alias variable Starting with (future) Clang 15 (since https://reviews.llvm.org/D120989), Clang emits the DWARF information of global alias variables as DW_TAG_imported_declaration. However, GDB does not handle it. It incorrectly always reads this tag as C++/Fortran imported declaration (type alias, namespace alias and Fortran module). This commit adds support to handle this tag as an alias variable. This change fixes the failures in the gdb.base/symbol-alias.exp testcase with current git Clang. This testcase is also updated to test nested (recursive) aliases. Thanks, Jini. >>-----Original Message----- >>From: Gdb-patches >bounces+jigeorge=3Damd.com@sourceware.org> On Behalf Of Andrew Burgess >>via Gdb-patches >>Sent: Friday, June 10, 2022 4:31 PM >>To: Bruno Larsen ; gdb-patches@sourceware.org >>Subject: RE: [PATCH v3 03/14] change gdb.base/symbol-alias to xfail with = clang >> >>[CAUTION: External Email] >> >>Bruno Larsen via Gdb-patches writes: >> >>> Hi Jini, >>> >>> Great to hear that Kavitha's changes have landed on clang! I do think >>> that it is still important to have xfails, however, since only new >>> clangs would add the information, and GDB is tested in all manner of >>> systems. >>> >>> I have changed the patch to assume that clang 15 has Kavitha's >>> patches, and changed the clang compiler test. Does this look acceptabl= e? >>> >>> [PATCH v4 03/14] gdb/testsuite: Change gdb.base/symbol-alias to xfail >>> with old clang >>> >>> Clang didn't use to add alias information, even when using -gfull. >>> This commit checks if the clang version being used is already >>> providing alias information (15 or newer), otherwise it adds an XFAIL. >> >>My understanding from Jini's email was that for this test to pass we woul= d also >>need this gdb patch: >> >> >>https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fsourc= e >>ware.org%2Fpipermail%2Fgdb-patches%2F2022- >>April%2F188354.html&data=3D05%7C01%7CJiniSusan.George%40amd.com% >>7Ca2aaecea2df0476d781808da4ad0988b%7C3dd8961fe4884e608e11a82d994e >>183d%7C0%7C0%7C637904557029019597%7CUnknown%7CTWFpbGZsb3d8eyJ >>WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C >>3000%7C%7C%7C&sdata=3D8%2FUKHMbpyAKXN4HOPHRJ2vP62yKK5i5Qeau >>v0GQtWHo%3D&reserved=3D0 >> >>So, if I had clang 15 right now, this test would still fail, right? >> >>I guess you either need to hold this patch back until the above is merged= , or put >>this in with a generic "all clang" pattern (like you originally had) and = then assume >>someone will spot the KPASS and fix up the test later. >> >>Also... >> >> >>> --- >>> gdb/testsuite/gdb.base/symbol-alias.exp | 9 +++++++-- >>> 1 file changed, 7 insertions(+), 2 deletions(-) >>> >>> diff --git a/gdb/testsuite/gdb.base/symbol-alias.exp >>> b/gdb/testsuite/gdb.base/symbol-alias.exp >>> index 289f49bbc3f..078158dc101 100644 >>> --- a/gdb/testsuite/gdb.base/symbol-alias.exp >>> +++ b/gdb/testsuite/gdb.base/symbol-alias.exp >>> @@ -31,6 +31,11 @@ foreach f {"func" "func_alias"} { } >>> >>> # Variables. >>> -foreach v {"g_var_s" "g_var_s_alias"} { >>> - gdb_test "p $v" "=3D {field1 =3D 1, field2 =3D 2}" >>> +gdb_test "p g_var_s" "=3D {field1 =3D 1, field2 =3D 2}" >>> + >>> +# Clang didn't include alias information until version 15. >>> +if {[test_compiler_info {clang-[1-9]*}] >>> + || [test_compiler_info {clang-1[0-4]*}]} { >> >>Wouldn't clang-15 match the first of these patterns? >> >>Thannks, >>Andrew >> >> >>> + setup_xfail "clang/52664" *-*-* >>> } >>> +gdb_test "p g_var_s_alias" "=3D {field1 =3D 1, field2 =3D 2}" >>> -- >>> 2.31.1