From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48]) by sourceware.org (Postfix) with ESMTPS id 167D7385829C for ; Thu, 30 Jun 2022 07:09:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 167D7385829C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=akvKvoUT8PdeMGXHBIW3iOPlwTabvC8C8Hlb7kRV/wIrnVu+83jUBXl52P0tnuJ3GQ0z6PTvWt0JCmS4wU0ymTLi3zGrk2SC8ECepSnkyky/1SRDye00L28LhuRYizRBKP99HAWJq1q1WazKvVL/NYVruhi8S6cNxXtOE2zKPRbWYf/J04ZWQzlLEAlOvLWbrZTGwGOHRyMO2SHfjsqVlBxLIPYJAQHU1X5mgXCyQ5UYXLBY2jrf7iaWRtHcxHYh+mOOnwK1+6PVHihG9W5w9XqIpPoNXiKvcXp20Yx3WPP6kqu4gYFOPZ8VC+2j4LNI6OOGIXXbr1klGggLyyBQOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=03bLCf7oKlJJTMk8/WufTpaUoLGwjw5tNc2aoEgsQbk=; b=Mkf6SXn/XzyftOkEZn3E3lzYuasZtmmfBf9wotvA4tQrDnzYrOfWElwRBBEKXcl4dV1bU7fEvicT5UsLJdI+5lfal9S594NIBIYIh+gBrrUvSvhq/Ur28y66InBLf1SZVc11Q3yqrysuT5+AnCJHc2hJ2YUBWQZLAgkZlsk5UufaQtKP1eQrAWf2CYCXb5nPtO90fv7qMoEVroCQXVdRT7fTsZfnCAlaKVVOFuVv8djyhlHwT9lfDf0cH8OmH2CnBbE6dixQElvvA8SNttJWbThdsBGvwT6bAA2g6b/qavIoHSoKvUBXrsNa0vZgjMxC6y7qLnZ84KbE2fyaPbF2ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from BY5PR12MB4965.namprd12.prod.outlook.com (2603:10b6:a03:1c4::16) by MW3PR12MB4345.namprd12.prod.outlook.com (2603:10b6:303:59::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Thu, 30 Jun 2022 07:09:45 +0000 Received: from BY5PR12MB4965.namprd12.prod.outlook.com ([fe80::d4f3:dba1:2d07:4d90]) by BY5PR12MB4965.namprd12.prod.outlook.com ([fe80::d4f3:dba1:2d07:4d90%7]) with mapi id 15.20.5373.018; Thu, 30 Jun 2022 07:09:45 +0000 From: "George, Jini Susan" To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" Subject: RE: [Ping v2] [PATCH 1/1] gdb, testsuite: Adapt gdb.base/callfuncs.exp for new clang warnings. Thread-Topic: [Ping v2] [PATCH 1/1] gdb, testsuite: Adapt gdb.base/callfuncs.exp for new clang warnings. Thread-Index: AdiLiJM2g84pQQ04T5mpRF1woIDezgAx4gsg Date: Thu, 30 Jun 2022 07:09:45 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=4f00faab-ef14-4a5b-aa11-e19346f5f717; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-06-30T07:09:20Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 232d122e-adf9-4d9d-723d-08da5a67830d x-ms-traffictypediagnostic: MW3PR12MB4345:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KMY8NJNrSkTg/FkQaGfpVP+L8DHcAZGaNQ4GYftSXO2YogDp7QbH29pkkYNzAxAXeFQ68u1f0e34VSX4SV8/UdNLpYTNKJJv+inqdywY0bEWkeSdbD8eLmN6JzpOm5kZVnFMA0uFYXAKNncO1W7U+p/UYrNRNDl3Vh9BK9TOkYXSJXHgFV7OFgWGryLhFzeGvNnEzXUN+hmYEZdDBup2hxZnBXMGirN1T8Teliwbiot0aA8+iAZ4c+NX4LQzzqEHk0TtPzAQh46Gpr41eqe0tEJLIe9TJzz3+obGNA+HEZUcR6aUdPRNyvqfxtoBsTNmHz0qgpiSqGy8Z1RgU0hytZ9Sk0NFwWI8/TwVP9c71c69WfSHpY2CnortRNrO/ThGtmpMajKr7+vzDuWwc/65lWoJwTyACNuLL96dUVWEDNOZWab7rEQWK4ZXkdC36S1Ilg64DSFSJATwjDh9zAyNAeImjd+oMr0cAociqWjEjBR8lqzsuguQWprCGglqUkgqytOSwX456EEx+R0KE7KqSuLTyUd+rzFzeip2RisU9c+inCKOzVE+59N9I0a95Qf2T1ZrBiQ1sJyXU7UGm6o0SBbMOiBcLmVq4sYQl8N9u2FgW6usWrmcPM+yeca9RMbPzrKV+Zivo+gPbc7RCGUY4+ukBhk47jl4bUu0ds1tyNJ2hqiaUWE8GGrbGmDc5d1Xt6Q1rT4Or2YsDWLlAnw3cNS5Xad1xMts4vrVEQW/RCa7gnTby21ijDe/FLWyW1BnIc3W0SNJWstyTq1QJDXN3OErwTcSCUoH5o/2ZrR0QDyXu6vxCPS+WAWtfZHo8MZWovGPEMmuwBIJvgN37UQ9GK+bHZeg9C0LU0XCpgxKL8RkydB1qWZr0+WURX1vTEZb x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB4965.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(346002)(396003)(39860400002)(136003)(366004)(2906002)(66946007)(66556008)(7696005)(84970400001)(26005)(38070700005)(8936002)(9686003)(8676002)(71200400001)(41300700001)(52536014)(76116006)(83380400001)(5660300002)(66446008)(64756008)(66476007)(53546011)(478600001)(33656002)(186003)(966005)(122000001)(86362001)(6506007)(55016003)(45080400002)(110136005)(316002)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UkMLHy9pO15Vd74PyeaMEe8KFjmk785sewFBeRwQK83F9qUZw4HsG3q2Fom+?= =?us-ascii?Q?geXNChkVaV0d5D/MXFFleacLAqjagkdjemntqccaP/HCVFVyC8xx0xVmc2jM?= =?us-ascii?Q?R9Ns12ARpZQecNKzeto/dGDIXLQHwS6glQnodw8p+P7pql57Viz1UvfQXrmF?= =?us-ascii?Q?5kQSPzmPN7bQkfyd5lcGRwVqw7WgdtIAPjFTkzSgAylD7cC6nCzeg4txA7dT?= =?us-ascii?Q?IivKfQ19sknL1TmHRbU9Y1CS3reuqsQlmFQxyyHORNqQLGR8RaVXPgdbiNyb?= =?us-ascii?Q?Bpxx3Enxynff5jPT0Duxt1BhGJ7MueT4GYvoS7qrCqXucshOIom0H6/Z4jt4?= =?us-ascii?Q?rhXKTAjNWAZoLnzGW+lGwBJmcBd28PB0ex4l+xHsVnam/fVCZvx52eHSMg+S?= =?us-ascii?Q?U3UAoSz52DLO+Mp36zaDicsXdAXlOrLHkBYfejxrfFO15hex3QTsHTp3Vbtx?= =?us-ascii?Q?czkmX/3mut01Gje5fWzIFa330gLNkfNmKekR5JfEWcEyHdOu8+ywI79K7PM5?= =?us-ascii?Q?RZUtuoWlHg/aGyQokJQpRXTj0rvJGoTyVLAqOtBcH/8WAMOkRPos2NwLc6n3?= =?us-ascii?Q?5uS5mzgiHbtxztyCl7v8cavsOtt5rlv5AjgzKvNTOKXpK8sPX1OKySK/bLZR?= =?us-ascii?Q?kly0WtoclPK9lntpphqzVxmJ7sMQhf/WGIVI2k0JsdquBYoCPN5nWyEa4Xfi?= =?us-ascii?Q?v/O1SeWDVN5tMMk25fbjAZ63xYdy6moKRWAUeH5lPFyoG+JiIc3J0/lNYzTI?= =?us-ascii?Q?8CUdoWPjodXQJFotTsq9kLC7Z2wPPVTKqHIAuzZlI3Pfgz8swm0kY9uaCa8W?= =?us-ascii?Q?rCUk1XFYymx7vtN+4VTo7Pc5uXgJ/8Wnlt8/3fp2sCT09JKIF9M/9dTD0JWt?= =?us-ascii?Q?zpGRRFl1ebCAARVujMEbkrJbcrDnrtyREsIA8QmNMvMcANGWFnqK2mrpVDre?= =?us-ascii?Q?838lIUeq+fEJTMeflAB2w4SxpqYodUVvfz0yMfR/b+aqsHjKD2911ILpx0JP?= =?us-ascii?Q?dfk8lB4Eg34nuTflJpwW+dV/73Rn0MYB/kSMTUQfAO+R7T4qEp8IcXonedf4?= =?us-ascii?Q?xzwWBD42gpk22lCJtwK0fYjZBcNv35A02i8Z2dRXCkeUpGmLfem0Qcls1O+y?= =?us-ascii?Q?vNmEs1DhP85HW3JiXWqwgyoFL61v7WpgSZDjDeLEutWQaMLk4J9/61wfJODW?= =?us-ascii?Q?Bv8AlVQPUOMDad0MBTFoRDa4mwGWKAFnODyku+W4gdxkDB159YR6jLhSJBKu?= =?us-ascii?Q?PYBJnXWG8BwbvRL4oO/4VWQpP6XlsOs3Q1eE+S9jjox4G+4I5vqZC0PP+4D9?= =?us-ascii?Q?0XNFQzmQH8odtfszrknIX1yRdA+3CAl7k+JyO8Dhxfb9FDVH7Egcx8J72M4a?= =?us-ascii?Q?d2THd/xGJM+x6fw6iWZPWxLCrHyaJtuoICDNEO1mrhKGW/CzCV6/UsUsv7EY?= =?us-ascii?Q?a+Apk4zaWKCHiUn07UANG9qQm+cwMk+G6fgSukAoG6NyWbnzocti2Pj33JSF?= =?us-ascii?Q?wQ3tx9DA3i8FoMB6GbJq4xYNgthJVBDJoeXmoVsxm0LhHCSOhQg+TgivZd6z?= =?us-ascii?Q?nnJc2nwuZvLFsT0g+R7D23DZZn/8bQtKAiNZXOwn?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4965.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 232d122e-adf9-4d9d-723d-08da5a67830d X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2022 07:09:45.2549 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 65QMYMJ1YphN9F3js54U1m2pBELHRKlDWgM5wKKZJ9WdsuRAJ1jBROmqlPlRSKh8lSNokj4qSl9JN5fn7oM5ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4345 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 07:09:52 -0000 [Public] LGTM. (Not an approver, though). Thanks for doing this! Thanks, Jini. >>-----Original Message----- >>From: Gdb-patches >bounces+jigeorge=3Damd.com@sourceware.org> On Behalf Of Willgerodt, Felix >>via Gdb-patches >>Sent: Wednesday, June 29, 2022 12:50 PM >>To: gdb-patches@sourceware.org >>Subject: RE: [Ping v2] [PATCH 1/1] gdb, testsuite: Adapt gdb.base/callfun= cs.exp >>for new clang warnings. >> >>[CAUTION: External Email] >> >>*ping* v2 >> >>Thanks, >>Felix >> >>> -----Original Message----- >>> From: Willgerodt, Felix >>> Sent: Mittwoch, 22. Juni 2022 10:40 >>> To: gdb-patches@sourceware.org >>> Subject: RE: [Ping] [PATCH 1/1] gdb, testsuite: Adapt >>> gdb.base/callfuncs.exp for new clang warnings. >>> >>> *ping* >>> >>> Thanks, >>> Felix >>> >>> > -----Original Message----- >>> > From: Willgerodt, Felix >>> > Sent: Mittwoch, 8. Juni 2022 09:17 >>> > To: gdb-patches@sourceware.org >>> > Cc: Willgerodt, Felix >>> > Subject: [PATCH 1/1] gdb, testsuite: Adapt gdb.base/callfuncs.exp >>> > for new clang warnings. >>> > >>> > This patch fixes two issues with callfuncs.exp, which are both >>> > related to new Clang warnings: >>> > >>> > 1) Clang 15.0.0 added a new warning for deprecated non-prototype >>> > functions: >>> > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fr= e >>> > >>views.llvm.org%2FD122895&data=3D05%7C01%7CJiniSusan.George%40amd. >>c >>> > >>om%7Ccef6651a3a784a1682fb08da599fd701%7C3dd8961fe4884e608e11a82d9 >>94e >>> > >>183d%7C0%7C0%7C637920840304960717%7CUnknown%7CTWFpbGZsb3d8eyJ >>WIjoiMC >>> > >>4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C >>%7 >>> > >>C%7C&sdata=3DimVO5B0vvv3%2B8rDeeI7vC%2F0lUSk2oCHbye1WevxCm6k >>%3D&am >>> > p;reserved=3D0 Callfuncs.exp is impacted and won't run due to new >>> > warnings: >>> > >>> > callfuncs.c:339:5: warning: a function declaration without a >>> > prototype is deprecated in all versions of C and is not supported in >>> > C2x [-Wdeprecated-non-prototype] int t_float_values (float_arg1, >>> > float_arg2) >>> > >>> > This patch disables those warnings with -Wno-deprecated-non-prototype= . >>> > Removing the test for deprecated syntax would also be an option. But >>> > I will leave that for others to decide. >>> > >>> > 2) The other new warnings are about comparing a define with floats >>> > and >>> > doubles: >>> > >>> > callfuncs.c:518:1: warning: floating-point comparison is always >>> > true; >>> constant >>> > cannot be represented exactly in type 'float' [-Wliteral-range] >>> > DEF_FUNC_VALUES_3(fc, float, crealf, cimagf) >>> > >>> > This can be fixed by making the define a float. >>> > --- >>> > gdb/testsuite/gdb.base/callfuncs.c | 2 +- >>> > gdb/testsuite/gdb.base/callfuncs.exp | 2 +- >>> > 2 files changed, 2 insertions(+), 2 deletions(-) >>> > >>> > diff --git a/gdb/testsuite/gdb.base/callfuncs.c >>> > b/gdb/testsuite/gdb.base/callfuncs.c >>> > index d18d0dba073..cf7c75c1360 100644 >>> > --- a/gdb/testsuite/gdb.base/callfuncs.c >>> > +++ b/gdb/testsuite/gdb.base/callfuncs.c >>> > @@ -96,7 +96,7 @@ long double _Complex ldc3 =3D 3.0L + 3.0Li; long >>> > double _Complex ldc4 =3D 4.0L + 4.0Li; #endif /* TEST_COMPLEX */ >>> > >>> > -#define DELTA (0.001) >>> > +#define DELTA (0.001f) >>> > >>> > char *string_val1 =3D (char *)"string 1"; char *string_val2 =3D (ch= ar >>> > *)"string 2"; diff --git a/gdb/testsuite/gdb.base/callfuncs.exp >>> > b/gdb/testsuite/gdb.base/callfuncs.exp >>> > index 4448cc127ba..d74357b8b48 100644 >>> > --- a/gdb/testsuite/gdb.base/callfuncs.exp >>> > +++ b/gdb/testsuite/gdb.base/callfuncs.exp >>> > @@ -18,7 +18,7 @@ >>> > >>> > standard_testfile >>> > >>> > -set compile_flags {debug} >>> > +set compile_flags {debug additional_flags=3D-Wno-deprecated-non- >>> > prototype} >>> > if [support_complex_tests] { >>> > lappend compile_flags "additional_flags=3D-DTEST_COMPLEX" >>> > } >>> > -- >>> > 2.34.3 >> >>Intel Deutschland GmbH >>Registered Address: Am Campeon 10, 85579 Neubiberg, Germany >>Tel: +49 89 99 8853-0, >>https://nam11.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fwww.in= t >>el.de%2F&data=3D05%7C01%7CJiniSusan.George%40amd.com%7Ccef6651a >>3a784a1682fb08da599fd701%7C3dd8961fe4884e608e11a82d994e183d%7C0% >>7C0%7C637920840304960717%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL >>jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C >>%7C&sdata=3DZoltodx7rLK1UwtZDmLCxGiKZnDUXSXq%2F6T9scBY6JQ%3D&a >>mp;reserved=3D0 >>>tel.de%2F&data=3D05%7C01%7CJiniSusan.George%40amd.com%7Ccef6651a >>3a784a1682fb08da599fd701%7C3dd8961fe4884e608e11a82d994e183d%7C0% >>7C0%7C637920840304960717%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL >>jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C >>%7C&sdata=3DZoltodx7rLK1UwtZDmLCxGiKZnDUXSXq%2F6T9scBY6JQ%3D&a >>mp;reserved=3D0> >>Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva >>Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munic= h >>Commercial Register: Amtsgericht Muenchen HRB 186928