From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2079.outbound.protection.outlook.com [40.107.96.79]) by sourceware.org (Postfix) with ESMTPS id 0D2CE3858D3C for ; Tue, 19 Apr 2022 11:53:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0D2CE3858D3C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hBZc1FtrUJ3+kLYWSi2q/v2GhCGk2MaqBc7qQ+0+MEcbBU34OpjP4uAOHoUY6ZNtrgcY+XCPZx9dYAw5QJ3s384PE9ZG3xK6M3/KRJDunUD/opUO89XK8E/Mr1XWzVAUdAS48X8vixq42wNpPGR8M2SNLqS36Or/DexcNaT5yr3mlqgxOQI3PMqiYtgozVtUr0bFXtyoBjviP2uIWwWuX1cHcBhOMW0/XSbB5DGrtymF0acTrciRrIw7Z6gpXG5oi+fWt7mKDenxEXtWV6XJPCJVXT6ZTjgF4ueE6MnaLU2Uu9EQFTS+bxz/fVNsru8MfD+zYLp0o6z0TTW7dCMckg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sPnPfHRuPQym2IVAy5ghlvNCKpKuNr6k9K3km3QOOY0=; b=ZnTGUuyCF80PdgsYl8HHKwYfmo4f4H3nhBEr3a0F9w0rVaN2L27ISvvgcIf4UdByGlzQPc4Ag/T6Us/nVthOBUft6U1bCo8AQZBRw4/IcTEhxP43zJNrFLyD+5y2bRFKCCgK0SWLkWjzBakJQzAoDjoC6nK13bg/naFak9KpjOtzYK+c1AZQ4zppTDC0aBDwW4ca9j8Ou2vKMizNnlUGMN96ibP6KA5as95eJpsUSwieN/3nJz/OxK58m7C9Knqp3OUJGoQH4FqaVCLjkHppPjVd96lp2ghx1V7eWUEhciit89kC3UX68eCvp3hROgFGKCy2/aTzkIpoxHqWYyI6tQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from BY5PR12MB4965.namprd12.prod.outlook.com (2603:10b6:a03:1c4::16) by MWHPR12MB1646.namprd12.prod.outlook.com (2603:10b6:301:10::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr 2022 11:53:35 +0000 Received: from BY5PR12MB4965.namprd12.prod.outlook.com ([fe80::1d0e:e73f:73c0:3a06]) by BY5PR12MB4965.namprd12.prod.outlook.com ([fe80::1d0e:e73f:73c0:3a06%4]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022 11:53:35 +0000 From: "George, Jini Susan" To: Nils-Christian Kempke , "gdb-patches@sourceware.org" Subject: RE: [PATCH v2 0/1] Fortran entry and DW_TAG_entry_point Thread-Topic: [PATCH v2 0/1] Fortran entry and DW_TAG_entry_point Thread-Index: AQHYT+PSlGYWF85b90mgxb/SDHhzuqz3I3rQ Date: Tue, 19 Apr 2022 11:53:35 +0000 Message-ID: References: <20220414094108.2758482-1-nils-christian.kempke@intel.com> In-Reply-To: <20220414094108.2758482-1-nils-christian.kempke@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ActionId=88fbe4f0-aa35-44fb-82b4-6aa9c5a1820c; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=true; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only-AIP 2.0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2022-04-19T11:35:54Z; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6b4b7308-d1c5-4c7c-3fe4-08da21fb3bf7 x-ms-traffictypediagnostic: MWHPR12MB1646:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TszyStAqyWJby2q31wzGiLpILoDEHceuTs8D83rFKszSTGl/m9kJKPFQ8FYXzzxhyaIl13rIk6cuESvydwXNx8+aadXzYQnwIL84Fio9u85Y1kS++TRWLZyqJ9XC8/MfSWMcS3VqhC3iuzQsfNQOfOF1wTh8Y0O2zUBLdVSIOtMmpu+I+8QXarhqzSy+ze0/HhG6a5Po8NtVsnkCOPlUrZuPOEVWd6Ibew6x4U8WmTPzYwoPhpNRq8vgtg9s5kGjlgHKedEaRv63I6n4UUrAuhb0WuQkwlVbQIVPqJwVpOVfdulGbxk+g8wlUnLJv8fyLDsMKaJr/gWVsOOrtRFdQExkRKiqph0lzjD62E/JVeCBUyPt2KTENlax+ChbTrFLc5zPFU3FwzlwU6jB+fREQR3n46UuIrdziLrCFBaYl6/p6Tt0gvHVOJwP6743U8gfofKf/qXGcwAd4Aqe4HSa84j98VQYFLqEOiepnBhHVGUmVTNheorMOG+5X1H4PaMBJyAgYWwBxWLwYhqfk0mJqBSK3FDgbAY8RIdxZfPOPI7/+yT367kXyAdFvMqOXvttdjG23uRvPhioWi8xWxZ1DqpktgGuje1TQtMllyvEpmk5SeKGdgGBTuqybHo2t+UlwCWHNp6eQo8TL5Vv4Vv69Pd0ASbOi5XtUUmHi9y/sv+wokcZthHA3H7rPXF+7gy1xA1u9YEWILbXk5mhjYIMlfKIz5+lqv3GtaoVR1dFauVgsABDOjpdPMl6SeFemvRVPvQ/yXYumn/NUXAJOUrqWZpYLYqy1CW4jJP2Hqt18jk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB4965.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(7696005)(9686003)(6506007)(45080400002)(26005)(71200400001)(186003)(316002)(38070700005)(38100700002)(83380400001)(110136005)(33656002)(8936002)(86362001)(2906002)(5660300002)(52536014)(55016003)(66556008)(66446008)(64756008)(66946007)(66476007)(508600001)(4326008)(76116006)(122000001)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jgSaxL+hk1BZzoA8100A+iTQtgHKvWXgRKkmNm5NDPQoHo7xtpUE/VkWD1tT?= =?us-ascii?Q?FX686I+uyimURJuaW1Z6t4notGUo6mnU4zWEM064I+IerHh5glotZEg7JV2B?= =?us-ascii?Q?MJqkmh87UdtLLylhM2kSkXL2UHbghw7WwtEci0HBCJUxaeTQoxqUb1WeO91A?= =?us-ascii?Q?q3XtKCWYHi/7OAoxFFrMbiVgc9xxjzOvOpX0bI+lnFJIZq77r1Egz99jYlix?= =?us-ascii?Q?+PChJsA7fEL0ub0/O+egNjiQu96HwCVWn398z5qeWJfnb2hsUPVMiAsXysks?= =?us-ascii?Q?coe2u38t97fI8h/t8/4sxvPuDm2kQQfqpV87ADmHNhKzquqM9iKMo/0n8jku?= =?us-ascii?Q?mODagrtZxZ1WCNQHpXbsDFftxxgbu80iVuNHizK2iPIxBhMKUWqIKiKHswJj?= =?us-ascii?Q?hDShyFWvremQPhSqJKlpcXfQo2q4JL9iMYcrO/+j8gaj1OJHclqhPwXOm/hL?= =?us-ascii?Q?WzoYk9z+aUSJGE1m2EyQ0SBb121z5RBpYhlNKJMg7jBc6MqV3e7cexeCrpC6?= =?us-ascii?Q?6M9xVTsvmsXXARrKJnb3lc9gIUqfjksvAsSJI8+hauZlnMlCjXuYmQeqwjzw?= =?us-ascii?Q?aE/QJzvoVsRL6tmTtqJHLt5Lekp6wrNrFfxMD4UwPdvtvwQs5g+I8+OO5YfG?= =?us-ascii?Q?sxmwXvVYZ2tSBB3HiG/3hROsW0GKNZ46bjtTf5egeZoApB6EUge9BQYY0J5N?= =?us-ascii?Q?onv3kVSIbT2TXnhRpWMeDH8sK4Xf/88q8L55FPy5wIs2jHE5q9ABDpE5tAr7?= =?us-ascii?Q?/l9rjb7N1/0f+sg87d5+hxf8hAAkBRuqvk97KFHJMC7Pwg1nKvE5sEirxI9i?= =?us-ascii?Q?2/Aox4xgXneZBDh+CuP7xKNVu/ReXaol80wmqkbv1q41w7jyQfoTVMp0PJuR?= =?us-ascii?Q?047QqJhBNUlA0B6BhtONVYbc3fkIJQTRs3Mq2IVRnZcmr3sr1hwHNn5aha9X?= =?us-ascii?Q?8hlaQw7N52G0vVnSOxTBtWCPVNQzfURUcGZRI5Re7VxF/Mr0AknwCH/xPUYO?= =?us-ascii?Q?cqk+rAVUh/QX5G1TBs+wjlkra7P/VirjHTIyzOfP8XcQakMRLwrbUzDvvnUB?= =?us-ascii?Q?r6RdrFyR0Ms3IJKmVdlpsqdtzCr3hdPcI6kKneznF762CvempUSf7jIwfULo?= =?us-ascii?Q?9K3rmPV2HN94Ee9dPvwR0tka/wt/JPDjO64qJvsW3bnMis0zaDLf1GafPYGV?= =?us-ascii?Q?g/k+PSYmP3D7n6paKvEEjK6dT9aa4ZJIl3sadimal0TXH//V+9wQ2GMN7OD4?= =?us-ascii?Q?Y8Nt7BPvCmS3AE7rlKzNH2AKJHPVuC3JG7MtfoTJoEOF5IrZ+76jiKGsOdT0?= =?us-ascii?Q?nvl9G/MZz4hHiKuxw2obLS5xLRjkVn8CIL3QrXL9AiRIYjyhl7yFPNAte3gC?= =?us-ascii?Q?05E2vfSDim75s+D+54u7FQY4as3V6oqOUwXiT+h1anLvbsDF3pWdjn5xd13Y?= =?us-ascii?Q?Qxr+tvTTNM2M9Sud75wYagqLxg0gvASMlE0wT/55utuFRmV0StxcDcqYxaY4?= =?us-ascii?Q?+SnuodimqqEQLZ88AGN+JD03m71UfuVSizr5DIq0rYxXqO9VNumC1HUuEEmO?= =?us-ascii?Q?ar9Y1Ppl/n8rbn/0eWqjqzvcKYXDYvDPDbBqTWqGGvLGoIY+S4oZx+w+z9Nu?= =?us-ascii?Q?GXe5QltKIl4TUf02OgFQHnvkVAyutKhs9gElTy9gUhWxK4KjMylDGDad3pPI?= =?us-ascii?Q?xlx8R0cZOTVtrNggGXuBfczmyLfamQAwyd3ioZpbVSGIjE7sWnTViq6PLLqU?= =?us-ascii?Q?oO6zyXoeMA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4965.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b4b7308-d1c5-4c7c-3fe4-08da21fb3bf7 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 11:53:35.2445 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pCeE04gbOj+zFr69+jtXwtlkpEj7Sy246IdQqGRfEvF7jOhaXXfdSUauvS4PAhSCODPg2oN2sene04Cw8Go2yg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1646 X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2022 11:53:41 -0000 [AMD Official Use Only] Thank you, Nils, for making the changes. The code part of the patch (I did = not look at the tests) LGTM except for one nit. In dwarf2_get_pc_bounds_entry_point(), ... the highpc from it's enveloping subprogram and get the lowpc from ... "it's" needs to be changed to "its" Thanks, Jini. >>-----Original Message----- >>From: Nils-Christian Kempke >>Sent: Thursday, April 14, 2022 3:11 PM >>To: gdb-patches@sourceware.org >>Cc: George, Jini Susan ; kevinb@redhat.com; >>Nils-Christian Kempke >>Subject: [PATCH v2 0/1] Fortran entry and DW_TAG_entry_point >> >>[CAUTION: External Email] >> >>Hi, >> >>please find attached v2 of this series. It introduced the handling of >>DW_TAG_entry_point to GDB. >> >>I want to emphasize again - between gfortran, ifort, and ifx only ifort s= eems to >>currently emit this tag. So the attached test only really works when usi= ng ifort. >>After a comment from Kevin I now added a gdb.dwarf2 test for GDB's handli= ng >>of this tag such that it can be tested without the availablity of a compi= ler >>emitting it. >> >>V1 can be found here, it was originally submitted as [RFC]: >> >>https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fsourc= e >>ware.org%2Fpipermail%2Fgdb-patches%2F2022- >>March%2F186900.html&data=3D04%7C01%7Cjinisusan.george%40amd.com >>%7Ca08c7e55cfad4480c8cc08da1dfaf41f%7C3dd8961fe4884e608e11a82d994e >>183d%7C0%7C0%7C637855260922818318%7CUnknown%7CTWFpbGZsb3d8eyJ >>WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C >>3000&sdata=3DhM3fCyuREy4Aj8XBeNaAb4HL%2B8mkBQAfuyAnpK5trCs%3D >>&reserved=3D0 >> >>Changes since v1: >> >> * I rebased to master and removed the partial symbol stuff from >> this patch since this part has been reworked recently. I hope I >> adapted to the changes correctly. >> * I added the handling of a DW_TAG_entry_points prefix in >> 'determine_prefix' (after Jini pointing out a bug here). >> * I removed an if that checked for fortran as the cu's language >> in new_symbol and made the handling of DW_TAG_entry_point >> language agnostic. >> * I changed the return type of 'dwarf2_get_pc_bounds_entry_point' >> to also return PC_BOUNDS_RANGES if the parent die returns these. >> * I added a gdb.dwarf2 test to be able to check this test even >> when one does not have ifort at hand. The new test compiles >> some .c helper with some labels and uses that to put some >> entry point dwarf on top. It then checks whether we can break >> at the entry points. >> >>Cheers! >>Nils >> >> >>Nils-Christian Kempke (1): >> dwarf, fortran: add support for DW_TAG_entry_point >> >> gdb/dwarf2/abbrev.c | 1 + >> gdb/dwarf2/read.c | 72 ++++++++- >> gdb/testsuite/gdb.dwarf2/dw2-entry-points.c | 39 +++++ >> gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp | 149 ++++++++++++++++++ >> gdb/testsuite/gdb.fortran/entry-point.exp | 84 ++++++++++ >> gdb/testsuite/gdb.fortran/entry-point.f90 | 67 ++++++++ >> 6 files changed, 411 insertions(+), 1 deletion(-) create mode 100644 >>gdb/testsuite/gdb.dwarf2/dw2-entry-points.c >> create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp >> create mode 100644 gdb/testsuite/gdb.fortran/entry-point.exp >> create mode 100644 gdb/testsuite/gdb.fortran/entry-point.f90 >> >>-- >>2.25.1 >> >>Intel Deutschland GmbH >>Registered Address: Am Campeon 10, 85579 Neubiberg, Germany >>Tel: +49 89 99 8853-0, >>https://nam11.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fwww.in= t >>el.de%2F&data=3D04%7C01%7Cjinisusan.george%40amd.com%7Ca08c7e55c >>fad4480c8cc08da1dfaf41f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C >>0%7C637855260922818318%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA >>wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sda >>ta=3Dde639g%2BROumUaBh9WP3GXaakd%2BW7VuTW%2F6YDJA9c5N4%3D&am >>p;reserved=3D0 >>>tel.de%2F&data=3D04%7C01%7Cjinisusan.george%40amd.com%7Ca08c7e55 >>cfad4480c8cc08da1dfaf41f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7 >>C0%7C637855260922818318%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj >>AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sd >>ata=3Dde639g%2BROumUaBh9WP3GXaakd%2BW7VuTW%2F6YDJA9c5N4%3D&a >>mp;reserved=3D0> >>Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva >>Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munic= h >>Commercial Register: Amtsgericht Muenchen HRB 186928