RE: [PATCH v3 03/14] change gdb.base/symbol-alias to xfail with clang

["George, Jini Susan" <JiniSusan.George@amd.com>]

[Public]

Hi Bruno,

Now that with Kavitha's changes, we have clang emitting debug information for alias variables (https://reviews.llvm.org/D120989)  and since we have her gdb patch (awaiting final approval) to enable support for clang emitted alias debug information, (https://sourceware.org/pipermail/gdb-patches/2022-April/188354.html), maybe we can wait on this ? If her patch goes through, we wouldn't have to make this test case an xfail.

Let me know if you think otherwise.

Thanks,
Jini.


>>-----Original Message-----
>>From: Gdb-patches <gdb-patches-
>>bounces+jigeorge=amd.com@sourceware.org> On Behalf Of Bruno Larsen via
>>Gdb-patches
>>Sent: Thursday, May 26, 2022 8:41 PM
>>To: gdb-patches@sourceware.org
>>Subject: [PATCH v3 03/14] change gdb.base/symbol-alias to xfail with clang
>>
>>[CAUTION: External Email]
>>
>>Clang does not issue alias information, even when using -gfull.  This commit
>>adds an xfail to that test in case we are using clang to reduce noise when
>>testing.
>>---
>>
>>No change in v3
>>
>>no change in v2
>>
>>---
>> gdb/testsuite/gdb.base/symbol-alias.exp | 9 +++++++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>
>>diff --git a/gdb/testsuite/gdb.base/symbol-alias.exp
>>b/gdb/testsuite/gdb.base/symbol-alias.exp
>>index 289f49bbc3f..f2b675e09ff 100644
>>--- a/gdb/testsuite/gdb.base/symbol-alias.exp
>>+++ b/gdb/testsuite/gdb.base/symbol-alias.exp
>>@@ -31,6 +31,11 @@ foreach f {"func" "func_alias"} {  }
>>
>> # Variables.
>>-foreach v {"g_var_s" "g_var_s_alias"} {
>>-    gdb_test "p $v" "= {field1 = 1, field2 = 2}"
>>+gdb_test "p g_var_s" "= {field1 = 1, field2 = 2}"
>>+
>>+# clang doesn't include variable alias information in the dwarf:
>>+#
>>+https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
>>+b.com%2Fllvm%2Fllvm-
>>project%2Fissues%2F52664&amp;data=05%7C01%7CJiniSus
>>+an.George%40amd.com%7C8b9c790bd30245184ac808da3f2a368f%7C3dd896
>>1fe4884e
>>+608e11a82d994e183d%7C0%7C0%7C637891747783140459%7CUnknown%7C
>>TWFpbGZsb3d
>>+8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
>>D%7C3
>>+000%7C%7C%7C&amp;sdata=8P8eeL5Y%2FlthVzjmehnJ8i1PTBMI1zy8t8TgEHF
>>%2FnHc%
>>+3D&amp;reserved=0
>>+if [test_compiler_info {clang*}] {
>>+    setup_xfail "clang/52664" *-*-*
>> }
>>+gdb_test "p g_var_s_alias" "= {field1 = 1, field2 = 2}"
>>--
>>2.31.1