From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 4704C395C03D for ; Wed, 16 Nov 2022 18:07:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4704C395C03D Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ibm.com Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AGI1Lu6039341; Wed, 16 Nov 2022 18:07:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pp1; bh=FvBwDybm1ZIOpJUN0WOy6ck1v+30HR/euGu5uMGPe4k=; b=Pcvo0Vqsmf36meMUdwTnmP7Pc733odl+fD+Q1TPMQX1mhU6E92U00yb7F9bC9OhzyWRf f7fVt8J9Wj/rOCdoIZnw5VCWf/eNlZbjgrsh/uBmOcys+0PvM17LkwSj93YiW5mnFP82 4P5j7iGbKGzqOXsBYl5k7rlCcD3nyycl805FPe2TSwy7DlWPtGoJoyQZnLP2A+ljtOHr 9An5ZPJa1/5yopxqsKVei8nNr5gI8u0nO/JVMXWYiuZWSF91Vm3Eg8Z3n2f5E1mFqH34 nuBfIpZNcWXWaB/Wibunp10m9WEwxD1AesQqqNyIji3rJMuH2l+LhGTQALkk0mS86wC4 8g== Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2043.outbound.protection.outlook.com [104.47.56.43]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3kw4sa86qt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Nov 2022 18:07:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bwlz40WbKxxL7EHtG9SXnfdu5pgQeVN5AMw/zjbTNJd8mKf1GWf9EI64tIP1xxXlTTVmN8TrGmwv6qegE4YZrtxLaEJQ//lEVk6RJlmlfVV7VOgBelLlSbC+p/14fxyOETY7GVw2xfP/WFRTonOQL27p1Xa9f+6r2+1XxtpL+ycxJSZ2tvmLNKVeQaqd9Cwa9MpM4CpG16Y8HrKs9EZzVlxF3PybdCIT2jucwB0fbA60q+iWnUTrbAqQoRbAvBvkXFIrb/sWHe8NuP/h2Gz3HS0q1Tx0ozEfOd+zMEdVZXXZVgXREX9ZFvEXcynu5sn3m6yX0eMJMEvw7X74SD8/5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FvBwDybm1ZIOpJUN0WOy6ck1v+30HR/euGu5uMGPe4k=; b=PCsnUqdYsEeLHj32OGq7ewsRyRagNvHLFf8HJbytQ3c6ZjpM8DjYHjg4kKFoc83kBRUX/boffX2P9UHHYsrcChTPdjMe82boiKmo4mOrPvzRdoDhD+If3soBGPI0KffqHnX7S54ReJlk6iu5OWHbxy2wbMjuzAfgwXS1+Zrp/XNlcMr8pSpZYuuoPHbpKoQnke5PYdUyI17zbhFKIQKGiNZIxbj2DVqDLHngzzCywhi5hwJYrWprAu27vPkvTEbb9my3apUcJwSpLQA6tNIl61W2bmbwifB2Kt/hOY5G87Wt+i+d0EnDM6d+j4ag3CNmG4uIQt274R5bT35RBMocDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ibm.com; dmarc=pass action=none header.from=ibm.com; dkim=pass header.d=ibm.com; arc=none Received: from BY5PR15MB3540.namprd15.prod.outlook.com (2603:10b6:a03:1b6::29) by SA1PR15MB4769.namprd15.prod.outlook.com (2603:10b6:806:19d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 16 Nov 2022 18:07:45 +0000 Received: from BY5PR15MB3540.namprd15.prod.outlook.com ([fe80::a9e0:881a:895f:5fb9]) by BY5PR15MB3540.namprd15.prod.outlook.com ([fe80::a9e0:881a:895f:5fb9%4]) with mapi id 15.20.5813.013; Wed, 16 Nov 2022 18:07:44 +0000 From: Aditya Kamath1 To: Ulrich Weigand , "gdb-patches@sourceware.org" , "simon.marchi@efficios.com" CC: Sangamesh Mallayya , Sanket Rathi Subject: Re: [PATCH] Fix call functions command bug in 64-bit programs for AIX Thread-Topic: [PATCH] Fix call functions command bug in 64-bit programs for AIX Thread-Index: AQHY8o8oLBa0QEnD0kK130AZD8l+9K41B4CAgAT1XL+ABKCogIAAGRWBgAAPgACAAAIJQYAABMQAgAAA+XmAAAamgIAClNw1gABN5YCAAC+6Xg== Date: Wed, 16 Nov 2022 18:07:44 +0000 Message-ID: References: <049a54779f7280ddef6c2da12d0714023514dc9b.camel@de.ibm.com> <881bbbcc3646f5df9c2f334133907d3ca37149a6.camel@de.ibm.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-IN X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR15MB3540:EE_|SA1PR15MB4769:EE_ x-ms-office365-filtering-correlation-id: 43dbdef0-6a4e-450e-98a2-08dac7fd7627 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SqX5Zp1SGlsnNzGiKDsdrnpbGRS7Llra+HuFQuHgbgEMztL/+i4qnM2bLyd0fgWIepdbgJYm1IkErol9REzt6nSnSFhAm9S6tpPg0HD9nBDPach+d19+xBZ6X7XctqaptF4Rtd+eQK8QjG1EkpZ+V4Qy8Nn11HoJHZbCC2dqce4ABym801SDUH6RDSC1FvSFk8KmnN4czUXRHF/jzvWPGzj38ZnONdbA4R/hyVHoyg2dnu88i61sPPRa+YzNyUqz3PxhQHo0iSC5c6Tpb4L8wbrTdkT150UpoDDywmAWa2Y8SSj3QRo8ZHEIFxZENdO+qD/ovV0M5vbKTbDlE9js3JLkqyM4FLqzi4WXxNgPlafOyOdCpyuUHQYlHWfT2ZXqwAufiD/dIIgTNKAmSxB3MArXAsDf2IoOXL1zulPXCzhp0qrgBoDXzGE6pJ3Y7rS144k+0PaOu40aPL4L3+ITpEYfPB/J+RQ08y6rwYfh+lNsL8vQlu04knGyqc24VUWdRoCRB+BDIIDe4s8p8gygCseXF7viFgie4aEfxyw8qPl6RZFlLZyt+9F8bRBtKMhMOxAcQO7BlsCwAYz/RNGszwFb409cs38zlDEjJRo/hLhDIOBvQ5B0CN8+QHyrhgnzhGx6HiGNSCAUj3MPIx52d6RrPcKeBxKtj7xytveT9DPnZl6gehkokmPLRqg8aTW+bw3Y4hN5fflfsHHBPEBIy/h0E656rPfBKDohJWla8HszF6Ri0nJVEV4sBU7ecGhEyybBpA46RKxXaamSMNYxsQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR15MB3540.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(346002)(376002)(396003)(366004)(451199015)(86362001)(83380400001)(38100700002)(33656002)(99936003)(122000001)(38070700005)(478600001)(71200400001)(53546011)(6506007)(7696005)(64756008)(66556008)(55016003)(52536014)(76116006)(66476007)(66946007)(4326008)(8676002)(5660300002)(110136005)(41300700001)(316002)(9686003)(66446008)(54906003)(186003)(91956017)(8936002)(2906002)(19627405001)(579004)(559001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vyFmCIpcqOufC4Hk8uDmULuNrOtYWuSVuG5j6Vg9GvHAcYL1D1D6jRp/QS71?= =?us-ascii?Q?EHJBLc4QmGvcKPRiAEW10EnhKs5zqx8X3HZtZ6UkFR48lV6hL+AjOr+2sTNr?= =?us-ascii?Q?sH3uhjqR2qfmX8QPuBR+XOrzNQRGn6rZ5NBAAlJbYDHUwoY7ZoOeC9fpBKpD?= =?us-ascii?Q?hIcYavN+BIlM4oWMjA06jZMKC6+XUjb009ubDnkQRR9LevLwQMSh/mJnujyo?= =?us-ascii?Q?rn/zmwo7dkJ3M6zPmF4UxCFc7N+wi+xmv8X1FE27XmYANSNdapmroBuJCSvG?= =?us-ascii?Q?Uu1Y8Qyjf1QwIQ+kKG/uRqLIbw94SPsmje9+8xzBN0WNEtY4ew+H/i/SqhaB?= =?us-ascii?Q?9CIOSpLcQ5OUG0KgfjKroOYZKbYNQf9/arXSj5F+ZMeceaYvkYDNVMIXHejc?= =?us-ascii?Q?SV9HbD1QK77hVnLqTnnGXNg1v0WWJSEQdmPXicejN3rLzgC+tTal/2SzEGPF?= =?us-ascii?Q?+V0HIKvhgdq7NlNmb1kvg5Vs61sB6EESX/HidnVFCRcitcEt3ovokR5c0aAW?= =?us-ascii?Q?cQ5vCI8n+m4tnCXMKQ/uBa9yx4g6U/imF9G/KnQu7qlVUAADHUOndM45AaB5?= =?us-ascii?Q?jYOscEDm5lnBIBdOR8UQYdC/iQC+1Fgt3HP7yO40a5kUyoetu7PitLh6k4an?= =?us-ascii?Q?PdkOkupyFke5/QsKNM2wuoBNTlqL6lgqeQuDM4+MWtFWXvVK/mjfzQcEidLn?= =?us-ascii?Q?q39RQF48khSh22G2Nmrhs6+hibj43KY5ZF3FDQ4Q+lomJhVWCjUftrjAPB0T?= =?us-ascii?Q?2JcHA/LTcvkEEJHF3LjLqMVomfyLlcCxRl4cDIe0Y6usKr9L4HKC/pGEWcJT?= =?us-ascii?Q?0FK/2omPY4rMC7xJBsUFnliKS9+PiklnViFjQ9LJSn3OZTtyKrFr5O5JSZn5?= =?us-ascii?Q?ORqfM4guj8oNqnSA8IIYe2WfSL0Ks/DEm/hzRR3PD7odJ+JnAX/WfW4VyQ9E?= =?us-ascii?Q?yGYW+XOzfE1d3naju/xoyt/ZK6gfu0pEyCEaWXZbWL14BsqPrjDE+b+mQUOd?= =?us-ascii?Q?qYsePlP2gED8dPCXztkaqLyWNmyzyT9f3T1OoZ9R8wvk2nivHjMb1YVcACzs?= =?us-ascii?Q?kmhYuDL7qTwy7MyOhoOQDGUlpIpAOVr8x9EksAEKxGu5jMsF7D5wQWVET9k0?= =?us-ascii?Q?rqFD6AEZg4paXvW+LFkSG3Py2D5flYTZLBDzdPfoxj9wBhZKiEWdL0m5n9B2?= =?us-ascii?Q?lZjili9oxtDTPVTqQfF32JjkvtOr+UCwxHh5Ute6/meqPlP6Way7S1oglgOb?= =?us-ascii?Q?XPhHUZ8jGXOUVcveDXWXCKm1SofWBs+2MQWCO7kvH3RVuoLbwmb4crkK2cXQ?= =?us-ascii?Q?TMJWBDkTWeWyNiFng5O+bD7qN5IC2GO4vGL8+DOaOPFG08TNaai+bfAq/9hM?= =?us-ascii?Q?nQPqEpFwPAx3FN0PJvK8bXBFI/C9YOYDLSOjk+zxS1E2SDkkwC7lsgspPZLz?= =?us-ascii?Q?dmlIM+ovGgV/9ByHEsExRLeLkKprXyvHqHo/wCsg1zWmug/O8iqJSRnmrOZs?= =?us-ascii?Q?CukZ/bd7D8GzCI9WRnN+DFRNFE/gQWXAGJYwi6XwmAZe0u5OQvMNX8DcpLzs?= =?us-ascii?Q?DUGw3fH69qpL4uycvMSi3VuXBCy7uXreatDOlpuOinV4ZFxYdr5vqjaQBqqt?= =?us-ascii?Q?33BiG4ddWoRf3Me3Y9aXxKyA8S8aAQg99g2ZGBnpNKdk?= Content-Type: multipart/mixed; boundary="_004_BY5PR15MB3540464A747BB9A3BC13C81DD6079BY5PR15MB3540namp_" MIME-Version: 1.0 X-OriginatorOrg: ibm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR15MB3540.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43dbdef0-6a4e-450e-98a2-08dac7fd7627 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2022 18:07:44.9150 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fcf67057-50c9-4ad4-98f3-ffca64add9e9 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GlNnLRdax6P/lN0Ycd37NdCecgbN5R7xAbKI8eieNwJUSv3mWTD0qmxLbTWfNnv5+Be44nxZnv4FymfaCrI0XQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR15MB4769 X-Proofpoint-ORIG-GUID: GczykGyMgG1JKtOP25urqQ97f3YTunsc X-Proofpoint-GUID: GczykGyMgG1JKtOP25urqQ97f3YTunsc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-16_03,2022-11-16_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 adultscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211160124 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --_004_BY5PR15MB3540464A747BB9A3BC13C81DD6079BY5PR15MB3540namp_ Content-Type: multipart/alternative; boundary="_000_BY5PR15MB3540464A747BB9A3BC13C81DD6079BY5PR15MB3540namp_" --_000_BY5PR15MB3540464A747BB9A3BC13C81DD6079BY5PR15MB3540namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ulrich, Please find attached the new patch. See 0001-Fix-call-functions-command-bug= -in-64-bit-programs.patch. >It might not really be necessary to handle pointer and reference >types if those are always guaranteed to be word sized. But I >think enum, bool, and char types should be handled. You were right. Thank you for pointing out. I have attached the outputs bel= ow. It works fine now. >Also, it would probably be preferable to use reg_size instead >of tdep->wordsize to be consistent. This is changed.. >Finally, there are still white space issues (use tabs instead >of 8 spaces, if there's just a single statement inside an if >it is indented only 2 spaces, not 4). I took care of it. Kindly check.. If all is fine, kindly push this patch to the community. Let me know in cas= e I missed something otherwise. Have a nice day ahead. Thanks and regards, Aditya. -------------------------------- PROGRAM #include "stdio.h" #include enum week {Sunday, Monday, Tuesday, Wednesday, Thursday, Friday, Saturday} = w; int num2print(long num, float num2, int num3, double num4, enum week w, cha= r c1, bool b1, char *mystring) { printf("R%ld\n",num); printf("R%f\n",num2); printf("R%d\n",num3); printf("R%lf\n",num4); printf ("Day number passed is %d\n",w); printf ("R%c\n", c1); printf ("R%d\n", b1); printf ("FIFA winner is %s \n", mystring); return num; } int main(int argc, char** argv) { enum week today =3D Wednesday; char fifaWinner[] =3D "Germany"; bool x =3D false; printf("Hi Bangalore %x\n",num2print(27, 16, 13, 9.9, today, 'a', x, fifa= Winner)); return 0; } -------------------------------------- 32 bit output before patch.. Reading symbols from /home/XYZ/gdb_tests... (gdb) b main Breakpoint 1 at 0x1000067c: file /home/XYZ/gdb_tests.c, line 19. (gdb) r Starting program: /home/XYZ/gdb_tests Breakpoint 1, main (argc=3D1, argv=3D0x2ff22bf0) at /home/aditya/XYZ.c:19 19 enum week today =3D Wednesday; (gdb) n 20 char fifaWinner[] =3D "Germany"; (gdb) 21 bool x =3D false; (gdb) call num2print $1 =3D {int (long, float, int, double, enum week, char, _Bool, char *)} 0x10000518 (gdb) call num2print (2, 3.4, 5, 6.7, Wednesday, 'c', 1, fifaWinner) R2 R3.400000 R5 R6.700000 Day number passed is 3 Rc R1 FIFA winner is Germany warning: (Internal error: pc 0x10000290 in read in psymtab, but not in symt= ab.) $2 =3D 2 ----------------------------------------------------------- 64 bit output before patch Reading symbols from /home/XYZ/gdb_tests... (gdb) b main Breakpoint 1 at 0x10000818: file /home/XYZ/gdb_tests.c, line 19. (gdb) r Starting program: /home/XYZ/gdb_tests BFD: /usr/lib/libc.a(/usr/lib/libc.a(shr_64.o)): wrong auxtype 0xff for sto= rage class 0x2 BFD: /usr/lib/libc.a(/usr/lib/libc.a(shr_64.o)): wrong auxtype 0xff for sto= rage class 0x6b Breakpoint 1, main (argc=3D1, argv=3D0xffffffffffffad0) at /home/XYZ/gdb_tests.c:19 19 enum week today =3D Wednesday; (gdb) n 20 char fifaWinner[] =3D "Germany"; (gdb) 21 bool x =3D false; (gdb) call num2print (2, 3.4, 5, 6.7, Wednesday, 'c', 1, fifaWinner) R2 R3.400000 R0 R6.700000 Day number passed is 0 R R0 FIFA winner is Germany $1 =3D 2 (gdb) ------------------------------------------------------------------------- 32-bit output after patch Reading symbols from /home/XYZ/gdb_tests... (gdb) b main Breakpoint 1 at 0x1000067c: file /home/XYZ/gdb_tests.c, line 19. (gdb) r Starting program: /home/XYZ/gdb_tests Breakpoint 1, main (argc=3D1, argv=3D0x2ff22bf0) at /home/XYZ/gdb_tests.c:19 19 enum week today =3D Wednesday; (gdb) n 20 char fifaWinner[] =3D "Germany"; (gdb) 21 bool x =3D false; (gdb) call num2print (2, 3.4, 5, 6.7, Wednesday, 'c', 1, fifaWinner) R2 R3.400000 R5 R6.700000 Day number passed is 3 Rc R1 FIFA winner is Germany $1 =3D 2 (gdb) ----------------------------------------------------- 64-bit output after patch Reading symbols from /home/XYZ/gdb_tests... (gdb) b main Breakpoint 1 at 0x10000818: file /home/XYZ/gdb_tests.c, line 19. (gdb) r Starting program: /home/XYZ/gdb_tests BFD: /usr/lib/libc.a(/usr/lib/libc.a(shr_64.o)): wrong auxtype 0xff for sto= rage class 0x2 BFD: /usr/lib/libc.a(/usr/lib/libc.a(shr_64.o)): wrong auxtype 0xff for sto= rage class 0x6b Breakpoint 1, main (argc=3D1, argv=3D0xffffffffffffad0) at /home/XYZ/gdb_tests.c:19 19 enum week today =3D Wednesday; (gdb) n 20 char fifaWinner[] =3D "Germany"; (gdb) n 21 bool x =3D false; (gdb) call num2print (2, 3.4, 5, 6.7, Wednesday, 'c', 1, fifaWinner) R2 R3.400000 R5 R6.700000 Day number passed is 3 Rc R1 FIFA winner is Germany $1 =3D 2 (gdb) call num2print (2, 3.4, 5, 6.7, Wednesday, 'e', 0, fifaWinner) R2 R3.400000 R5 R6.700000 Day number passed is 3 Re R0 FIFA winner is Germany warning: (Internal error: pc 0x100000480 in read in psymtab, but not in sym= tab.) $2 =3D 2 (gdb) ________________________________ From: Ulrich Weigand Sent: 16 November 2022 20:45 To: gdb-patches@sourceware.org ; Aditya Kamath1= ; simon.marchi@efficios.com Cc: Sangamesh Mallayya ; Sanket Rathi Subject: Re: [PATCH] Fix call functions command bug in 64-bit programs for = AIX Aditya Kamath1 wrote: >In AIX for 64-bit programs, we need to zero extend variables of integer da= ta type. This looks much more reasonable, thanks! Just a couple of remaining questions: > memset (word, 0, reg_size); >- memcpy (word, value_contents (arg).data (), len); >+ if (type->code () =3D=3D TYPE_CODE_INT) >+ /* Sign or zero extend the "int" into a "word". */ >+ store_unsigned_integer (word, tdep->wordsize, byte_order, >+ unpack_long (type, value_contents= (arg).data ())); >+ else >+ memcpy (word, value_contents (arg).data (), len); > regcache->cooked_write (tdep->ppc_gp0_regnum + 3 +ii, word); Is it correct to handle *only* TYPE_CODE_INT here? The corresponding code in the Linux ABI code has: else if ((type->code () =3D=3D TYPE_CODE_INT || type->code () =3D=3D TYPE_CODE_ENUM || type->code () =3D=3D TYPE_CODE_BOOL || type->code () =3D=3D TYPE_CODE_CHAR || type->code () =3D=3D TYPE_CODE_PTR || TYPE_IS_REFERENCE (type)) It might not really be necessary to handle pointer and reference types if those are always guaranteed to be word sized. But I think enum, bool, and char types should be handled. Also, it would probably be preferable to use reg_size instead of tdep->wordsize to be consistent. Finally, there are still white space issues (use tabs instead of 8 spaces, if there's just a single statement inside an if it is indented only 2 spaces, not 4). Bye, Ulrich --_000_BY5PR15MB3540464A747BB9A3BC13C81DD6079BY5PR15MB3540namp_-- --_004_BY5PR15MB3540464A747BB9A3BC13C81DD6079BY5PR15MB3540namp_ Content-Type: application/octet-stream; name="0001-Fix-call-functions-command-bug-in-64-bit-programs.patch" Content-Description: 0001-Fix-call-functions-command-bug-in-64-bit-programs.patch Content-Disposition: attachment; filename="0001-Fix-call-functions-command-bug-in-64-bit-programs.patch"; size=1483; creation-date="Wed, 16 Nov 2022 18:06:24 GMT"; modification-date="Wed, 16 Nov 2022 18:06:50 GMT" Content-Transfer-Encoding: base64 RnJvbSBkOWE4ZTQzZDkzZGI2NjliM2Y2MzI0NTQ5ZWRjNzYyMGU2NDIyOTUx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBZGl0eWEgVmlkeWFk aGFyIEthbWF0aCA8QWRpdHlhLkthbWF0aDFAaWJtLmNvbT4KRGF0ZTogV2Vk LCAxNiBOb3YgMjAyMiAxMjowMjozOCAtMDYwMApTdWJqZWN0OiBbUEFUQ0hd IEZpeCBjYWxsIGZ1bmN0aW9ucyBjb21tYW5kIGJ1ZyBpbiA2NCBiaXRzIHBy b2dyYW1zIGZvciBBSVgKCkluIEFJWCBmb3IgNjQgYml0IHByb2dyYW1zIHdl IG5lZWQgdG8gemVybyBleHRlbmQgdmFyaWFibGVzIG9mIGludGVnZXIgb3Ig ZW51bSBvciBjaGFyIGRhdGEgdHlwZS4KCk90aGVyd2lzZSBhIHplcm8gd2ls bCBnZXQgZHVtcGVkIGluIHRoZSByZWdpc3RlciBhcyB3ZSBtZW1zZXQgb3Vy IHdvcmQgdG8gMCBhbmQgd2UgY29weSBub24gemVybyBleHRlbmRlZCBjb250 ZW50cyB0byB0aGUgY2FjaGUKClRoaXMgcGF0Y2ggaXMgYSBmaXggZm9yIHRo ZSBzYW1lLgotLS0KIGdkYi9yczYwMDAtYWl4LXRkZXAuYyB8IDEwICsrKysr KysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb24oLSkKCmRpZmYgLS1naXQgYS9nZGIvcnM2MDAwLWFpeC10ZGVwLmMg Yi9nZGIvcnM2MDAwLWFpeC10ZGVwLmMKaW5kZXggZDQ3OTc0YjUxZDEuLjVl NjcwNzIxZDI5IDEwMDY0NAotLS0gYS9nZGIvcnM2MDAwLWFpeC10ZGVwLmMK KysrIGIvZ2RiL3JzNjAwMC1haXgtdGRlcC5jCkBAIC00MDAsNyArNDAwLDE1 IEBAIHJzNjAwMF9wdXNoX2R1bW15X2NhbGwgKHN0cnVjdCBnZGJhcmNoICpn ZGJhcmNoLCBzdHJ1Y3QgdmFsdWUgKmZ1bmN0aW9uLAogCSAgZ2RiX2J5dGUg d29yZFtQUENfTUFYX1JFR0lTVEVSX1NJWkVdOwogCiAJICBtZW1zZXQgKHdv cmQsIDAsIHJlZ19zaXplKTsKLQkgIG1lbWNweSAod29yZCwgdmFsdWVfY29u dGVudHMgKGFyZykuZGF0YSAoKSwgbGVuKTsKKwkgIGlmICh0eXBlLT5jb2Rl ICgpID09IFRZUEVfQ09ERV9JTlQKKwkgICAgIHx8IHR5cGUtPmNvZGUgKCkg PT0gVFlQRV9DT0RFX0VOVU0KKwkgICAgIHx8IHR5cGUtPmNvZGUgKCkgPT0g VFlQRV9DT0RFX0JPT0wKKwkgICAgIHx8IHR5cGUtPmNvZGUgKCkgPT0gVFlQ RV9DT0RFX0NIQVIpCisJICAgIC8qIFNpZ24gb3IgemVybyBleHRlbmQgdGhl ICJpbnQiIGludG8gYSAid29yZCIuICAqLworCSAgICBzdG9yZV91bnNpZ25l ZF9pbnRlZ2VyICh3b3JkLCByZWdfc2l6ZSwgYnl0ZV9vcmRlciwKKwkJCQkg ICAgdW5wYWNrX2xvbmcgKHR5cGUsIHZhbHVlX2NvbnRlbnRzIChhcmcpLmRh dGEgKCkpKTsKKyAgICAgICAgICBlbHNlCisJICAgIG1lbWNweSAod29yZCwg dmFsdWVfY29udGVudHMgKGFyZykuZGF0YSAoKSwgbGVuKTsKIAkgIHJlZ2Nh Y2hlLT5jb29rZWRfd3JpdGUgKHRkZXAtPnBwY19ncDBfcmVnbnVtICsgMyAr aWksIHdvcmQpOwogCX0KICAgICAgICsrYXJnbm87Ci0tIAoyLjMxLjEKCg== --_004_BY5PR15MB3540464A747BB9A3BC13C81DD6079BY5PR15MB3540namp_--