From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by sourceware.org (Postfix) with ESMTPS id 308B0385840B for ; Mon, 31 Jan 2022 08:15:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 308B0385840B X-IronPort-AV: E=McAfee;i="6200,9189,10243"; a="310729927" X-IronPort-AV: E=Sophos;i="5.88,330,1635231600"; d="scan'208";a="310729927" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2022 00:15:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,330,1635231600"; d="scan'208";a="675663182" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga001.fm.intel.com with ESMTP; 31 Jan 2022 00:15:53 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 31 Jan 2022 00:15:53 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 31 Jan 2022 00:15:52 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 31 Jan 2022 00:15:52 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.45) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 31 Jan 2022 00:15:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ds+tYbB8uIC+8BGL6u/dNq/BN3A+dc/QiLe+frCwK64Ls3/T5oIZoIudUWiSKQiCZ1oStndz9MWtWLtrn7OOkDQzvJ49UX5/Oaqo3Qk+3GJjDd8FNJII8K0VhGfN8TvY8/9Hgl78mUm6Gp+ne3TxO1qCnzeDrk/AWro5ULmoHWnny6t7MBkPHoWq6r0lISDYkymbUZn47vyuoMRIGyRWad83oiCIuJaON2TBa7RbvVYpDaDKVpp5mz7LssXupsw0Tq5fqUc9ULm4p2N5X2/cn1gnMlwQoZPC8RbDfQjzbpcVkNaFnPtBJl9HEa+BbE1bbfUc9roWcBgVN23kPhEZYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O+3KRaAV1fKg+D9OWf1sBC3Qy55HaCXeBaV+cdagpMw=; b=ls9dmUbwLeGUMVgHjohLh/Qbd53uMds778cCIObXER6dNEKJg5N0lZ5DXv71lQmkao9N1oG1cPhklDJfks5fW3TybeWt1LtTkH06hs7adNOU3ef3ABXE0d7Ui9P+Q3b0PAKwbQGHO5EdxbGqO42E+raj73D1vnIhUWRVDGB4gKsFR3TXpHNdRPkzHRY14aFJJegM32UJK3reo0adXBPa2MOMPLgFsRnzkZpTc9WkzoFchAJLADXCgAONCoyVDbI+wxW3o8D+tTMoA9hSrHuahbia8rIRCs9d7PR0zOpzdlnYgpqz+jYGx+rjRZsU44TsJi1i0XJxZ4DKXZIHufTndA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BYAPR11MB3288.namprd11.prod.outlook.com (2603:10b6:a03:7e::33) by BY5PR11MB4053.namprd11.prod.outlook.com (2603:10b6:a03:183::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Mon, 31 Jan 2022 08:15:50 +0000 Received: from BYAPR11MB3288.namprd11.prod.outlook.com ([fe80::740e:38d7:a41b:e462]) by BYAPR11MB3288.namprd11.prod.outlook.com ([fe80::740e:38d7:a41b:e462%6]) with mapi id 15.20.4930.021; Mon, 31 Jan 2022 08:15:50 +0000 From: "Kempke, Nils-Christian" To: Tom Tromey , Nils-Christian Kempke via Gdb-patches Subject: RE: [PATCH 1/2] gdb/types: Resolve dynamic properties of pointer types. Thread-Topic: [PATCH 1/2] gdb/types: Resolve dynamic properties of pointer types. Thread-Index: AQHYDG8P1EFAVo4NPUCUJP4aB0peZqx40eSEgAQKIiA= Date: Mon, 31 Jan 2022 08:15:50 +0000 Message-ID: References: <20220118132626.3786176-1-nils-christian.kempke@intel.com> <20220118132626.3786176-2-nils-christian.kempke@intel.com> <87mtjf3e85.fsf@tromey.com> In-Reply-To: <87mtjf3e85.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f5db2806-f39f-4ebd-72d8-08d9e491e48b x-ms-traffictypediagnostic: BY5PR11MB4053:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i2Pki4250bMQF9xlzqJ1ekzi0KntGlUe2+GHnDpzHlbHbaPvtoibfSYEVDUkqcTwGqOnycBJCTkZet3EyViI5MTkowF04idWlFLfqgIoUHeMoE65GUElMZiOkCGBjfMJb6ZCtsPWV9VTEQa0TYsZ4gTiC5adkwg+DjKdXK5CuOBzRQ+5gW79j21/G9MmTXSVdKvN1pGfbNI4rHOPRgFIHUyWvcww9AORJS24c9vbi1mSaDZnNGcIdZ1v4zYj3CXpFkj1PUDEDUwtcEWSMLXvTwuogf6SlLlD2D6WZN9qG8nYUPtmsKuBQSpZDF2t7vJko420RUP0tus9MjNzm3YsP2Zlxandlux5PU5AGw2//c5Mqs+NoLFLMbOwpPhcNOzer8qyadbp4eAXNkqgbCUq3YAtW6nnCGQUTz5nI7XCUiwmDTrHDD6ZW/TCOv6cN+zTUdz1+0Ro15zn1yWtAQYX3+ezoBivySu6Zg4lzhCoj7tk9w7d1c1tAkY69AkhM+zATxo3I5poLhEKF/O4Gtl3nZMHK/xLMyUXgiMjlvcOzpiur2Y2NKagF8Jj8tD0AKrzBB1bCxT9u3IKdqP1ZIKrzMg3zE9cRygNzVqncQtE/a29X+Grs1cdN9MtPUaM7q5qtipjR3/15d5tpQ0cxmG+ppXIOLe58NlTKSZALFOwOU1Gpz0vqxUgbmEdMKdZA/1IQdE6MFg7+rpq7d3BluPEzA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3288.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(4744005)(110136005)(86362001)(83380400001)(64756008)(9686003)(55016003)(66946007)(5660300002)(76116006)(52536014)(316002)(66476007)(8936002)(8676002)(2906002)(66556008)(66446008)(53546011)(7696005)(6506007)(38070700005)(71200400001)(122000001)(38100700002)(33656002)(186003)(82960400001)(508600001)(20210929001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mRYY4d3nvbqcHKmX4oHUoQFB4uBCSZhqrw7SDtJJPPnFyS35acfAR225DaAt?= =?us-ascii?Q?dZRSqAzlmzCxml+2BBtr2pcrzXIQKmzSFb3YaRkj/NE7SimlrWNAsho5DznS?= =?us-ascii?Q?ViSW7sW1dbM3KomJmxFWC/SDbRnUodg+hLHMwljNh73eh2f4cy6Jgr8lf4Px?= =?us-ascii?Q?b82bQ4OyKG1+9ca3UFxCB/I13Rm+C0PiToxeZIurEED8SQn+bkql3R05g6E8?= =?us-ascii?Q?qQ/EBsWtBcKviS4PH+GFJ8JCWCQMpJpZBOTo6Nb5niUN8n0SDdw7GfGVoH88?= =?us-ascii?Q?5dNbp73tLjrH24T34qGmQUO51kn8rBAFXXwX2VArzYsmbj7pTQhQtSC13HLx?= =?us-ascii?Q?O/SAtpu3pKLVXlFdT8ZZCBYle7GtNKTFKM4nhqTEVop55I0HGEchbJ+YaBoM?= =?us-ascii?Q?qTebQ/q8YKxk3z+8mnZQZwHfs/+6Js+eBF/U5kk8I5GL7FddrgZgenoPu0CL?= =?us-ascii?Q?4/liuOCNXNRNZxZiZZX8tuhZwcJ+720j6Cpu8aRtK9tUz4CmzFWpjHelCJnP?= =?us-ascii?Q?DIISmi6aQDppWUZtHtPUe3D+kDdhFGZRJedcaVsG7gB2nysddqdjtmRAFOr0?= =?us-ascii?Q?WqgE88I5XhZDpwBxIEv2KnYFmGKvlJnqbqTK9L8m2chW+jBoPcUZRtYkBZzn?= =?us-ascii?Q?Zxhserld62mFeWN1iJI1uN7ZP8kXLX92gY834jyd2De+y6rRAoT+bugMbObr?= =?us-ascii?Q?voZTZMN7HHpbo32nTZA/PO6bW/BCJbtOUARON1Bz8mlTIR0+UKlA3bwgiPn+?= =?us-ascii?Q?bdc8H72pjOvK3pfioCE3T5kEtJjEZdMHpyeyD5Y/RkId02wceJ9OdKse+wWA?= =?us-ascii?Q?tNvvoL2QB3mcawn4jkvDKaYv6YCQ0183/XZbMmS+J7pQRBA//KB3s554+oNG?= =?us-ascii?Q?Uh1HsITXZerl273oSz39hRmagQgVKC3DBnJ52sSZJVqhNQzagUVJnBnliFwO?= =?us-ascii?Q?vSWNpFei5PcwoPeBrxyWhifQkxrXtMHDhQbfAB2qQpwa/h7VwvIE7BFli5zF?= =?us-ascii?Q?Q+bsdyLo4O+1SCDVgWW7gW3LdjbwllZoPTftzmBj++dC4uiJ7z8pD/QRr6jY?= =?us-ascii?Q?+zeqJ21skKwhiEzFQ99gHkMOagrN0ngaacbJLe6uSvZRsWwNy3Mq+zkyBSJE?= =?us-ascii?Q?mkUY7FcVFTLfgel+65PsEZixZ8Vu2MxIJt5q9F2v16y1xxjDKwFresXhL6yB?= =?us-ascii?Q?6donmEDjVgBAvlSjH5VuxOZ5Vw8Pwt5ELH9NjQL660lNaHXKx91ReieG6Oeb?= =?us-ascii?Q?PQCJUA6vJa19AFd+wl0DA+6bLEoQroOEOCdRJQHR6B2g2b6q0uw9dM/TofVC?= =?us-ascii?Q?jiQk0N8pIYaOf8COPPHTRVwUt4/16Gr3fgFZvGjabbfiwVbBpdswx/woOnC/?= =?us-ascii?Q?YtTvJyoDTZW1Ww8umimg/2JHP1t6a3XfR+qUqRM1kRasbdDLW2NkWH7QThf3?= =?us-ascii?Q?lxNvHsjMmC8v1gsRdFx31wKie4QTJdhTpUQdM1HjzD+hml6pGx9+BVBCQZg9?= =?us-ascii?Q?D5HtCU+s0vhSb69guMySlQe+I2xViDKL7SqXzsnSPzdwg2kqpdezpbfu3ypS?= =?us-ascii?Q?YPTzHTzEXdO56O3lDMd9/l6+DlHgT2xv1j61gdOmgmSoGx614744uZT+phBT?= =?us-ascii?Q?3TY5SUp9H+XH6pdgospXoV3VepVzEBGgqfGhLVUxVwYDytrC7c2ZZ5khpLyn?= =?us-ascii?Q?6gf/1UFNA5BzCR3t/o3cIUpxb9EgZBfs/OXvuZE4l0CTkNIlI/fGZdphhArI?= =?us-ascii?Q?wCf70kUGHA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3288.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5db2806-f39f-4ebd-72d8-08d9e491e48b X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2022 08:15:50.3964 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kQjTzi07uYX4UX1Ffup2k1BKsIPFq9Ru9rblYGxCNU810dBuyth4sp+rTh6cbSoPQsxQfSnbHMNBUgxXwgZuTcZpu0tg9bny+nt3Tfysozs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4053 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jan 2022 08:15:57 -0000 > -----Original Message----- > From: Tom Tromey > Sent: Friday, January 28, 2022 7:30 PM > To: Nils-Christian Kempke via Gdb-patches > Cc: Kempke, Nils-Christian > Subject: Re: [PATCH 1/2] gdb/types: Resolve dynamic properties of pointer > types. > = > >> + if (top_level && > >> + (type->code () =3D=3D TYPE_CODE_REF || type->code () =3D=3D > TYPE_CODE_PTR)) > = > In the gdb style, operators like "&&" go on the start of the > continuation line. > = > Tom Hi Tom, Thanks for looking at this. Yes - that's indeed correct I'll change it and keep it in mind for a possible v2 of this patch. Did you have a chance to look into this more deeply/have any more comments on this patch? Cheers, Nils Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928