From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by sourceware.org (Postfix) with ESMTPS id 28D253857C43 for ; Tue, 25 Jan 2022 07:45:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 28D253857C43 X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="245078643" X-IronPort-AV: E=Sophos;i="5.88,314,1635231600"; d="scan'208";a="245078643" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2022 23:45:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,314,1635231600"; d="scan'208";a="532342345" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga007.fm.intel.com with ESMTP; 24 Jan 2022 23:45:26 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 24 Jan 2022 23:45:25 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 24 Jan 2022 23:45:25 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 24 Jan 2022 23:45:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YauVX+41G712cCmb4bc40iYujYi69ZfRQOp+wHH1HCYeict19H+5EzNAUnkPt01TOhnWW/rz3Nm4B5hOWoEbPN54WQwToG1SLvT+LSWFi5TsUUznG+iYf+Q65nS8oc7wPBNQMBbo5dm5RpXFdXwr9RsocQ0DmW0A47krQwLBjjuW73aqLnrNbiJFvX0RU8fXz4NVnsIPSdBKdJOBmEJOruhbT4dUqPmniKfvMkPHVVMgW/XAedIQctYPRPLuAx91x0OFgJwiM7XK7Rvj3lcv6pmqFav2X/wsUqzXkCu/h1tmxUs31YXop/F+Raq4WMxlxNDhELuXkQdWxKWIuCwV2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SiDrv0MWJJ6OuTJEQOatWja9HT+1v4wq/2nMCjbyUc8=; b=iPVtXk3iuuxVaGNFWqHHp0oEc6iOlVxnFwrY1PxOI6zkqlSScbJB5y7Gr1+ubd1MV6d/v97VuKfHGk9IP8IBeKBuWs32PoJpFT5l6vDyj9JlaHo5hzZbkg+CP0OKPv/OMFR5SiFVkOKNs7CALRPZRAZvbk1rFN62zHNSfO4wcFZzPgmjrvmiIDuxcjusIg+9CCf2ASM/l63/GJJDUWkca0FHSsCTUpj0JjOwudRXAEitYWy+t7/TBaabiGAmRfCMVOPT9Pa+4EYMPgu9md0kmATjg2JLCpcBuk6ltA2Ems2Q91+GjjViJWQsDOfn7HXFmRBHm3JiRXGvJkB48mLWdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BYAPR11MB3288.namprd11.prod.outlook.com (2603:10b6:a03:7e::33) by BY5PR11MB4055.namprd11.prod.outlook.com (2603:10b6:a03:18b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Tue, 25 Jan 2022 07:45:24 +0000 Received: from BYAPR11MB3288.namprd11.prod.outlook.com ([fe80::740e:38d7:a41b:e462]) by BYAPR11MB3288.namprd11.prod.outlook.com ([fe80::740e:38d7:a41b:e462%6]) with mapi id 15.20.4909.017; Tue, 25 Jan 2022 07:45:24 +0000 From: "Kempke, Nils-Christian" To: Joel Brobecker , Andrew Burgess CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v2 1/1] gdb, testsuite, fortran: adapt info symbol expected output for intel compilers Thread-Topic: [PATCH v2 1/1] gdb, testsuite, fortran: adapt info symbol expected output for intel compilers Thread-Index: AQHYC5Wo3BqwllCIEUG32E1AuRmQIqxtto+AgAKz0YCAAvydUA== Date: Tue, 25 Jan 2022 07:45:24 +0000 Message-ID: References: <20220117113005.3867815-1-nils-christian.kempke@intel.com> <20220117113005.3867815-2-nils-christian.kempke@intel.com> <20220121164933.GL622389@redhat.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: daa6077d-e366-4257-4974-08d9dfd6a581 x-ms-traffictypediagnostic: BY5PR11MB4055:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QQWMDvff2KyWm4XFCdgcxTOQlMYkC8MkF6iLMzqsuMtMNtIPywmiQQGkOJ/c/6+okPi3qKMCQh6ZBRoYG/TR0wTfz0O7zeTkaa0CN//5hRkdPSyUVwpNLl15pmvE2u+aZVI1pu/vzlCni3vEyNI787lnW3Jy53gzdqtwOjI2zDKfslNxBq6sSWL2qAGx/NrVyK/AfziTGNoAQ5NX8D0ffjuC+3JupD0SqvDt+/uaJub0dimW6Tfqk5I3CylqB5kSc6qLpzZAIOXw0Y2/QZff067bWYVLxl0JMudOYN3lgypaWA/4c72OI/XA42RQMfdMpQ8eQmV6karTHppxXVPsvp7SWVp2T0kc/heevkXte6IEf01NYgPs4X8UwhG4vQPk/8x261K9XknN46M6ctTuEcHWaceyeQmg3Xg4Lp2AfSCv/zz3yfN44MD6twAfikpth3z6ygQIA0RzyRvuf0+9dB1e9ei/Kb59tVeq7Vk+mG7ZFDnodZnste8Ky+wWjqr0u8md+9toa5ZAORohuKvpkoFbcGFIVEEyetCMRmN56eBDABoA1tebvez/FZUzZx0HGjzgsyTI3/Foyf9265JLZ+lvNKR6+18fgCIX07lex8x4HpsU7vAWWY6fX8kr/5847s6IMJfut4umyn5vvvxs9WSowJ3SQnryLj3peYm+A9Pa83Sy5JCSrmLwviQXvC3zhDa0QbnXq9BeAzJNqRXLk6WG1+KNoeieA296aCSsH8yGl5JVH01PsYIDADUenEdi4P2Bz5QblrYl6rvovmrc603/nUWN5noxcTQ5PPbleH4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3288.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38070700005)(82960400001)(83380400001)(71200400001)(66946007)(66476007)(66556008)(64756008)(7696005)(66446008)(316002)(2906002)(110136005)(4326008)(76116006)(8676002)(55016003)(38100700002)(33656002)(8936002)(84970400001)(122000001)(52536014)(508600001)(86362001)(53546011)(6506007)(5660300002)(9686003)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?plUOHdFfRzCYJUhwc3+I7PRUkrOnzfcqgJa0gtEfz8sY+Ts1tBZFgblJgx5d?= =?us-ascii?Q?i8iaQnPO55iIK0VKvJqBNzc+W44JJkA2R29G2SBtzWwFFN/4iKoK5fyOLD/8?= =?us-ascii?Q?CqdctTWy8lBoHxcG7Dcbj4KB7gCshx+17dEkd1FTgl/DdEr3Po4KdRY7hnoT?= =?us-ascii?Q?E/7wmdsNsXWxzK2sErTa1Mgsgj8shxuhoS/5oMXXMw/AK5VCun22q8TjUdIx?= =?us-ascii?Q?Ag4/y+w2oH98cAKptQL7zsaOZW19DA452WFMWliY2miDnRk4eX8ZH/MWKaGH?= =?us-ascii?Q?bG1lEFnd5G+YTcTDk8GtsVAodoRcWh6dILzpsKOBIC++aEH1ecmDgNqNnCu3?= =?us-ascii?Q?nlfqwKgl5GjNF7OBBLtoWBkUjB2lTudQccKS/4M+gNelsvMaS/BG0XWZP4JH?= =?us-ascii?Q?SbY1kMvsHcUp92jpPVmmXB0IEuiqGk+u3U0D876AOKXv8pNlq4iqWz3w2Hze?= =?us-ascii?Q?Bempuqf0p/5yQnjovfaeTpc2DLEV8/84YWatyG1vCl0xNpXju2hLRqU/sF4y?= =?us-ascii?Q?e+XWtHMNbYjmahAqQaRNkX8rHMP5OAzu0H+xzEkxGqgbmV4toHkS6Zz8xM/M?= =?us-ascii?Q?xZyS328Lg600lJxWFqua0NpL4lsPSA3Bi3s2ulSQ0MQv88pdWdM7ImJ6/Cz1?= =?us-ascii?Q?G4vnH4oXq1TyAMMC3Cwnxc20P1N2ciKMYKBIA83v81lFhug+qFDKiLRmBDf2?= =?us-ascii?Q?xg5io78jJNuFN9RrU6FenbGR2pEzr0fX1MLPaegtogGhaZm7Um2OCSu8PfgA?= =?us-ascii?Q?YS2luLxkXxDfiptZs/5pfZORdEZHDmUmwKeGVVX4TTl/x03+9hAax4XaGJLn?= =?us-ascii?Q?n/CQXbzbaJ45LOMUXUzOOvmfomDSRIiwNSqfwxEJThInX2DoOJVKl7AccOQJ?= =?us-ascii?Q?aCkz+abDt/tpdDI9oAanDnuyi74zmBRcs3c/uP4RTpjfRSmsTQgtaUPlSLjg?= =?us-ascii?Q?07hpowCdG/XyOcIbXifEk44BJIlIqBpbNqxVVU32PMp3OzEWcHyWicq4gPS1?= =?us-ascii?Q?VRC6CtnARologXqlol1Np7EADaw2HqZDPvqpVAlyYSWr8rnbD7VMyL3pW2bL?= =?us-ascii?Q?+WhVcWmZPjWd3xkvIXTGz0yeyYp8DDyQ5x8cvXh/O+Ugo9D5Y76gSzhCv6WK?= =?us-ascii?Q?9Cn8i1uFd1JzghYSOhWJg7TB3RZiiIUztZfY+S02sKu4pqwpIkOpNjhHHjcV?= =?us-ascii?Q?egspqy74HCnnUXzNDcbKUddLwMWKCK4bfdIzEEjw1XFmqdr3yTjeH5dKJSh8?= =?us-ascii?Q?sbBFoQ6/zmBsrbWeq2LNnh7x7sq8ZAHDWf2ECQT0nL9edS4vrac/JEFb+Q+u?= =?us-ascii?Q?sqTYkHZfA2AfYvdwFrknAnbli3ShdN9XwMEmOKZl2kSjrzot3MyRlfKIJbaq?= =?us-ascii?Q?/ctRecd9qmQKl0a3dSHUvfxWEvVN2bMrmTBz385BGsPqHCRHvLpWsH6zJLtG?= =?us-ascii?Q?CbaaSm8mHSvfRuInyv4BRepts645D+wTjTu+74pjqx/eWJBGfRT5B33AfX5+?= =?us-ascii?Q?unA9Bcrnxo1RyXb+sjijHd9eZENYkGpZ0plc7qSlf1wuBrUZiE7yIV6vpiSR?= =?us-ascii?Q?Tr/zYyPpBD9L9/T/lEsMox1OggpZlx3BPDq5EiapyHuZaIUW/wxtOG/TL79i?= =?us-ascii?Q?sDkjPkhXI0YgrmBDCinqdq2JSpftwhw2HvRIUj4CrsDTVZNDtAcOKMyKDgVe?= =?us-ascii?Q?9zqyC1VLzTG9FfoTkzFqjQQgW4LPTWjo6oG8Pk6r2yyV8ifORBrhar6ZDNAF?= =?us-ascii?Q?RiMKpk5tjQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3288.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: daa6077d-e366-4257-4974-08d9dfd6a581 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2022 07:45:24.0938 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZNlNkkb1ibwsEzAeVNU9JCwZAsBGhl/R3ZQpR98MXdGHAMqxyFCqX18qe9VGG7MlLrJv8mt4YLS3V6HusSeebHC/KQvfflo0AsMDX7yll4M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4055 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2022 07:45:30 -0000 > -----Original Message----- > From: Joel Brobecker > Sent: Sunday, January 23, 2022 11:06 AM > To: Andrew Burgess > Cc: Kempke, Nils-Christian ; gdb- > patches@sourceware.org; brobecker@adacore.com > Subject: Re: [PATCH v2 1/1] gdb, testsuite, fortran: adapt info symbol > expected output for intel compilers > = > > > Info symbol is expected to print the symbol table name of a symbol, s= ince > > > symbol lookup happens via the minimal symbol table. This name > > > corresponds to the linkage name in the full symbol table. > > > > > > For gfortran (and maybe others) these names currently have the form > > > XXXX.NUMBER where XXXX is the symbol name and NUMBER a compiler > > > generated appendix for mangling. > > > An example taken from the modified nested-funcs-2.exp would be > > > > > > ~~~~ > > > $ objdump -t ./outputs/gdb.fortran/nested-funcs-2/nested-funcs-2 | > grep \ > > > increment > > > 00000000000014ab l F .text 0000000000000095 increment.3883 > > > 000000000000141c l F .text 000000000000008f > increment_program_global.3881 > > > ~~~~ > > > > > > This mangled name gets recognized by the Ada demangler/decoder and > decoded as > > > Ada to XXXX (setting the symbol language to Ada). This leads to outp= ut > > > of XXXX over XXXX.NUMBER for info symbol on gfortran symbols. > > > > > > For ifort and ifx the generated linkage names have the form > > > SCOPEA_SCOPEB_XXXX_ which are not recognized by the Ada decoder > (or any > > > other demangler for that matter) and thus printed as is. > > > The respective objdump in the above case looks like > > > > > > ~~~~ > > > $ objdump -t ./outputs/gdb.fortran/nested-funcs-2/nested-funcs-2 | > grep \ > > > increment > > > 0000000000403a44 l F .text 0000000000000074 > contains_keyword_IP_increment_ > > > 0000000000403ab8 l F .text 0000000000000070 > > > contains_keyword_IP_increment_program_global_ > > > ~~~~ > > > > > > In the unmodified testcase this results in 'fails' when ran with the = intel > > > compilers: > > > > > > ~~~~ > > > >> make check RUNTESTFLAGS=3D"gdb.fortran/nested-funcs-2.exp \ > > > GDBFLAGS=3D'$GDBFLAGS' CC_FOR_TARGET=3D'icpc' > F90_FOR_TARGET=3D'ifort'" > > > > > > ... > > > > > > =3D=3D=3D gdb Summary =3D=3D=3D > > > > > > \# of expected passes 80 > > > \# of unexpected failures 14 > > > ~~~~ > > > > > > Note that there is no Fortran mangling standard. We keep the gfortran > > > behavior as is and modify the test to reflect ifx and ifort mangled > > > names which fixes above fails. > > > > > > Signed-off-by: Nils-Christian Kempke > > > > You might want to wait a couple more days in case Joel wants to follow > > up, but I think this looks good. > > > > If Joel doesn't get back to you, then feel free to push this next > > week. > = > Looks good to me too. > = > Just for the sake of completeness, one alternative could have been > to use gdb_test_multiple, I believe. But both are equally fine > for me. > = > = > Thanks both! > -- > Joel Thanks for the reviews! As I have neither a Sourceware account nor write access I'd kindly ask one of you to push the patch on my behalf. Thanks ! Nils Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928