From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by sourceware.org (Postfix) with ESMTPS id 6DF2C3858402 for ; Fri, 28 Jan 2022 13:28:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6DF2C3858402 X-IronPort-AV: E=McAfee;i="6200,9189,10240"; a="245959953" X-IronPort-AV: E=Sophos;i="5.88,324,1635231600"; d="scan'208";a="245959953" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2022 05:28:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,324,1635231600"; d="scan'208";a="536131060" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 28 Jan 2022 05:28:58 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 28 Jan 2022 05:28:57 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 28 Jan 2022 05:28:57 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 28 Jan 2022 05:28:57 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 28 Jan 2022 05:28:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N4TLXB+kXHxB+cgzKm1vFVKnFIUMqcdd0FQmy2yexFeZR+kyiBkAyvM/D0IBiH3HG27xAy19vGMMAsLVGKta/nV7S+diLjgy+s2BnYs8/fEnnhqnXJC8KTCa4TTKu8KoTFUZlzoXljaRvIaP0xuQJgUrAyYqkqKdTfxv7DM2ejQ9C7ib1cORIpGcbQc8p4Btwp9bULm1OTpqoqe5vS4gb103N/q3prFK44Y314YzNDt1dGotemjJbK7xpPXaEbiidSyAfbQaOhrx+K8XPRd/e7KVHGcoirl3xZ3S4Bmg+BjSVvP2T4ABKEk1/OpBMnN+pcE9YUQoIEruvcyM1fMooQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1aFxeRi3BdeTMW2wCITvgoZ/fJg6HR1CZR4eg0QYScw=; b=ilxSZ2kcSCCCJiP5zOvpvhm3fWS2aZtcshexQAeICsJZibSEaOltlWre+9u+VFLGF/jxOIk7OUk/YxyJp8sO4ZauvL9EOafPyEtFskaDgnom2fjHViKcvMtuf2P7T2VOKOGyZZACpnJ6cLvD7wF/UK2izCVUwJReEyAYjScSIB8FX+X0fX4jaqb0LgHY9Dm7KWQUmiFMzitveRq1zhnFnqxXBgktPILcsszu+tpgcoNevJACtpZipVOKHPIgYxkEMMvAvAl/m/N37j5668PLr2X737KsIgRpK6+Wpd7Sf1qwmYSklelwp8IQ7q5qPLYcCkZ6NuFn+gyFviSpDMyxKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BYAPR11MB3590.namprd11.prod.outlook.com (2603:10b6:a03:b2::23) by PH7PR11MB5886.namprd11.prod.outlook.com (2603:10b6:510:135::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.17; Fri, 28 Jan 2022 13:28:56 +0000 Received: from BYAPR11MB3590.namprd11.prod.outlook.com ([fe80::698d:2e18:3937:69ce]) by BYAPR11MB3590.namprd11.prod.outlook.com ([fe80::698d:2e18:3937:69ce%2]) with mapi id 15.20.4909.019; Fri, 28 Jan 2022 13:28:55 +0000 From: "Schimpe, Christina" To: Tom Tromey , Christina Schimpe via Gdb-patches Subject: RE: [PATCH 3/3] gdb: Remove workaround for the vCont packet Thread-Topic: [PATCH 3/3] gdb: Remove workaround for the vCont packet Thread-Index: AQHYCJFU0dPZtSYPYEKpyCWqMRs8+axi7JpJgBQd6hA= Date: Fri, 28 Jan 2022 13:28:55 +0000 Message-ID: References: <20220113152118.1465255-1-christina.schimpe@intel.com> <20220113152118.1465255-4-christina.schimpe@intel.com> <87tue6f6jn.fsf@tromey.com> In-Reply-To: <87tue6f6jn.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1d028a8d-453a-4e19-1acd-08d9e2622250 x-ms-traffictypediagnostic: PH7PR11MB5886:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Qn15PcGuuq89x+g+2upQr8df2/whWns5pCTE0X/8K3qdypdBoOTCJrluUODS+6xYelEIUkxZtyxIqHpbHidHo/QfSNZqgOxfLcg9jrbVw1dlQmitgHFRbDYiUZHox0HoCNAW9sSHHd0pz7QK/0B8uFqa1r63vNmv3b1ho4CGG6uaweizOO5vmZn1J9MasWqd5nWjMd38v1d8bUBx67bBRRQ0qbLpxe3Ixe8CFUGr5QnNf/8s1zP4UUg/hqDHExtxCL1wwJdNGZsdMRPN8A/juNxYqcC6miV2yg5F95riwqGILQsw+hZDZfSkvKC9uAfwqMPkD60gHZc/QpfCTa61s1Q8POLgz68IgxoePshf/YmS+BzP2ThVnyjg8Gx3I0zNqFKDw7MGeobd1plQClTpD5iLuX2bdw+4H+I8q0nRICp6XfWPY4hiDyQYZuTZZiracHcwOWV6P6gtdOai078mmmgb6+ZfEap5+WqHkGg0+hasQ05klpjH9WGKdjNMXREaRmKi/LVGhx/tI2t5l7Zp0oJRHj8cZPTDvL8VmM+ZyRSgxWalnRHZoRZowrtigOy0xQ2A/jI/DFk3AkLfipdh5Zs8+f/FUFa+Kw15+d2a7mt20mBiSgMvkAoi3QoefF4oygSlMPbNLQN5kL38qG5LBZ4cwTZwKfcGNvoUE7HF0s8zpZriIC/C/a5bnLme2j2rdKoW+BqvM4x4gwyybsqPHw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3590.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38070700005)(66946007)(52536014)(83380400001)(55016003)(6506007)(66446008)(71200400001)(316002)(64756008)(33656002)(7696005)(122000001)(110136005)(38100700002)(2906002)(9686003)(8936002)(76116006)(82960400001)(66556008)(26005)(5660300002)(508600001)(86362001)(66476007)(8676002)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EopHCeyaiwcI4d2yNA+pG00l6yksMhqP3ZyVVQCS/Lhw7Wqjb4yjtDJITLWy?= =?us-ascii?Q?xAhFbObReI9wm3h900XJD9zn9DdI65nuVfVKItN4RKhZDg0n/+EI3GR1MqVC?= =?us-ascii?Q?XbYPAG3ShkGlyCGY50vsq54G6WhBLTswF8U3RVYgIu2vTFsqWSmBiZkZwz1p?= =?us-ascii?Q?8KElcwv4tVj7rdbqT5F7bX5+C76+CafQlGWTn0h6EgUQddDShNJsHG7K76qF?= =?us-ascii?Q?HXWAl/VhEDe1EpZRTP/So7QEMlViyUcFUdhPdcaM+pGUhI1Jtb4Aiir3zSHQ?= =?us-ascii?Q?mHrzm5yWcmjuUr5ymC3k+zpYYuFN0qEy4pYCJ6upRH3xgHS7RCA2J1f8JV43?= =?us-ascii?Q?ur4dOuljX91YuDALIk5RqzW8idl9/mf6oYCdCzM88Drek8AysHxzpyVagbNC?= =?us-ascii?Q?rNyy5cGJdIVrus00I3PkE9/rBIVr9i/Jf/QI0h0AbiCYyZZ7bA3+RhXzLP3z?= =?us-ascii?Q?WShXA48CLR+2bJZ9Le9KwToqwOgOzHFuZqJ8v9VPc9JAlrEKRnkGQXgL9ksF?= =?us-ascii?Q?KLLNCItFeiJ5LudopfO7LnPQr0bAT3mBSM1FtUI4d7OavXPHmTcLitntB21L?= =?us-ascii?Q?lwATR3nAt/+LeDbbsaPTFTuHmTEnlqNSgOSDhKoFQgz0FNPbB6fcgSjARAZ3?= =?us-ascii?Q?CjYFSTy4A72BWYfas33hunPv6ykB90lfiXzDdtBE5kCDLyYyOsZCECJS/GZ8?= =?us-ascii?Q?wQw69WuZ8vk1zy8jMhSkQOtVY5qZCtoL0aHN3649QzWmvR9rMbt+nHk/gKQS?= =?us-ascii?Q?+xHM5PNlbVVbO/UhPXi88LOYZd/wIbRCW2id2Fd01x4d5shUGjN0W1TTWP0K?= =?us-ascii?Q?5E/9vfQp8PKRPHHaUPy7xH8juFLFqR9AOzStsisiWXFKZZPLGBrL4JMjpFD/?= =?us-ascii?Q?jEUmQQSZcK1l4i+sGfjluu6CWqhcceieU73bLGr/BIJDmlGD7U8+VR8cp6Xi?= =?us-ascii?Q?O9xTmBJUpSPtMO0MV0UPQHLg3MsbXax+FRJWnaAm4QSAjTbug0ZbVuouqgnd?= =?us-ascii?Q?84MfhYAB3voAZtjP8nx1vDS39m4OHEuBVmyrHuFG8ZhuL5DVtGTCQMR3WM1D?= =?us-ascii?Q?aiAdkuGE3EGiis6mLHo2aMmx3YiZmF6tAauvcKuU6jC+d3JKsbCJ7qODr1QN?= =?us-ascii?Q?UwBszf55pOAnd+VMof43jGbo8IHNXdMtjRTkY+94pv+xWJx5mqhxv7wb7sZM?= =?us-ascii?Q?xtNIE4VgFdYa2bEVsbyXQXqWmnugvEau+Wt6e1BC4QGlndF9CAPAgIOUcay6?= =?us-ascii?Q?jt5NJ5LR0YdEwevqDVnkOz6bAvSmLlJGLzab91TonfD8DMvByMPfrPn8X45V?= =?us-ascii?Q?nXk6FVLAZlaqdgWUiL7CSNbZrHWzhRj0x6WNsuQckkKBwC4Zw5FCIemhdCYF?= =?us-ascii?Q?2F1mf2ToIHW/LbN0pTpClZzyz1Z6fHtdHTIUxa6gvRQXrDlI/BpqL0Wy58j/?= =?us-ascii?Q?6abHTg8ugBi9rjqC4ywaBA3SiSOXPoPW91zj8MEZwX0cp0awKPiCndikaCAl?= =?us-ascii?Q?d9scBy4xt275/Ft6nnfbinE+HLvKjjJtmGp+/Q81mrvy7t6z5e1jFU6QnmuY?= =?us-ascii?Q?xcMNbwyuYR8YKkIPF5ZC7dyU6zYFKQWTItILmQHPy5vBoJ0wVuFvjzRIT8Dz?= =?us-ascii?Q?0nKLcVtbKP2q4lXbhyR79PupUmmeO98g4slKYxxPThCLxb+30LE4vehu25Aj?= =?us-ascii?Q?VZ9cEA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3590.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d028a8d-453a-4e19-1acd-08d9e2622250 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2022 13:28:55.9202 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FtOAb2P1dDTTCX7oMKgQh3IMjYWZhm17dhHTThuguR0IbmUvBsmZQN8vWjb9vUmFyKqeV01uJ6tRGq/IjKIT3KZbRphNIXIyCyixUYYY36I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5886 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 13:29:01 -0000 Hi Tom, Thanks a lot for your review. = > = > >> + /* Check vCont support and set the remote state's > vCont_action_support > >> + attribute. */ > >> + remote_vcont_probe (); > = > >> - if (m_features.packet_support (PACKET_vCont) =3D=3D > PACKET_SUPPORT_UNKNOWN) > >> - remote_vcont_probe (); > = > It seems like the new code should probably check whether the packet is > supported like the old code did, in case the gdb user disabled it using t= he > appropriate "set remote" command. With the current patch, we do not check if the vCont packet is enabled when the supports_vCont attribute is set for the target in the function remote_vcont_probe (). We do check if the packet is enabled, when the attribute is used later on. = To be consistent with the definition of the set/show remote commands in com= mit "gdb: Make global feature array a per-remote target array", we should proba= bly allow the user to enable/disable the vCont packet after the connection is m= ade for the current target. = In this case, we have to make sure that we check the vCont packet enabling every time the supports_vCont attribute is used. = I think for this approach, there should not be a check for packet support before the function call remote_vcont_probe (), because the user could enable the packet after the connection is made and then the = supports_vCont attribute should be configured correctly. So I don't think t= his patch removed any of the required checks for vCont support based on the = approach I described for this patch. But there may be other situations for which a check for vCont support is mi= ssing. = For instance, when the supports_vCont attribute is used in the function set_range_stepping (const char *ignore_args, int from_tty, = struct cmd_list_element *c) and potentially also other places in the code. However, I would prefer to address them in another patch. So in case the approach I described before sounds reasonable to you, = would the current version of this patch be acceptable? = Best Regards + thanks a lot in advance, Christina Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928