From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by sourceware.org (Postfix) with ESMTPS id CB3113858D37 for ; Thu, 20 Jan 2022 17:24:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CB3113858D37 X-IronPort-AV: E=McAfee;i="6200,9189,10233"; a="232768116" X-IronPort-AV: E=Sophos;i="5.88,303,1635231600"; d="scan'208";a="232768116" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2022 09:24:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,303,1635231600"; d="scan'208";a="622988596" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga002.fm.intel.com with ESMTP; 20 Jan 2022 09:24:03 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 20 Jan 2022 09:24:03 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 20 Jan 2022 09:24:03 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 20 Jan 2022 09:24:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cs3m0jgB597n5bks1wPZVsCnGhtLll08/Sj2MemWDda8UuLD8TVLM1gs0R9ZeW5jo9inNV5mg/dpAYJ6WtLL/JH/W/20vsIufhYW8T2aLs+ushlI156THxVdR+Ph1NNiKNyHMEfCz8iwtV1gr9IwexjEdO1At7rkW6uXmyE6FZs4JbWXPVTxF9yGA9WmXr6g+kTPXe8MrTL5Q/v7At4ibvsyriQ3M1EQVi5DXFeVo+octcCy1heV4E5ISpYq3UGJAAqoGwYmy0o9V1EDUQNROPpEQ1liUb9QeddZ0d2alaA8Kklacwl6KhJ7vBwz/Eir0mBa0W1lfsxT2sYOSTvz7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1by10YOJMfp6zB/iOogMBZsQvfrFtWok0QLsp30ldCg=; b=ACUAoQyfD/4Cz3xUWHnApnhRbbMGtfTQ/cT8BGNkZWYhZw7BfHEbuIYI2z9KWT2n1aICJm476N8wElnGNxu2f+dLXM9XJ5PH6B+YeDfdbqGNvIsYCoHkzLkKMYYlrKXfRW6BQO3oW/iU2UCjg2FA3CjUVBgyiZWBGCAsngR6vucdakNzwRz99wHIRcW78RyplR0C6GZMWdc9lSoow4uRdz6CC5DMAjhRF9aWqycIezcs52LY6K8opl7fJmwrg2NkspyQY/XLLqycejGQw65a6feauC8UJkUDI1PoV7hULREva6bTO7+oks33X3ZZpBgWaCdJWs64qf09P3qyySuOPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BYAPR11MB3590.namprd11.prod.outlook.com (2603:10b6:a03:b2::23) by CY4PR11MB0070.namprd11.prod.outlook.com (2603:10b6:910:78::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.12; Thu, 20 Jan 2022 17:24:02 +0000 Received: from BYAPR11MB3590.namprd11.prod.outlook.com ([fe80::698d:2e18:3937:69ce]) by BYAPR11MB3590.namprd11.prod.outlook.com ([fe80::698d:2e18:3937:69ce%2]) with mapi id 15.20.4888.014; Thu, 20 Jan 2022 17:24:02 +0000 From: "Schimpe, Christina" To: Andrew Burgess CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 1/3] gdb: Make global feature array a per-remote target array Thread-Topic: [PATCH 1/3] gdb: Make global feature array a per-remote target array Thread-Index: AQHYCJFKEtPP5y+PVkqrGhXpjHagW6xorHgAgAN56sA= Date: Thu, 20 Jan 2022 17:24:01 +0000 Message-ID: References: <20220113152118.1465255-1-christina.schimpe@intel.com> <20220113152118.1465255-2-christina.schimpe@intel.com> <20220118113032.GD622389@redhat.com> In-Reply-To: <20220118113032.GD622389@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7f3249dc-5c32-4018-a557-08d9dc39a6e3 x-ms-traffictypediagnostic: CY4PR11MB0070:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: W27F1nqgo8DFux3rW7z0fP7oVL1PTOC/9/npyHwL5v8xNDmc3jOX53iP77G4zVDA/Pi6UIxviRIzv5tIt5BAb5GQvdyerHLNM2doK/+Xt0xFLCD3AhoJtrPwm6BSMP2JTdJLKcz6uPuuygJb0QF9WuZRR3WAUqKz8JpvkObxLFFyjoywcbRj6DWPw7/2WpRMUlrGg4LwWf9R65w+VIcGv51sbT9jCe4WU+XdAsuAibGVq2vcHnzglvY9LUxr3xXFfChhHwaQueJxAugl6yEip2doZ4jIbTbge0jWqAuRRlaIxvg1TzivpjIE18Rm4aHWeMsOeYN7e4pGBmmNXFLXOzyeGn2FHgI9lPd4W+5AZfMrC+39bkaMuikO5x1wWf27iueHnQxjVBKMkYpSvi0/zz1ovvwmu6KuBCnHzoNq97inPUhAl0jySNftXLoi87iOY0yqq7uBcDBVixA1EIPDeZn67D0BbqD5sxP3nfT7Q8cZIAy0nUMJMZkZBW80Qoo6/llk1ajRI7NZqnC88pm55zk7uS5ESzjOKy59KeYSSdPLESOqIUAtt1DOXHkDll9mUKNhbtRr4h97DPXebje+yPQyHgR2aXrvAM62ofR6cWwUz8vGjyO4RrwHzRo4cdCfBMWVCpHj+BKXQbZhPwGXKS8znQHKmBWq4ZOp5mrSt95TYyf5HL8i6cpyrkT2XU8MX2YKk1ZPojOXeOKZE//iiQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3590.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66946007)(122000001)(64756008)(66446008)(508600001)(66556008)(316002)(66476007)(83380400001)(8676002)(55016003)(38070700005)(38100700002)(71200400001)(76116006)(8936002)(6916009)(4326008)(7696005)(33656002)(6506007)(186003)(86362001)(2906002)(5660300002)(52536014)(82960400001)(26005)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3CA+dGzWi1BCdUfFtQDv6CDjWQBOKHFSDUyu8KcZIGmMdNW0+XSKSym03lSD?= =?us-ascii?Q?GjlOmgGAUQQFKWSU6oc+zRfAErWPaVO197+fHJ8qZrGrQ4djhjseL/RzBLhB?= =?us-ascii?Q?URbY61xJ+NHiqFZ9/dP6XVvepRwAtS0yEWAJMLy2dT1aS3t8cerIW4qOzxp6?= =?us-ascii?Q?6eFaEw8D5TamzqY0GfI6OL4DX01N+XOQcHkCkkc2W16sX5S4Vn6YE66quzOk?= =?us-ascii?Q?sVsgDGF4nJixyWoC0oxtB2lkNb4n2uTlGCGuzOi/FkgkxFM+Lkl8x1YEPwXJ?= =?us-ascii?Q?x2Wj5+HBIw2liH2t63x83Qe1lwWO7c7qhgV3bIxs8IXI7zJ2x4glDXfdVQWl?= =?us-ascii?Q?OFdwo/IGXkC6M0Lbmjot8qyiIZ0tSH6icOIWQA9jPo5dqpiVDT+BnqStF2V0?= =?us-ascii?Q?IV/w20IM0lcDX0Rs0mGr7YaY08rYAThW0r/nJ4yFwZfghukuMtea+nxrFkyp?= =?us-ascii?Q?19mbWA+GFbVPVa4e/mWJiUsS+jVEcRIp3osFWEWYdOext4wY9Vqcq0YP//MU?= =?us-ascii?Q?pivssC/ScGBBVc1HfDSmTAnvILoEHHnq02eLoxK/BputDwtq871bHs9pTQGg?= =?us-ascii?Q?nh8Gq5kOcNsNqm+yJI50fVV4SmQOyFShDk4Nhve7ar3ySpALfE70i+YA5ofm?= =?us-ascii?Q?FyOSjZ9YVmG7J1FVvVBlEtyizevNeClcmf4RXVvTvKTFFBFltWDMddT4aBC/?= =?us-ascii?Q?cxhvMpXmY5GJclKN7Bfl3m5cRm3OB00TPlOKOjf15jPkGM4zZ/VljuNMcnkw?= =?us-ascii?Q?saepUSD7Tfrgthk/aRuUBmDUKoOAGiASxZ1N2MPpWPvWVF2MNePW2yMoWx/M?= =?us-ascii?Q?UanwncI4d8FiCY5jTG2dRZNYtcP2UWDRa/L/sJ2aY4UH7umkYU0gMpmhYPkL?= =?us-ascii?Q?I5XDe4yUea0GM1d6xu0YVivi4jjQ1VXL2VLqEVdUQgq9Va2gNhaWSbvEX719?= =?us-ascii?Q?Ok5r1h8R1Ro32ZvzoTK2+r0a9wmtVoJz3IOI+bwkw0R7pER9J4+S7dlXLpFZ?= =?us-ascii?Q?xAfmA/XhaYzDTqsE7zYgkAR+ftGuLp1xNACEFEEhpfHoMAV7KQqr6E4PHjlm?= =?us-ascii?Q?T7IgX6Gxt2Q8mG/amTKtioh7pqG5Y5oN1iFXeJnjwh3kLsNuvdTXkiOGl0DG?= =?us-ascii?Q?nMuTw3zaEKJy0lEwWeGAIdlWSZiD3HZwXufvEPE91q90w4bZGw5LeH3nkdGN?= =?us-ascii?Q?RkhndEd5bsXINNYkKqloJAE3z25XPrN1qNha022boEPQ+VQdugHvZ3Hio0jq?= =?us-ascii?Q?mIEkEdkru2MT+2hlckO6kQQRnU54ns6bbIrL/fNjZ7z/yqco5/vHJ6PEs5ZB?= =?us-ascii?Q?HJzshhROIZ5BDqO1Uf1B2Z7zFvqE0S7qVPjHE2uWf4R7umLh6tKodjM+bYx6?= =?us-ascii?Q?Wk0+rX63/XZutFfFXerBFY1f9hiGfaJM2d1bHXWdSBiEfeKmTURivp2ZP1nk?= =?us-ascii?Q?EE1ysuex8tBZQ9ljieAwFNGpDiilyq6FclLLcycfxSqZMz2YxzxwDzDUqk56?= =?us-ascii?Q?AsuHIh4ZjYJ47IoxyKFOo20P01ee0LW70fKqBrRH1bq6r0pVRGP14WM0BbAE?= =?us-ascii?Q?fkM6n/DVT6DJnTz4g30nmOOfwJZWqesuR/M4oRVRSvmBeTQjsMP8eMiww+Cp?= =?us-ascii?Q?izJkys7m16AyJ+71r7dKl5lCbPZCqWrIMaHOiTTv8A3sb2pWRkRY7ne3sAZY?= =?us-ascii?Q?qRq6Tw=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3590.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f3249dc-5c32-4018-a557-08d9dc39a6e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2022 17:24:02.0038 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CeMxjEKfo9S9/bjn8AzeAj6J1GJKjx5V+fa/+KH0mfeigVfy2YL0sujjn4iynhky7zyLUjUtm7FEAhU5L9DiO/piTMiTtDdUjp2ogn9hLX8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB0070 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jan 2022 17:24:08 -0000 Thanks for the feedback. > Could you update your examples to not use implicit values here > please. This just makes reading these that little bit harder for no > reason. Yes, you are right. I will update this. = > However, I do think there are some things we could do to make it clear > what's going on, I think that the string printed for 'show remote > PACKET-NAME' should be updated to reflect what it's showing, as in: > = > (gdb) show remote kill-packet > Support for the `vKill' packet on the current remote target, is "auto" > (currently unknown). > = > OR > = > (gdb) show remote kill-packet > Support for the `vKill' packet on newly created remote targets, is "aut= o". > = > Notice, I dropped the 'currently unknown' as that makes no sense when > talking about the future targets. > = > I also think we should have the set command print something to tell > the user what changed, so they can know if they messed up, maybe: > = > (gdb) set remote kill-packet off > Use of the 'vKill' packet for the current, and future remote targets, se= t to > "off". > = > OR > = > (gdb) set remote kill-packet off > Use of the 'vKill' packet for future remote targets, set to "off". Yes, that makes sense to me. I will adapt the set/show command prints, as well as all the tests using the set/show commands. = > = > This change absolutely needs a NEWS entry and also a documentation > update. > = > With one exception the rest of my feedback is basically: there should > be more comments added. I know that sucks, especially when working in > older files like remote.c, where the initial code is poorly commented > anyway, but for me good comments do help understand what the intention > of a field or struct is, so I think, when we change stuff, we should > take the opportunity to document what's going on. So... I also agree with the rest of your comments and will send a V2 for this soo= n. Thanks, Christina Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928