From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id DAE2F3858D37 for ; Thu, 20 Jan 2022 16:33:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DAE2F3858D37 X-IronPort-AV: E=McAfee;i="6200,9189,10232"; a="331744085" X-IronPort-AV: E=Sophos;i="5.88,302,1635231600"; d="scan'208";a="331744085" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2022 08:32:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,302,1635231600"; d="scan'208";a="765355983" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga006.fm.intel.com with ESMTP; 20 Jan 2022 08:32:13 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 20 Jan 2022 08:32:12 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 20 Jan 2022 08:32:12 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 20 Jan 2022 08:32:12 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 20 Jan 2022 08:32:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nje//tnlK+bqe7XK5unJLMrmCmeWR6V2Tf3KebaOnjyKoFREYXT9+tVSmxy+zGnsVvKJ2C3SPZ3S5LsF/TE+46f9OCgJpTu1030NmR93NtHFmQNVa2GuxfHAyl/Obl7udM0DnFQbdqrwBzWptB0GQxdSxlEAnza5hReh1LZ54OEoQcSpy7Ol3ZtwQ8oO/90nB1WDUFBJV4xwwolwZJhzdbWTB9bqglJswBzPQpsiO16RP0eQTjFTv+kyi1NV+rAspMQbcWLU+Gm0jeb3dxoFxS6GNs4SgNM+9mVNeiInPMiFLo7viNF8VuFBhaRaGVzdD1C6NUg3YQOmx41IpIRLIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=81tPj2IJW1FuBfGYSFwyuOuXc6H6JobydCnf9ZXBgNM=; b=I1eBSAaHCt05WhM/XX72CPag+Ev8vO6cy6lQm97nQ8C6P0Is/87RACSH83IbXfOdpvxR9ryssq01JmuOrx1lbfnxP/s2xwHthYr/Zs4z4XMz6Hjx5CQs+sFY58eDkQPwZ2hU1lfu7AVoMYUIFpg0Bc0H29xcypownJvP5F4DL28UimpU78WVF+eYsO3ix8kFq8iK27gTL+kTqTXhpEut39I0bPH1dh6Yvml2xJ6DoPxh99w5PZV4o9IQYPLbce1Ns7W8imq4tJS5+8TdWjd9hQCEWqPaDSaWSHPuYzKBjYV3JaInhemwUTkB9xSTL71CSuhvIV4mFvLuaj2kdhrx+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BYAPR11MB3590.namprd11.prod.outlook.com (2603:10b6:a03:b2::23) by CY4PR1101MB2070.namprd11.prod.outlook.com (2603:10b6:910:1c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.12; Thu, 20 Jan 2022 16:32:10 +0000 Received: from BYAPR11MB3590.namprd11.prod.outlook.com ([fe80::698d:2e18:3937:69ce]) by BYAPR11MB3590.namprd11.prod.outlook.com ([fe80::698d:2e18:3937:69ce%2]) with mapi id 15.20.4888.014; Thu, 20 Jan 2022 16:32:10 +0000 From: "Schimpe, Christina" To: Tom Tromey , Christina Schimpe via Gdb-patches Subject: RE: [PATCH 1/3] gdb: Make global feature array a per-remote target array Thread-Topic: [PATCH 1/3] gdb: Make global feature array a per-remote target array Thread-Index: AQHYCJFKEtPP5y+PVkqrGhXpjHagW6xi6UYUgAk56CA= Date: Thu, 20 Jan 2022 16:32:10 +0000 Message-ID: References: <20220113152118.1465255-1-christina.schimpe@intel.com> <20220113152118.1465255-2-christina.schimpe@intel.com> <875yqmglob.fsf@tromey.com> In-Reply-To: <875yqmglob.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5a8dc7c5-d0e8-4cd7-fca2-08d9dc32682c x-ms-traffictypediagnostic: CY4PR1101MB2070:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4KNMYgAdUEv1Aohjszs06cvn7FCWck1og4TxxsIzzMrRXWB+GNmn0qC58Fed5ISbDPZ3xZusbnWz2vc1XY3fbmRx49EWRLGK/Y5UEyC2/7okLlWWRf3rfuLr7rMDHbcwUdU+zFeSLHgWPZ78VSIepcC2xEkaLi94mn8rcNMZhGt6YcyY42k7qAXj7eYRe1V1K+edGRWpJnrhU+Kr1dktZf5v20EUYhxTmKbMzwdWPOV/0uKRUifs9aBdBk1gjWCJGgEueShnHH5d5RAT5dWbcBuTzTxK2HCMcG9n6HjPgPpFP4gnfRE7IdcxOJJci/QrouW+bx9fSpfJSOwa//XQ3ZptSUtcvdg8VWga97nqeXnY8R7towy2P7wctXQSdcIlZeShtfZs1jB3n9L1PUj3/5GWvDoM6yWR1I1NMbcQEHMvDEDINAwNaLk2hsuLHmhf+le3B/qAiKE9gnltht6aFIaQ+jrytl4hMLPlAf/+7PjwB3joqYakFN3+8mLVbYFa/E7IS/XXraDjUQ8iaOPMTHYVderalhq6BSN45Voq2Oe6/eJ/Kv1ckPs2nM9XZgyYGG9zBj6052iwthXFdAU1OSkeq+gavvc6FluSzxuc5ni14cokdg5XxA+iZdj5VNvTvFAZ9jWvzp7aguI5vf4yQ6Uh8oC4eY/GOPxvAATz/yuvUwcR/I/+kHzP2B1kSogAsnzWg4SB7A538R2WHSDxFBHlym6soqEYx4C2LDuau+sWqlfHH9TpPL6iJWPfZ4M2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3590.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(7696005)(71200400001)(66946007)(122000001)(8676002)(186003)(55016003)(38070700005)(76116006)(38100700002)(52536014)(33656002)(66556008)(110136005)(82960400001)(66446008)(5660300002)(64756008)(6506007)(8936002)(26005)(9686003)(316002)(508600001)(66476007)(86362001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6OmQdBIc+Vsktpym36edPH6h27WGqMS5CREjj1TBnHHranc/41B2OYqOL7Eh?= =?us-ascii?Q?J7c/Wao0SJqy3xGHH0yxHYgoGi/ByGNTJSgynuFSZvzWM3U00rXd7KuLF7ww?= =?us-ascii?Q?Pk7uomd0qHUISFipIrq+puwhgxKI/CfjRfPsBF7kxkhXXK9FVe91h0mH41MF?= =?us-ascii?Q?+R/qO2u3TnLRxpfY2UnEEJwtJ2kafaXWLas5AvzAv8vPHk8D4Cd7ZugHF3v1?= =?us-ascii?Q?vd7E0MfdXSmhJl1wIe8EGlXO68jodk+25Bkf6XHXoEmy9LSGAKtRkMttXFK6?= =?us-ascii?Q?FA89D4hcT+mP7zYHMzmeFUWZXcVmJ9pCmhdUfKhWmMWKCq+b9xh3XXvkdmAC?= =?us-ascii?Q?5hkbYtRsm87wAxIw+08Odu453BJqRe5XDh/MdbY5y5gAglLioScWddcnEH8B?= =?us-ascii?Q?w5AaYJK78w9WFgWQnwA2pvqPJMpWV2j3PU82IG1qXDz0liU7C5pXR50TjtsC?= =?us-ascii?Q?yqf+uUNS6VUFL9pDMZAyuXOY7pRe+531Clfj9CY26SuN+TDMmpv3OLULHkat?= =?us-ascii?Q?UiBrIhhrxA8lHp329dF1sr0ZDtNmErg+GKAnddZJKGeQgIf1XzgjVWO7XZKM?= =?us-ascii?Q?0APhIdSQQXRkXs8KLJNqiMbq48kM4tqDsf79dfvzJGtLhVlVsI6ft4B3BFuT?= =?us-ascii?Q?Yz9Wfofc3p2nwE7i4aEdH9FH2dljdb7yrZE9fXMmwfdMflnktN2jTijTwfT3?= =?us-ascii?Q?VoMxEiIcmLRlwkSq6uqyskdsnoR2IMhMFMVbc0ssuqp2exXdu2mZaet5Bke6?= =?us-ascii?Q?mx8568DeTSvzPddOuW+uFa7h7i98T47z4NaqhESQ2cGmKpH1lUgWFygxlGDe?= =?us-ascii?Q?c1Cxm9W5aExy7lTEdeQDWuMS3vqklOn8VL1iI/jAFlDMBS+dU8bVywSyde5D?= =?us-ascii?Q?jNDz2+F4k/GfZcCw4HX47p4Q1DvOMpyBy3AuPBuGgNi+zrsM8XQce97oV0Jd?= =?us-ascii?Q?2wSWnXAoK9MGaFFdPwPMIhwWPEIsX/JNKMw7WIyY9Jlz5MlodEBZmA0IgFzz?= =?us-ascii?Q?VVqSUoFWC/ZCAyVaQv8LbyAYcM0HU6IVvUG1TacR0XSIvgd1TEs6EHbKcTeo?= =?us-ascii?Q?9WBUaovGo+dEHhBM+znKrleNk7BrhIP5aJEKotyHXSA9Bpdsjn2SOUdfAWGg?= =?us-ascii?Q?3jghuRRpC5YYxZGKP/ea0suC0wHPdaKqDzgDRQT+eh/4X3H99lP6wZftPyU6?= =?us-ascii?Q?e5lOI6sOh0aQODiFKRCvruWx90xaA3STtpPOhRZ7dnptDlCREviwRCpsbFl6?= =?us-ascii?Q?3jqQOgpBrSEwnraoiIcXJDs+IE6JYv/ca42YKGTl5r+du2GSlre1yWmvAVaI?= =?us-ascii?Q?JDAqtwg344vRNOjtG4xiPLvqpyregetHPNGrQqyk2n1qpxMZOkutGvI1WtDy?= =?us-ascii?Q?pmKADbo4svbbHV8p8xAQ+Pg2VcqtUDMI1ovyuMqjWFNIamgeOrKQWcQAmyX2?= =?us-ascii?Q?AJNA9GiAm2LVb29v5R8Aja2Sgbxt1rIxZhC5kqCmUlG2h8PW9vqJ+fK4uQYC?= =?us-ascii?Q?It/oINO6C5wYjN5bT/ug1The2cqNBqSMA2tcDcBuvJuWoJBxFZtEbi9L2jj8?= =?us-ascii?Q?uwMGUInyW5/VxEUJMQLmNHUWkpDR9nXd85hBKL+bP0T1gsura2jWi/4fU4Y7?= =?us-ascii?Q?UcW9AqoSdrzbASFhqAAVG+lZLo4QRCRWinFWaW06yz6eKsNbvEt/VpxNdTnf?= =?us-ascii?Q?E6nThA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3590.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a8dc7c5-d0e8-4cd7-fca2-08d9dc32682c X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2022 16:32:10.2952 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N4Jwi2wExQxsYsommowpQn+hJkXqgkibjipy3dDlWsGLOsAgayozUOb8MAO6WnnMuZF4bGNm7SKna3xU5m15cylp5OKeFcptshGLoJinyBw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2070 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jan 2022 16:33:17 -0000 Thank you for the review. > >> + int remote_multi_process_p (remote_state *rs) const; > >> + int remote_fork_event_p (remote_state*) const; > >> + int remote_vfork_event_p (remote_state*) const; > >> + int remote_exec_event_p (remote_state*) const; > = > It seems like these methods don't actually need the 'remote_state *' > parameter. > = > >> + void reset_all_packet_configs_support (void); > = > New code shouldn't use "(void)", just "()" is fine. Also, normally if > we touch a function definition or declaration, we'll also remove a > 'void' if there is one. Yes, I agree. I will remove it. > The packet number can be passed in using the 'context' attached to the > command. See cmd_list_element::set_context and > cmd_list_element::context. > This is simple to do and would remove the need for this loop. > = > It's mildly annoying that this only accepts a pointer and not a scalar, > but it can either be cast or you could pass the address the slot in > remote_protocol_packets and then do some pointer math to reconstruct the > index. > = > The same applies to the 'show' command. Ah, thanks for the hint. I will use the 'context' and remove the loop. Regards, Christina Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928