Please find attached patch. It includes one more entry changed for DW_AT_type. I left another entry unchanged which has of type DW_FORM_ref_sig8 and seems to have some intended long value. Regards, Alok -----Original Message----- From: Simon Marchi Sent: Wednesday, February 10, 2021 7:06 AM To: Sharma, Alok Kumar ; gdb-patches@sourceware.org Cc: George, Jini Susan ; Achra, Nitika ; E, Nagajyothi Subject: Re: [PATCH] Correction of gdb.dwarf2/pr13961.S [CAUTION: External Email] On 2021-02-07 11:31 p.m., Sharma, Alok Kumar wrote: > Hi Simon, > > Do you have any more comments ? > > Regards, > Alok Hi Alok, Thanks for doing the indentation and adding newlines to split by DIEs, I think it's more readable like this. I noticed there are other DW_AT_type of form DW_FORM_ref4 that use hard-coded values. Could you convert them too to symbolic form? I think it's better to convert them, because it's easier to read the .S file this way, and it avoids any future breakage of the same type. Apart from that, the other attributes I see that are a reference to another DIE are DW_AT_specification and DW_AT_sibling, but you already converted them, so I think those DW_AT_type's are the only ones remaining. Thanks, Simon