From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 3F2F83858421; Wed, 21 Dec 2022 03:45:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3F2F83858421 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102f.google.com with SMTP id n65-20020a17090a2cc700b0021bc5ef7a14so865117pjd.0; Tue, 20 Dec 2022 19:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ltZDNarGms33x2WFJcMIXMWlcplWCbemIGzTPKwlUH8=; b=OZmhXd11oCsO7PA5lYW8A3r05bBHEG4+aj0Gm4ToXstQfj6JKmWIsDVGCcv6f+T3Ky +DWE85Bmdvc4HqZrim2Lq8zfC2Fkj0/2APbIXUY1ZTaGl8aTzzzqnXuK/GVMw3v5xRaE UHDk3icCe34lZJ81kLi8V4tk00Sy17mS4SU4UX54Ofy/fOOrkPgsmZh+axH6P2kSaBFz Jtg2LVKHpKpuJrqnVzNa5G3Yf2psmcGSBJqsLbME6Y1X4GhaqYHiHVTepwtMFN/vzm3X evCd5H1H0PsFoSbFBTdkfsz3JqNx2T8bT6TV0d4s8AK/A4siqz+deVOZDQd9hO6yNjAA AAog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ltZDNarGms33x2WFJcMIXMWlcplWCbemIGzTPKwlUH8=; b=s3OAVWjgR/rg/7aZ2ODbtHMtAWdpchoWYdO3Y/7u+3PKN7G24Z6VCiwWWiuM1YbV/x TzlhKKDPBhiOPlbQpfYa0Jc1Tgmt/HNu71sqC7y5SbLYKlrJKk14zOsM1p3NGGSnSxq+ mIJOBjQXmC0RzdJn6FhvDz3tpvk7h1l3fQYLZMHMB/9T5tqjiFMtU/mNjlO33+0EHa/l N7jIkDAvO970sn/UQ4jf+ld5rMM4S3Uu0M3RazqY9k8zaPIvPsR0xVig95+4ivVVbjV/ os0EJPCyuHywYBlqvB7jPjhFMCndQh8gC/wc/vjHmSNyrrULp4k2E7vpQGMkcFPOg0fT 9N2w== X-Gm-Message-State: AFqh2krvTDetCBX00ZNx0xxslz5u6j+YXwKYI4WoCwfWcUyn87HuuMFI MNYzjCWWMddBXZQWeo+hOCvEuc0aLxPIrcHfntw= X-Google-Smtp-Source: AMrXdXufnF8RFe0y8QTa5fx0oxJKI5LJgRO2GM6+qj4yBNLOO4Dpbcd29LOOflu0EQyENdqGpHzQymKm7iBDvnocDY0= X-Received: by 2002:a17:903:182:b0:189:84fa:e59d with SMTP id z2-20020a170903018200b0018984fae59dmr14702plg.119.1671594356215; Tue, 20 Dec 2022 19:45:56 -0800 (PST) MIME-Version: 1.0 References: <1668107159-16961-1-git-send-email-apinski@marvell.com> <877cyllx53.fsf@tromey.com> In-Reply-To: <877cyllx53.fsf@tromey.com> From: Andrew Pinski Date: Tue, 20 Dec 2022 19:45:44 -0800 Message-ID: Subject: Re: [PATCHv2] Use toplevel configure for GMP and MPFR for gdb To: Tom Tromey Cc: apinski--- via Gdb-patches , binutils@sourceware.org, gcc-patches@gcc.gnu.org, apinski@marvell.com, Jeff Law Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Dec 20, 2022 at 10:59 AM Tom Tromey wrote: > > >>>>> "Andrew" == apinski--- via Gdb-patches writes: > > Andrew> From: Andrew Pinski > Andrew> This patch uses the toplevel configure parts for GMP/MPFR for > Andrew> gdb. The only thing is that gdb now requires MPFR for building. > Andrew> Before it was a recommended but not required library. > Andrew> Also this allows building of GMP and MPFR with the toplevel > Andrew> directory just like how it is done for GCC. > Andrew> We now error out in the toplevel configure of the version > Andrew> of GMP and MPFR that is wrong. > > Andrew> OK after GDB 13 branches? Build gdb 3 ways: > Andrew> with GMP and MPFR in the toplevel (static library used at that point for both) > Andrew> With only MPFR in the toplevel (GMP distro library used and MPFR built from source) > Andrew> With neither GMP and MPFR in the toplevel (distro libraries used) > > I think it's fine to move forward with this now. > Thank you again for doing this. Just to double check this is an approval? Jeff, Just to double check this is still ok for gcc repo even if we are in stage 3? Thanks, Andrew Pinski > > Tom