From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6788 invoked by alias); 3 Jan 2015 22:55:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6727 invoked by uid 89); 3 Jan 2015 22:55:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-lb0-f169.google.com Received: from mail-lb0-f169.google.com (HELO mail-lb0-f169.google.com) (209.85.217.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 03 Jan 2015 22:55:27 +0000 Received: by mail-lb0-f169.google.com with SMTP id p9so16517627lbv.28; Sat, 03 Jan 2015 14:55:24 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.152.207.37 with SMTP id lt5mr83616824lac.66.1420325724081; Sat, 03 Jan 2015 14:55:24 -0800 (PST) Received: by 10.25.21.9 with HTTP; Sat, 3 Jan 2015 14:55:24 -0800 (PST) In-Reply-To: <5473A3D3.901@redhat.com> References: <5473A3D3.901@redhat.com> Date: Sat, 03 Jan 2015 22:55:00 -0000 Message-ID: Subject: Re: [PATCH/TopLevel] Fix compiling libgo with a combined sources From: Andrew Pinski To: Jeff Law , binutils , "gdb-patches@sourceware.org" Cc: GCC Patches , Ian Lance Taylor Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00028.txt.bz2 On Mon, Nov 24, 2014 at 1:32 PM, Jeff Law wrote: > On 11/22/14 21:20, Andrew Pinski wrote: >> >> Hi, >> The problem here is here is that OBJCOPY is not being set to the >> newly built objcopy when compiling libgo. This patch adds >> OBJCOPY_FOR_TARGET to the toplevel configure/Makefile so that when >> libgo is compiled OBJCOPY is set to OBJCOPY_FOR_TARGET. >> >> I noticed this issue when building an aarch64 cross compile on an >> older system where objcopy did not understand aarch64. >> >> OK? Bootstrapped and tested on x86_64 with no regressions. Also >> tested with a combined build for a cross compiler to >> aarch64-linux-gnu. >> >> Thanks, >> Andrew Pinski >> >> >> * Makefile.def (flags_to_pass): Pass OBJCOPY_FOR_TARGET also. >> * Makefile.tpl (HOST_EXPORTS): Add OBJCOPY_FOR_TARGET. >> (BASE_TARGET_EXPORTS): Add OBJCOPY. >> (OBJCOPY_FOR_TARGET): New variable. >> (EXTRA_TARGET_FLAGS): Add OBJCOPY. >> * Makefile.in: Regenerate. >> * configure.ac: Check for already installed target objcopy. >> Also GCC_TARGET_TOOL on objcopy. >> * configure: Regenerate. > > OK Committed to GCC and gdb/binutils repos now. Thanks, Andrew > Jeff > >