From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by sourceware.org (Postfix) with ESMTPS id 66E023858401 for ; Wed, 3 Apr 2024 17:08:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 66E023858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 66E023858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1034 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712164122; cv=none; b=xjTNaNISKXXTld/9J1JGwSIG2yxjElYMiQwVBywNeoKhHnqvX1GNQXaDFwdNR+ukiFJwnH1nWppjJeFdaqV0TK+JyrAQ+nNQUK05zPMM0JWJGEjacBov1dNUUlK5aKQlAQX898kDsaw9HUEtdIIzOIlmwKotXuoEiZdIqzm06Y0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712164122; c=relaxed/simple; bh=Ucpb+Mqi3/tJs5IumHuGB9Lol1RSDfmHkIwNmWcqqPA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=kUH1Xh3rzCWPoSA/x17aYAw5Y8qkgpDd4h7bV7gZNNv4ndMez0moyIbBsj6qgyRyDRQxDTnCnWvUeJweq2J5iku6c/1uwZI6hycBdknn4IAEg+XBORNhhfcUU7R3NXZ6pVMMSePdeI6RAX5quBk4jYallxkpo9c+VyrdeBCXBZg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-2a2a3e1d4f3so18022a91.0 for ; Wed, 03 Apr 2024 10:08:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712164119; x=1712768919; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WqeFkXBHl40iZH7JA5484fg7fIEKAt3DmNNz7zT7tAA=; b=U9xLPjskZn7J3jsw8zXf+vlJVfLtaPxGJqqbiYY2a9mBf83UKFNh1LzDDD0e3AawFG A08rOB+CZnOg9xf60x4OOl7SbuSQpRPs1aCxiBCVKmYpXRvbxxOH/DNUzEsRX3nq8DDc KZHtuvmQMUoWWZ80dda0jDvZBX4qxjmwfdI/d++LK+KKrqDfKBND6CY8vnpkWS3uu1xR i5lNwFU5rvr3RefQMoR+Yp6cAo9tgVJyuSR5vGOxjqZ6fzlBg8ObLe5uu54tC/ZcuclQ cg16wgBRiGB1/XPhc1R7xGsFbr+MAEpxFtcIaEso15MIuk0LCMsgXJ2adCS4y79PqDSH ZxZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712164119; x=1712768919; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WqeFkXBHl40iZH7JA5484fg7fIEKAt3DmNNz7zT7tAA=; b=wlFzGMGDBqY9UiAY87TP+iBB7QT1IA9Bh57IhSnh0Ne+JrwrBYn6jinMcwbWzgdS0q gJdy7rrRvE+y1ctX4+A4h14sGM0rRf/x75RrtuYIWTMhoIAfqcs0rwNfZw41PLJt7uNH rsg9WvZuGsqoipWxKO75ZhCeoh5uRDKeDxxUgmeFCnUIPtOvJQu+r/eLzab9qgdYz9hT RxpHaDQzuuefpibD1uTM/6uHqM2Kr8N5dOZ/zIs9m3pi+ae2EKRhxNJle/Tl5vwsbgZy UAPQtp3+ZgeVlFPNxkAQzNhKCGDuTVptCGcOlathYRaJO4ukFRfwuZN+wjrXgy6wHF2C fZeg== X-Forwarded-Encrypted: i=1; AJvYcCUNHJxbWY8QBoo9hSWctucsDIkzwxx2UVCYsOuHZfJknIUhFxrv5r+zk0UAA34hw3e6FOw32WLmSBJ5HH0cTk5IYQAwTpNghCXauw== X-Gm-Message-State: AOJu0Yw60YmDcwpqLmOtsNPiOMxdjKzfc9wYGc0WqHxVwUb29sQ3Akjw qHicomlggeYCpAR7xhn+HHeshgLLXIZa6BTh248m0wCkWf+uiADdRGRJ3xKbIo2IjhXda+6Tmaw VIhVPMEfSbVGEV4cfDRxm6g9GzTw= X-Google-Smtp-Source: AGHT+IEjnxyLsykdyPuJvHhV2hwm1znyLVSja55gMnVwHJdZLBHnCrjaElNr/natv/dsw/T15vXqHOg4d7rBARxQIS8= X-Received: by 2002:a17:90a:9a92:b0:29d:e70f:7240 with SMTP id e18-20020a17090a9a9200b0029de70f7240mr143975pjp.11.1712164119315; Wed, 03 Apr 2024 10:08:39 -0700 (PDT) MIME-Version: 1.0 References: <20240303164756.870514-1-lancelot.six@amd.com> <8734t0sn8d.fsf@tromey.com> <6689da3c-9229-4338-9cad-b3bbeb1bbecf@amd.com> <38c53217-76b5-4ec4-8235-3eb8ca021d2c@suse.de> In-Reply-To: <38c53217-76b5-4ec4-8235-3eb8ca021d2c@suse.de> From: Andrew Pinski Date: Wed, 3 Apr 2024 10:08:27 -0700 Message-ID: Subject: Re: [PATCH] gdb/compile: Use std::filesystem::remove_all in cleanup To: Tom de Vries Cc: Lancelot SIX , Tom Tromey , gdb-patches@sourceware.org, lsix@lancelotsix.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Apr 3, 2024 at 7:51=E2=80=AFAM Tom de Vries wrot= e: > > On 4/3/24 16:47, Lancelot SIX wrote: > >> > >> This broke the build for me with gcc 7.5.0, which apparently falls int= o > >> the category of "mostly implements C++17 but not std::filesystem". > >> > > > > Sorry about that, I=E2=80=AFhave sent > > https://sourceware.org/pipermail/gdb-patches/2024-April/207760.html to > > revert that change. At least, we know it is best to stay away from > > std::filesystem for now. > > > > I wonder if there is a case for conditionally enabling this. That would > ensure that the work is not lost, as well as used when using gcc >=3D8. Let me add even though support was added for GCC 8, the functions are in included in libstdc++fs.a rather than the standard libstdc++.so/libstdc++.a. It was added to libstdc++ in GCC 9. So if you add this conditionally, you either need to do a feature test that does a link too or have one that adds libstdc++fs.a if not found in the standard library. Thanks, Andrew > > Thanks, > - Tom > >