From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-133141-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3635 invoked by alias); 1 Sep 2016 04:21:15 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 3614 invoked by uid 89); 1 Sep 2016 04:21:14 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=EI_CLASS, info.abfd, infoabfd, 269611
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mail-lf0-f66.google.com
Received: from mail-lf0-f66.google.com (HELO mail-lf0-f66.google.com) (209.85.215.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Sep 2016 04:20:58 +0000
Received: by mail-lf0-f66.google.com with SMTP id 33so3504500lfw.3;        Wed, 31 Aug 2016 21:20:58 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:cc;        bh=iEjBsP3Ewn6bVFmiU6TIykJ4rkJIl37bpIRjspI7FIY=;        b=YALc1RTM9F0zdKb5DUzjzEw9j1nA9dCefliQqWHLOo7wm7kPY1lVPfmlX6k3prKmHJ         O458P6wJjHqJ06XvMwF1ALZlxOWoWdo6I6P7gQ4ZGw55v1/u+88+lddOt/jNnU9Fil1M         FiVpSzF1XO5T8IWC4a8JGFuUvXN4PUAtj0aXunoup85WWW/spOfXC4DiPjPw/3FkVI5/         m3FOvKdrdCww/sTNH+MGmO8v591ZAvnwzLfBwBTUzJ2SiYpPNgG5/CGY5fsPId4F38VB         BVi3D95XCz+xPfkwJ17hVupRKIXa9lAr+w6FoQ95bUWtKz7Yw4LeQ0dNPaxmeErh41AJ         BgjQ==
X-Gm-Message-State: AE9vXwNPQRHI3RrWnXeRKOeWhJkeufZPwXQWZFO1li5UwHEzNAiii1N0pmq6Pj2flzS83QzaFRdgvypiwU3kiw==
X-Received: by 10.25.17.70 with SMTP id g67mr4935831lfi.145.1472703656454; Wed, 31 Aug 2016 21:20:56 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.25.16.224 with HTTP; Wed, 31 Aug 2016 21:20:55 -0700 (PDT)
In-Reply-To: <mvminuiln0a.fsf@hawking.suse.de>
References: <1472516750-30743-1-git-send-email-apinski@cavium.com> <1472516750-30743-3-git-send-email-apinski@cavium.com> <mvminuiln0a.fsf@hawking.suse.de>
From: Andrew Pinski <pinskia@gmail.com>
Date: Thu, 01 Sep 2016 04:21:00 -0000
Message-ID: <CA+=Sn1nVghgmfwfkxhMpkwUSNac9TCFxkEPCwB=OPv4Jztisww@mail.gmail.com>
Subject: Re: [PATCH 2/3] Add ILP32 support to gdb.
To: Andreas Schwab <schwab@suse.de>
Cc: Andrew Pinski <apinski@cavium.com>, 	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, binutils <binutils@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2016-09/txt/msg00000.txt.bz2

On Tue, Aug 30, 2016 at 12:44 AM, Andreas Schwab <schwab@suse.de> wrote:
> On Aug 30 2016, Andrew Pinski <apinski@cavium.com> wrote:
>
>> @@ -2695,6 +2696,11 @@ aarch64_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
>>        return NULL;
>>      }
>>
>> +  if (info.abfd
>> +      && bfd_get_flavour (info.abfd) == bfd_target_elf_flavour
>> +      && elf_elfheader (info.abfd)->e_ident[EI_CLASS] == ELFCLASS32)
>> +    ilp32 = TRUE;
>> +
>
> Shouldn't this use bfd_arch_bits_per_address?

That does not work as bfd_arch_bits_per_address is set to 64 still.
The same is true even on x86 and powerpc.  We actually need to check
the elf header here still.

Thanks,
Andrew


>
> Andreas.
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."