From: Andrew Pinski <pinskia@gmail.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFC] Use address_from_register in dwarf2-frame.c:read_addr_from_reg
Date: Sat, 06 Sep 2014 22:34:00 -0000 [thread overview]
Message-ID: <CA+=Sn1nZK=NWY9Hhf-_bODZeU02m0HXSdHXe5YKoNvnJ-8vMig@mail.gmail.com> (raw)
In-Reply-To: <201408271221.s7RCL684028429@d06av02.portsmouth.uk.ibm.com>
On Wed, Aug 27, 2014 at 5:21 AM, Ulrich Weigand <uweigand@de.ibm.com> wrote:
> Andrew Pinski wrote:
>
>> I think this patch broke MIPS64 n32 big-endian support. We assert here:
>> gdb_assert (!gdbarch_convert_register_p (gdbarch, regnum, type));
>>
>> The convert_register_p code for MIPS does:
>> return (register_size (gdbarch, regnum) == 8
>> && regnum % num_regs > 0 && regnum % num_regs < 32
>> && TYPE_LENGTH (type) < 8);
>>
>>
>> Since the register size is 8 byte wide (MIPS64) and the type length is
>> 4 (pointer), we return true. In MIPS64, the registers are stored
>> 64bits but pointers are 32bits.
>>
>> Here is the code that is used by mips_register_to_value:
>> int len = TYPE_LENGTH (type);
>> CORE_ADDR offset;
>>
>> offset = gdbarch_byte_order (gdbarch) == BFD_ENDIAN_BIG ? 8 - len : 0;
>> if (!get_frame_register_bytes (frame, regnum, offset, len, to,
>> optimizedp, unavailablep))
>> return 0;
>>
>> *optimizedp = *unavailablep = 0;
>> return 1;
>
> Huh, I wasn't aware of that conversion. Note that for the register_to_value
> case, I don't actually see any difference to the default behavior; it's the
> value_to_register routine that's really special (because of the sign-extension
> in performs).
>
>> Is there a way to fix this in a target neutral way? (I might need a
>> way like this for AARCH64 ILP32 also).
>
> I guess it isn't too hard to support gdbarch_convert_register_p in that
> routine as well; I just didn't have any target to test on.
>
> Can you try whether something along the following lines works for you?
Yes this works for me.
Thanks,
Andrew Pinski
>
> Bye,
> Ulrich
>
> ChangeLog:
>
> * findvar.c (address_from_register): Handle targets requiring
> a special conversion routine even for plain pointer types.
>
> diff --git a/gdb/findvar.c b/gdb/findvar.c
> index 41887de..ba3dd4d 100644
> --- a/gdb/findvar.c
> +++ b/gdb/findvar.c
> @@ -764,11 +764,28 @@ address_from_register (int regnum, struct frame_info *frame)
> would therefore abort in get_frame_id. However, since we only need
> a temporary value that is never used as lvalue, we actually do not
> really need to set its VALUE_FRAME_ID. Therefore, we re-implement
> - the core of value_from_register, but use the null_frame_id.
> + the core of value_from_register, but use the null_frame_id. */
>
> - This works only if we do not require a special conversion routine,
> - which is true for plain pointer types for all current targets. */
> - gdb_assert (!gdbarch_convert_register_p (gdbarch, regnum, type));
> + /* Some targets require a special conversion routine even for plain
> + pointer types. Avoid constructing a value object in those cases. */
> + if (gdbarch_convert_register_p (gdbarch, regnum, type))
> + {
> + gdb_byte *buf = alloca (TYPE_LENGTH (type));
> + int optim, unavail, ok;
> +
> + ok = gdbarch_register_to_value (gdbarch, frame, regnum, type,
> + buf, &optim, &unavail);
> + if (!ok)
> + {
> + /* This function is used while computing a location expression.
> + Complain about the value being optimized out, rather than
> + letting value_as_address complain about some random register
> + the expression depends on not being saved. */
> + error_value_optimized_out ();
> + }
> +
> + return unpack_long (type, buf);
> + }
>
> value = gdbarch_value_from_register (gdbarch, type, regnum, null_frame_id);
> read_frame_register_value (value, frame);
>
> --
> Dr. Ulrich Weigand
> GNU/Linux compilers and toolchain
> Ulrich.Weigand@de.ibm.com
>
next prev parent reply other threads:[~2014-09-06 22:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 17:00 Ulrich Weigand
2014-04-16 15:29 ` Joel Brobecker
2014-04-17 12:18 ` Ulrich Weigand
2014-08-27 4:01 ` Andrew Pinski
2014-08-27 12:21 ` Ulrich Weigand
2014-08-27 18:15 ` Maciej W. Rozycki
2014-08-28 11:51 ` Ulrich Weigand
2014-08-28 12:37 ` pinskia
2014-09-14 14:35 ` Maciej W. Rozycki
2014-09-15 11:40 ` Ulrich Weigand
2014-09-06 22:34 ` Andrew Pinski [this message]
2014-09-10 17:06 ` [COMMITTED] " Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+=Sn1nZK=NWY9Hhf-_bODZeU02m0HXSdHXe5YKoNvnJ-8vMig@mail.gmail.com' \
--to=pinskia@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).