From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8476 invoked by alias); 25 Jul 2015 18:39:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8466 invoked by uid 89); 25 Jul 2015 18:39:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-ob0-f172.google.com Received: from mail-ob0-f172.google.com (HELO mail-ob0-f172.google.com) (209.85.214.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 25 Jul 2015 18:39:22 +0000 Received: by obbop1 with SMTP id op1so35096948obb.2 for ; Sat, 25 Jul 2015 11:39:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=NMttijJcpmPiNNz4QU41CdmHt3AvVcIiAP5K19g3Qzs=; b=c9EsIqdMYhON5P14Ybzu3PIauxVp+LlvVgyddWnkF6qOGph2DOgOT6p5W7sGU/wIss yHIReoBuV2AKG9bT1N/pc8Sl3YMGtDujoLPC2zFLk/e2GTe8ZhMq8S7EuEkJKbJIOJnr wUJoUwmqSnKAzmbbFg1o47a7lBm4idgjxKwbRieW+DIMopBWUExTWgae8qEqrCRWm4iE m3/BaZgixJwO9Ta0xSXpHUa4S0PONb9Qi4oOQoLtkRc3Mu62ztfGnq6CD1R+s54OqaJI tRPcsQKw7SmafjMBKCbvaNOhnBfM4HRU+7u7krzhpMaQgCEhHMmccTEwQnqeKMOpbTpo za8A== X-Gm-Message-State: ALoCoQmOn/SbuUzIVMRaeyuhA6kAxvhoYrKExBIDsFTbyrT+xUvK4LO8Pr6GqWjk09vO4FsWJ3So X-Received: by 10.60.56.2 with SMTP id w2mr20199729oep.14.1437849560345; Sat, 25 Jul 2015 11:39:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.56.202 with HTTP; Sat, 25 Jul 2015 11:39:01 -0700 (PDT) In-Reply-To: References: <001a11c301ba95cb5e051b62da63@google.com> From: Patrick Palka Date: Sat, 25 Jul 2015 18:39:00 -0000 Message-ID: Subject: Re: [PATCH 5/8] gen-pert-test: parallel build support To: Doug Evans Cc: Doug Evans , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-07/txt/msg00756.txt.bz2 On Sat, Jul 25, 2015 at 2:25 PM, Doug Evans wrote: > On Sat, Jul 25, 2015 at 9:44 AM, Patrick Palka wrote: >> On Tue, Jul 21, 2015 at 9:44 AM, Doug Evans wrote: >>> Hi. >>> >>> This patch adds parallel build support for perf testcases. >>> To use the existing machinery, GDB_PARALLEL now contains >>> the subdirectory in which to put the parallel builds. >>> >>> 2015-07-20 Doug Evans >>> >>> * Makefile.in (check/%.exp): Pass directory for GDB_PARALLEL. >>> (workers/%.worker, build-perf): New rule. >>> (GDB_PERFTEST_MODE): New variable. >>> (check-perf): Use it. >>> (clean): Clean up gdb.perf parallel build subdirs. >>> * lib/build-piece.exp: New file. >>> * lib/cache.exp (gdb_do_cache): Include $GDB_PARALLEL in path name. >>> * lib/gdb.exp (standard_output_file): Include $GDB_PARALLEL in path >>> name. >>> (standard_temp_file): Ditto. >>> (GDB_PARALLEL handling): Make outputs,temp,cache directories as >>> subdirs >>> of $GDB_PARALLEL. >> >> This patch seems to have caused a number of regressions: >> >> http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/1502 >> http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/1501 >> http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/1510 >> >> (possibly among others) >> >> Reverting this patch locally makes the regressions disappear for me, >> at least on x86_64-m64. > > I can't repro this. > It's odd that this patch would cause these particular regressions: > > http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/1501/steps/regressions/logs/regressions > > http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/1502/steps/regressions/logs/regressions > > Also, I don't understand this one: > > http://gdb-build.sergiodj.net/builders/Debian-x86_64-m64/builds/1420 > > I can imagine makefile hacking for the perf tests breaking normal make check, > but then I'd expect the damage to be far more extensive, but the patch > reported in 1420 cannot have caused those regressions. In this case, the regressions listed for build 1420 originated from build 1417: http://gdb-build.sergiodj.net/builders/Debian-x86_64-m64/builds/1417 The baseline for checking for regressions is not the build before, but rather it's a "rolling" baseline or something like that.