From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86290 invoked by alias); 17 Jun 2015 19:18:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86278 invoked by uid 89); 17 Jun 2015 19:18:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_20,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-ob0-f179.google.com Received: from mail-ob0-f179.google.com (HELO mail-ob0-f179.google.com) (209.85.214.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 17 Jun 2015 19:18:13 +0000 Received: by obctg8 with SMTP id tg8so39807755obc.3 for ; Wed, 17 Jun 2015 12:18:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=KQlCy7HoQT49e6XeJpYx6LHrwb4o/RiztiyM/XheCfs=; b=TWjTv1gdRqnT7IQungNM1Xxq/VisFlwSzz1SvQ1PMvcncDpQtZAUxCK+GTcHYDLJd4 /XtzgOtK9mLXG9xkFCCUNMKecnNujKNn9exAChGlmDaumGdX0MZjmlsZtIVQ3MoBCRIW IAooNPaKSdyoWLyxn0JhYzuP1Ei1U14bxK9BLC5ZX9cZZkk9G1iKQlvuN9PMD5fJ5EbA tsU/RGXI7TPYb27elwkPaCVe61jDh10kI7h/wrkG67Z6UwIOFBRtAy/t1VdlpiaVUfKB afcxxrAgVLaN4MyDj2yF1KnNATy9KWTb1wJqVUeohORzQPPwf7kUxi0cvgyNpf58yT6j /qiQ== X-Gm-Message-State: ALoCoQlKZxJ6S87MfLemeLNp5vGdSrRITccSkCJPvJqpqWIniIng1RQhhb9XEjdf+DAH3OEHnVfD X-Received: by 10.202.54.3 with SMTP id d3mr5269650oia.103.1434568691446; Wed, 17 Jun 2015 12:18:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.96.167 with HTTP; Wed, 17 Jun 2015 12:17:50 -0700 (PDT) In-Reply-To: <55683226.5050302@redhat.com> References: <1432293831-23599-1-git-send-email-patrick@parcs.ath.cx> <1432293831-23599-2-git-send-email-patrick@parcs.ath.cx> <55683226.5050302@redhat.com> From: Patrick Palka Date: Wed, 17 Jun 2015 19:18:00 -0000 Message-ID: Subject: Re: [PATCH 2/2] Tweak the handling of $GDBHISTSIZE edge cases [PR gdb/16999] To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-06/txt/msg00374.txt.bz2 On Fri, May 29, 2015 at 5:32 AM, Pedro Alves wrote: > On 05/22/2015 12:23 PM, Patrick Palka wrote: > >> + while (isspace (*tmpenv)) >> + tmpenv++; > > ... > >> + >> + while (isspace (*endptr)) >> + endptr++; > > Use skip_spaces/skip_spaces_const for these. > > Otherwise looks good to me. > > (I suspect that testing the interaction between setting > the history both from a .gdbinit and $GDBHISTSIZE would > call for merging the gdbhistsize-history.exp / gdbinit-history.exp > to a single file.) Committed. The test files would not necessarily have to be merged to test the interaction between $GDBHISTSIZE and .gdbinit. One may worry about code duplication by not merging them, but I think there would be code duplication either way unless you really refactor the tests. I think it would be easier to test the interaction inside gdbinit-history.exp since adding environment variable manipulation to gdbinit-history.exp is easier than adding .gdbinit file manipulation in gdbhistsize-history.exp. In fact, gdbinit-history.exp already has to manipulate the environment to unset GDBHISTSIZE. So adding an interaction test would only require a few lines of code. I'll do it. > > Thanks, > Pedro Alves >