Re: [PATCH 2/2] Use gdbarch obstack to allocate the TYPE_NAME string in arch_type

[Patrick Palka <patrick@parcs.ath.cx>]

On Tue, Jun 30, 2015 at 5:36 AM, Pedro Alves <palves@redhat.com> wrote:
> On 06/30/2015 03:28 AM, Patrick Palka wrote:
>> Since the type whose name is being set is now being allocated on the
>> gdbarch obstack, we should allocate its TYPE_NAME on the obstack too.
>> This reduces the number of individual valgrind warnings for the command
>> "gdb gdb" from ~300 to ~150.
>>
>> Tested on x86_64-unknown-linux-gnu.
>>
>> [ I have a few more patches on top of these that together bring the total
>>   number of valgrind warnings for the command "gdb gdb" down to ~30
>>   but they are more controversial than these two, and if these aren't OK
>>   then the rest definitely aren't OK.  ]
>
> Both patches look fine to me.  If this blows up for some reason, I guess
> we'll take the opportunity to add a comment explaining why these must go
> on the heap.  :-)

Heh, sounds good.  I will hold off committing these patches at least
until 7.10 gets released to avoid unnecessary breakage.