public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Patrick Palka <patrick@parcs.ath.cx>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: Patrick Palka <patrick@parcs.ath.cx>
Subject: Re: [PATCH 2/2] Tweak the handling of $GDBHISTSIZE edge cases [PR gdb/16999]
Date: Fri, 22 May 2015 11:57:00 -0000	[thread overview]
Message-ID: <CA+C-WL8WMQhgsF8+qxHM-vvWBbzDGfem3a18SwoJvq6wiVoK9A@mail.gmail.com> (raw)
In-Reply-To: <1432293831-23599-2-git-send-email-patrick@parcs.ath.cx>

On Fri, May 22, 2015 at 7:23 AM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> When GDB reads a nonsensical value for the GDBHISTSIZE environment
> variable, i.e. one that is non-numeric or negative, GDB then sets its
> history size to 0.  This behavior is annoying and also inconsistent
> with the behavior of bash.
>
> This patch makes the behavior of invalid GDBHISTSIZE consistent with how
> bash handles HISTSIZE.  When we encounter a null or out-of-range
> GDBHISTSIZE (outside of [0, INT_MAX]) we now set the history size to
> unlimited instead of 0.  When we encounter a non-numeric GDBHISTSIZE we
> do nothing.
>
> gdb/ChangeLog:
>
>         PR gdb/16999
>         * top.c (init_history): For null or out-of-range GDBHISTSIZE,
>         set history size to unlimited.  Ignore non-numeric GDBHISTSIZE.
>

Oops, this ChangeLog entry is not complete.  I will make sure to
complete it before pushing/re-posting.

  reply	other threads:[~2015-05-22 11:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 11:24 [PATCH 1/2] Read $GDBHISTSIZE instead of $HISTSIZE Patrick Palka
2015-05-22 11:24 ` [PATCH 2/2] Tweak the handling of $GDBHISTSIZE edge cases [PR gdb/16999] Patrick Palka
2015-05-22 11:57   ` Patrick Palka [this message]
2015-05-29  9:32   ` Pedro Alves
2015-06-17 19:18     ` Patrick Palka
2015-06-23 12:56   ` Yao Qi
2015-06-23 14:28     ` Patrick Palka
2015-05-22 12:30 ` [PATCH 1/2] Read $GDBHISTSIZE instead of $HISTSIZE Eli Zaretskii
2015-06-04 15:30   ` Patrick Palka
2015-06-15 14:54     ` Pedro Alves
2015-05-29 11:05 ` Pedro Alves
2015-06-17 18:19 ` Patrick Palka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+C-WL8WMQhgsF8+qxHM-vvWBbzDGfem3a18SwoJvq6wiVoK9A@mail.gmail.com \
    --to=patrick@parcs.ath.cx \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).