From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81262 invoked by alias); 4 Jun 2015 18:54:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81252 invoked by uid 89); 4 Jun 2015 18:54:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-oi0-f44.google.com Received: from mail-oi0-f44.google.com (HELO mail-oi0-f44.google.com) (209.85.218.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 04 Jun 2015 18:54:04 +0000 Received: by oifu123 with SMTP id u123so37884884oif.1 for ; Thu, 04 Jun 2015 11:54:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=KoNOp6Q5bh67xPJpU/E4Q6LOK8o72slL6Z4xil2E/TQ=; b=aXoWBIwuY5eERYTZoPKb01fFjWjnV2I2hImfybKfrXKYQN6s8joNNxPw9r4e1T8Nah BecoDDVKHqFWTqKlnvq1wrIB3mcuPYBb0dsjyq2xWS1wNbnw4vNojbQVRfjJp82iYyKH GdUUK/li6LgwAWLMoCVHsKSGzuP1jSG0hiYVC9uSIDCXS1/kRulV2H1xlvIoEfmXQ5xN Wg3pGDhUquMDoeoRsrfzx1GyT0tK1UkwfGacuPRnCAzmmdeRQr6t1pNlnJa/zF7Vyfij 3dIxZxLQmfv3a+QgsOzRhzI4fer1FMOCDov03o99OzaxZd5IjovFEzFhQvVAn+hqZRfX YZKQ== X-Gm-Message-State: ALoCoQmZbpQLIjFRmCiyXxRTGfUrmLE4GhlvkScD5ptJxFBH/jYoKfe9q0SjqbXJLaBitiro6q2v X-Received: by 10.202.225.65 with SMTP id y62mr31545258oig.78.1433444042478; Thu, 04 Jun 2015 11:54:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.96.167 with HTTP; Thu, 4 Jun 2015 11:53:40 -0700 (PDT) In-Reply-To: <83y4jzpgj6.fsf@gnu.org> References: <1433434918-30948-1-git-send-email-patrick@parcs.ath.cx> <83y4jzpgj6.fsf@gnu.org> From: Patrick Palka Date: Thu, 04 Jun 2015 18:54:00 -0000 Message-ID: Subject: Re: [PATCH] Add option to remove duplicate command history entries To: Eli Zaretskii Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-06/txt/msg00074.txt.bz2 On Thu, Jun 4, 2015 at 12:47 PM, Eli Zaretskii wrote: >> From: Patrick Palka >> Cc: Patrick Palka >> Date: Thu, 4 Jun 2015 12:21:58 -0400 >> >> This patch implements the new option "history remove-duplicates", which >> controls whether GDB should remove duplicate command-history entries >> (off by default). > > Thanks. > >> gdb/doc/ChangeLog: >> >> * gdb.texinfo: Document the new option >> "history remove-duplicates". > > This ChangeLog entry should name the node in which you made the > changes, as if it were a function (i.e., in parentheses). > >> diff --git a/gdb/NEWS b/gdb/NEWS >> index bbfb55d..411be32 100644 >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -123,6 +123,10 @@ show max-completions >> to avoid generating large completion lists, the computation of >> which can cause the debugger to become temporarily unresponsive. >> >> +set history remove-duplicates >> +show history remove-duplicates >> + Control the removal of duplicate history entries. > > This part is OK. > >> +@cindex remove duplicate history >> +@kindex set history remove-duplicates >> +@item set history remove-duplicates >> +@itemx set history remove-duplicates on >> +Remove duplicate history entries added during the current session. Before a > > Given the description below, this summary is slightly misleading, > IMO. Why not simply > > Keep in history of CLI commands only one copy of each command. How about I rewrite this section into: Keep in the command history list only one copy of each command. If a new command being added to the history list is a duplicate of an older one, the older entry is removed from the list. Only history entries added during the current session are considered for removal. This option is off by default. > >> +entry it finds. This option is off by default. > ^^ > Two spaces between sentences, please. > > The documentation parts are okay with these fixed. Everything else fixed. Thanks for reviewing.