From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1537 invoked by alias); 8 Jan 2015 14:10:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1522 invoked by uid 89); 8 Jan 2015 14:10:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-pd0-f175.google.com Received: from mail-pd0-f175.google.com (HELO mail-pd0-f175.google.com) (209.85.192.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 08 Jan 2015 14:10:24 +0000 Received: by mail-pd0-f175.google.com with SMTP id g10so11420054pdj.6 for ; Thu, 08 Jan 2015 06:10:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=DAHGyygRS+ec6arWJo9dZ50WVLPp2M4XjAyM7y6W2Z4=; b=e2MZXEp6iM7DTAVi85/VuYfA54ldg/TY3hTJRnZ/+W/orvTi9FOdbD228p8iKJO/w6 784E2J1lBMSqMh79FweWT0WPXcDJXhsldywJzjHvzyBkvnPYocC8nGQjeVwLo88eGJTp yI6HjHmTb48IcW0DxT29bIijyLiMmZB7bSQdpLiRun/17bCdifM6Cbdvv8PSr6C+WSnl CwW/dFkElx+WU3ZO3uHn5Ph1+xgrETaFjKdn6JTYy9PO8CdIeBSrNJZjD7kefxm66oYZ x2iv2TYSTxSSQee5iWOaKOZ2ky4Bp6rrmu2JMtaBdAl+iW4y2YS1qsLSDi8C0d3+Kd7c xr2A== X-Gm-Message-State: ALoCoQmeSiZrNhkOz7BDsRRApkbps8D3mgvTsI4gvi+rteVFDpfn8qPWnGO6MzeA8nAjJTvdh+fc X-Received: by 10.70.52.234 with SMTP id w10mr4712035pdo.50.1420726222672; Thu, 08 Jan 2015 06:10:22 -0800 (PST) MIME-Version: 1.0 Received: by 10.70.22.145 with HTTP; Thu, 8 Jan 2015 06:10:02 -0800 (PST) In-Reply-To: <54AE8BDB.3050100@redhat.com> References: <1420689048-23538-1-git-send-email-patrick@parcs.ath.cx> <54AE640B.3000701@redhat.com> <54AE8BDB.3050100@redhat.com> From: Patrick Palka Date: Thu, 08 Jan 2015 14:10:00 -0000 Message-ID: Subject: Re: [PATCH] TUI: rewrite tui_query_hook() To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-01/txt/msg00189.txt.bz2 On Thu, Jan 8, 2015 at 8:53 AM, Pedro Alves wrote: > On 01/08/2015 12:40 PM, Patrick Palka wrote: > >> If we use >> gdb_readline_wrapper to print the query and wait for input then the >> 2nd annotation will not be printed in a timely manner because >> gdb_readline_wrapper blocks until a response is given by the user. > > Can't we just cat the annotations bits into the query string > itself? IOW, make them part of the secondary prompt. I'm not sure because the annotations contain newlines, so (with annotations enabled) the prompt passed to readline would have newlines. I do not know if readline supports multi-line prompts. But IMO a consolidation of the custom TUI query hook and the default query hook is a quite separate endeavor. I think it should be left as future work. > > Thanks, > Pedro Alves >