From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96123 invoked by alias); 29 Aug 2015 12:59:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96108 invoked by uid 89); 29 Aug 2015 12:59:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-oi0-f53.google.com Received: from mail-oi0-f53.google.com (HELO mail-oi0-f53.google.com) (209.85.218.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 29 Aug 2015 12:59:50 +0000 Received: by oigk185 with SMTP id k185so37964746oig.2 for ; Sat, 29 Aug 2015 05:59:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=naes9bwxFwy8dyemZN/PryVh41rVmgnTR5bU3zYsF5U=; b=TNPO5s8FvaJHdNyb09qu1RoUld5xO0UzZtNxTZVz2EKaTovCr8ak23ew2u4NbyQY6q DzdWF6ipohZy3Hjpl5TtuYXGG0Q0sjJaxZKQY2zyp+DiOuq2CtIpLNC5H9t1SR6OWtAK gJPwXYBywyTWfnex7mCvPPdOg1qsYV+KOR0MpoihZfchVjd9S4Nz9JqkbJQuhf+cnSEi fyKx7j51sVGbXDlILdxPmt2nKVqSFo7EJsRFBZUf3SUtOoPAAt6VblsZzzAieHMm8Ppz NmgQ39rP0nfLUcyw2WO+JfqUshXC0Sz1/8VfXJOE/5coclQKBdHcES/bgCbG4atFLpUe 3gSQ== X-Gm-Message-State: ALoCoQkUriEZvzk+wE2uVoBQduGXvqoMqZkgQBrTOin79aNyeQAhCGm6N3Owd9nrquzUhgd/d1yL X-Received: by 10.202.69.4 with SMTP id s4mr8307384oia.63.1440853188691; Sat, 29 Aug 2015 05:59:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.115.105 with HTTP; Sat, 29 Aug 2015 05:59:29 -0700 (PDT) In-Reply-To: References: <1435631281-31970-1-git-send-email-patrick@parcs.ath.cx> <1435631281-31970-2-git-send-email-patrick@parcs.ath.cx> <5592631D.4020108@redhat.com> From: Patrick Palka Date: Sat, 29 Aug 2015 12:59:00 -0000 Message-ID: Subject: Re: [PATCH 2/2] Use gdbarch obstack to allocate the TYPE_NAME string in arch_type To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-08/txt/msg00832.txt.bz2 On Tue, Jun 30, 2015 at 4:04 PM, Patrick Palka wrote: > On Tue, Jun 30, 2015 at 5:36 AM, Pedro Alves wrote: >> On 06/30/2015 03:28 AM, Patrick Palka wrote: >>> Since the type whose name is being set is now being allocated on the >>> gdbarch obstack, we should allocate its TYPE_NAME on the obstack too. >>> This reduces the number of individual valgrind warnings for the command >>> "gdb gdb" from ~300 to ~150. >>> >>> Tested on x86_64-unknown-linux-gnu. >>> >>> [ I have a few more patches on top of these that together bring the total >>> number of valgrind warnings for the command "gdb gdb" down to ~30 >>> but they are more controversial than these two, and if these aren't OK >>> then the rest definitely aren't OK. ] >> >> Both patches look fine to me. If this blows up for some reason, I guess >> we'll take the opportunity to add a comment explaining why these must go >> on the heap. :-) > > Heh, sounds good. I will hold off committing these patches at least > until 7.10 gets released to avoid unnecessary breakage. Committed. Let's see if anything breaks.