From: Patrick Palka <patrick@parcs.ath.cx>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378)
Date: Tue, 30 Jun 2015 17:11:00 -0000 [thread overview]
Message-ID: <CA+C-WL9t6hLTzAENE+UopQFnrYYvEvYq+DgbEQxxow36FoAmug@mail.gmail.com> (raw)
In-Reply-To: <5592CCC7.5080101@redhat.com>
On Tue, Jun 30, 2015 at 1:07 PM, Pedro Alves <palves@redhat.com> wrote:
> On 06/30/2015 05:40 PM, Patrick Palka wrote:
>> [ I elected to go with making the print_frame_info_listing hook a no-op, since
>> it does not seem to regress anything.
>>
>> I noticed that "layout regs" was somewhat broken now that
>> tui_refresh_frame_and_register_information is called twice following a normal
>> stop: once in tui_normal_stop and then in tui_before_prompt. The second call
>> removes any highlights done to the individual registers during the first
>> call, because the function notices that the current snapshot of register
>> values is the same as the one taken during the first call. So effectively
>> register changes are no longer highlighted in "layout regs" since the
>> highlights immediately get removed.
>>
>> I don't think we should refresh register information at all in
>> tui_before_prompt since this observer is intended to only update frame
>> information following a call to "up", "down", "frame", etc. Only after the
>> inferior has run for a bit could registers have changed. So this patch adds
>> the parameter registers_too_p to tui_refresh_frame_and_register_information
>> to indicate wheher we should update registers too, and updates
>> tui_before_prompt and tui_normal_stop accordingly. ]
>
> Hmm, what about when the user changes registers with "print $rax = 1" etc.?
> Do we end up with stale contents?
Apparently not, thanks to our deprecated_register_changed_hook called
from value_assign. So many hooks!
next prev parent reply other threads:[~2015-06-30 17:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-27 2:35 [PATCH 1/3] Correctly initialize the TUI locator window Patrick Palka
2015-06-27 2:35 ` [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378) Patrick Palka
2015-06-27 2:50 ` Patrick Palka
2015-06-30 9:32 ` Pedro Alves
2015-06-30 12:16 ` Patrick Palka
2015-06-30 12:37 ` Patrick Palka
2015-06-30 14:08 ` Pedro Alves
2015-06-30 14:54 ` Patrick Palka
2015-06-30 14:56 ` Patrick Palka
2015-06-30 15:12 ` Patrick Palka
2015-06-30 15:47 ` Pedro Alves
2015-06-30 16:40 ` Patrick Palka
2015-06-30 17:07 ` Pedro Alves
2015-06-30 17:11 ` Patrick Palka [this message]
2015-06-30 17:32 ` Pedro Alves
2015-06-30 17:49 ` Patrick Palka
2015-07-01 12:40 ` Patrick Palka
2015-06-30 13:23 ` Pedro Alves
2015-06-30 14:03 ` Patrick Palka
2015-06-27 2:35 ` [PATCH 2/3] Be lazy about refreshing the windows in tui_show_frame_info " Patrick Palka
2015-06-30 2:32 ` [PATCH] " Patrick Palka
2015-06-30 14:27 ` Pedro Alves
2015-06-30 14:45 ` Patrick Palka
2015-06-30 15:11 ` Pedro Alves
2015-06-30 15:15 ` Patrick Palka
2015-06-30 16:51 ` [PATCH 2/3] " Patrick Palka
2015-06-30 17:26 ` Pedro Alves
2015-06-30 8:36 ` [PATCH 1/3] Correctly initialize the TUI locator window Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+C-WL9t6hLTzAENE+UopQFnrYYvEvYq+DgbEQxxow36FoAmug@mail.gmail.com \
--to=patrick@parcs.ath.cx \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).