From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22947 invoked by alias); 9 Jan 2015 22:23:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22934 invoked by uid 89); 9 Jan 2015 22:23:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-pa0-f48.google.com Received: from mail-pa0-f48.google.com (HELO mail-pa0-f48.google.com) (209.85.220.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 09 Jan 2015 22:23:24 +0000 Received: by mail-pa0-f48.google.com with SMTP id rd3so20945601pab.7 for ; Fri, 09 Jan 2015 14:23:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=Erz6Xs//6LVb6pu0G9JqDgBqiSj14kS/3D+DXvWeRPg=; b=LpSLX9wy/RMIPW0BQm7DOOqCGvZ8/tL/Csu36qxi523QL1ojbyWwNvyPZ20Ib6cNAt n77PmtiLA8MzxtW8RP6OmVBL5fgTQu8KDf0aW4iRGvy0Qp7OJieDEM+GEoDUYPa4rGT+ K9dkqXWCFsu9FZYWa6aPEIIw3zkUv+biyYQNPXpdbmpL7AzcpyFlnTdSZVx6vS8KWloj nrKKb7U+9p9cLZGBlepR+wgn13odoVQvL1rWCgGqPdAYF0n3IOmFt39FmfTrFBX3NuCE ESj0gvVilyqvmobllSXmy4MxsK1lnCEaRePMPxK8UmgZVIvixQtWDzU4uhmH8bIis7db f49Q== X-Gm-Message-State: ALoCoQkI88Hpe30W8qCsdYtoG6LdQZiV5y27Ai+r0ejFWNxPljS1LrRM3kyhZ+Eb2AxkSwUiqU1H X-Received: by 10.68.233.232 with SMTP id tz8mr26571343pbc.166.1420842203029; Fri, 09 Jan 2015 14:23:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.70.22.145 with HTTP; Fri, 9 Jan 2015 14:23:02 -0800 (PST) In-Reply-To: <54AE8ED4.70808@redhat.com> References: <1420678878-14065-1-git-send-email-patrick@parcs.ath.cx> <54AE71D2.6020301@redhat.com> <54AE8ED4.70808@redhat.com> From: Patrick Palka Date: Fri, 09 Jan 2015 22:23:00 -0000 Message-ID: Subject: Re: [PATCH] Don't munge yacc's #line directives To: Pedro Alves Cc: gdb-patches@sourceware.org, Jan Kratochvil Content-Type: multipart/mixed; boundary=047d7b33d634cb4a06050c3f9a60 X-SW-Source: 2015-01/txt/msg00241.txt.bz2 --047d7b33d634cb4a06050c3f9a60 Content-Type: text/plain; charset=UTF-8 Content-length: 1067 On Thu, Jan 8, 2015 at 9:06 AM, Pedro Alves wrote: > On 01/08/2015 12:48 PM, Patrick Palka wrote: > >> Here is the upstream automake patch that is probably responsible for >> making the sed expression in question obsolete: >> http://git.savannah.gnu.org/cgit/automake.git/commit/lib/ylwrap?id=b6359a5f310160c8a4a2e8e8c0105408412ce400 > > I find that a bit confusing, since the comment says: > > # We don't want the resulting debug information to point at > # an absolute srcdir. > > (the upstream master version still has the comment, though > reformatted). > > In any case, I think we've done due diligence already. > > Could you update the commit log with the new findings and > references, and please also include an before/after example > of a #line line? With that, the patch is OK. > > E.g., here's what I see, before/after your patch: > > -#line 36 "/home/pedro/gdb/mygit/src/gdb//home/pedro/gdb/mygit/src/gdb/ada-exp.y" > +#line 36 "/home/pedro/gdb/mygit/src/gdb/ada-exp.y" Attached is what I committed. > > Thanks, > Pedro Alves > --047d7b33d634cb4a06050c3f9a60 Content-Type: application/octet-stream; name="0001-Don-t-munge-yacc-s-line-directives.patch" Content-Disposition: attachment; filename="0001-Don-t-munge-yacc-s-line-directives.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i4q4r3kr0 Content-length: 3274 RnJvbSA2YmYwNDVjZDMyZDA3YWU1NWQ3ZWVjOGZmOTRiZDkzN2M2YmIyYmNl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXRyaWNrIFBhbGth IDxwYXRyaWNrQHBhcmNzLmF0aC5jeD4KRGF0ZTogU3VuLCAzMCBOb3YgMjAx NCAxMTo0NzoxNiAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIERvbid0IG11bmdl IHlhY2MncyAjbGluZSBkaXJlY3RpdmVzCgpUaGUgI2xpbmUgZGlyZWN0aXZl cyB3aXRoaW4gR0RCJ3MgYXV0b2dlbmVyYXRlZCB5YWNjIGZpbGVzIChlLmcu CmMtZXhwLmMpIGFyZSBiZWluZyBpbmNvcnJlY3RseSBtdW5nZWQsIGNhdXNp bmcgdGhlc2UgZGlyZWN0aXZlcyB0byByZWZlcgp0byBub25leGlzdGVudCBz b3VyY2UgZmlsZXMsIGUuZy4KCiAjbGluZSAzNiAiL2hvbWUvcGF0cmljay9i aW51dGlscy1nZGIvZ2RiLy9ob21lL3BhdHJpY2svYmludXRpbHMtZ2RiL2dk Yi9jLWV4cC55IgoKYXMgb3Bwb3NlZCB0bwoKICAjbGluZSAzNiAiL2hvbWUv cGF0cmljay9iaW51dGlscy1nZGIvZ2RiL2MtZXhwLnkiCgpUaGUgbXVuZ2lu ZyBoYXBwZW5zIGR1ZSB0byBhIHNlZCBleHByZXNzaW9uIGFkZGVkIGJ5IGNv bW1pdCA5NTRkOGNhZQp3aG9zZSBpbnRlbmRlZCBwdXJwb3NlWzFdIHdhcyB0 byB3b3JrIGFyb3VuZCB0aGUgZmFjdCB0aGF0IHlsd3JhcCBlbWl0dGVkICNs aW5lCmRpcmVjdGl2ZXMgd2l0aG91dCBhbnkgZGlyZWN0b3J5IGluZm9ybWF0 aW9uLCBlLmcuCgogICNsaW5lIDM2ICJjLWV4cC55IgoKU28gdGhlIHNlZCBl eHByZXNzaW9uIHdhcyBtZWFudCB0byBtdW5nZSBzdWNoIGRpcmVjdGl2ZXMg dG8gcmVmZXIgdG8KYWJzb2x1dGUgcGF0aHMgaW5zdGVhZC4gIEJ1dCB0aGUg YmVoYXZpb3Igb2YgeWx3cmFwIHdhcyBjaGFuZ2VkIHNvbWUKeWVhcnMgYWdv WzJdIHRvIGVtaXQgYWJzb2x1dGUgcGF0aHMgd2l0aGluICNsaW5lIGRpcmVj dGl2ZXMuICBBbmQgd2hlbgpvdXIgbG9jYWwgY29weSBvZiB5bHdyYXAgd2Fz IHN5bmNlZCBieSBjb21taXQgZTMwNDY1MTEyLCB0aGUgc2VkCmV4cHJlc3Np b24gaW4gcXVlc3Rpb24gYmVjYW1lIHVubmVjZXNzYXJ5LCBhbmQgaW5kZWVk IGhhcm1mdWwuCgpUaGlzIHBhdGNoIHJlbW92ZXMgdGhlIG5vdy1vYnNvbGV0 ZSBzZWQgZXhwcmVzc2lvbi4gIFRoZSBlbWl0dGVkICNsaW5lCmRpcmVjdGl2 ZXMgYXJlIG5vdyBjb3JyZWN0IHdpdGhvdXQgaXQuCgpnZGIvQ2hhbmdlTG9n OgoKCSogTWFrZWZpbGUuaW4gKC55LmMpOiBEb24ndCBtdW5nZSB5YWNjJ3Mg I2xpbmUKCWRpcmVjdGl2ZXMuCgpbMV06IGh0dHBzOi8vc291cmNld2FyZS5v cmcvbWwvZ2RiLXBhdGNoZXMvMjAxMC0xMS9tc2cwMDI2NS5odG1sClsyXTog aHR0cDovL2dpdC5zYXZhbm5haC5nbnUub3JnL2NnaXQvYXV0b21ha2UuZ2l0 L2NvbW1pdC9saWIveWx3cmFwP2lkPWI2MzU5YTVmMwotLS0KIGdkYi9DaGFu Z2VMb2cgICB8IDUgKysrKysKIGdkYi9NYWtlZmlsZS5pbiB8IDEgLQogMiBm aWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK CmRpZmYgLS1naXQgYS9nZGIvQ2hhbmdlTG9nIGIvZ2RiL0NoYW5nZUxvZwpp bmRleCAyZTk4MTZhLi5jODMwMDUzIDEwMDY0NAotLS0gYS9nZGIvQ2hhbmdl TG9nCisrKyBiL2dkYi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxMCBAQAogMjAx NS0wMS0wOSAgUGF0cmljayBQYWxrYSAgPHBhdHJpY2tAcGFyY3MuYXRoLmN4 PgogCisJKiBNYWtlZmlsZS5pbiAoLnkuYyk6IERvbid0IG11bmdlIHlhY2Mn cyAjbGluZQorCWRpcmVjdGl2ZXMuCisKKzIwMTUtMDEtMDkgIFBhdHJpY2sg UGFsa2EgIDxwYXRyaWNrQHBhcmNzLmF0aC5jeD4KKwogCSogdXRpbHMuYyAo ZGVmYXVsdGVkX3F1ZXJ5KTogUmV3cml0ZSB0byB1c2UgZ2RiX3JlYWRsaW5l X3dyYXBwZXIKIAl0byBwcm9tcHQgZm9yIGlucHV0LgogCSogdHVpL3R1aS1o b29rcy5jICh0dWlfcXVlcnlfaG9vayk6IFJlbW92ZS4KZGlmZiAtLWdpdCBh L2dkYi9NYWtlZmlsZS5pbiBiL2dkYi9NYWtlZmlsZS5pbgppbmRleCA1ZGFl M2U2Li44NmFiMWJlIDEwMDY0NAotLS0gYS9nZGIvTWFrZWZpbGUuaW4KKysr IGIvZ2RiL01ha2VmaWxlLmluCkBAIC0xODU4LDcgKzE4NTgsNiBAQCBwby8k KFBBQ0tBR0UpLnBvdDogZm9yY2UKIAkgICAgIC1lICdzL1woWyBcdDssKF1c KWZyZWVcKFsgXHRdKlsmKCksXVwpL1wxeGZyZWVcMi9nJyBcCiAJICAgICAt ZSAncy9cKFsgXHQ7LChdXClmcmVlJCQvXDF4ZnJlZS9nJyBcCiAJICAgICAt ZSAnL14jbGluZS4qeS50YWIuYy9kJyBcCi0JICAgICAtZSAicy9eXCgjbGlu ZS4qXClgYmFzZW5hbWUgJDxgL1wxYGVjaG8gJDx8c2VkICdzL1wvL1xcXFxc Ly9nJ2AvIiBcCiAJICA8ICRALnRtcCA+ICRACiAJcm0gLWYgJEAudG1wCiAu bC5jOgotLSAKMi4yLjEuMjEyLmdjNWI5MjU2Cgo= --047d7b33d634cb4a06050c3f9a60--