From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4660 invoked by alias); 8 Jan 2015 14:14:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4647 invoked by uid 89); 8 Jan 2015 14:14:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-pa0-f41.google.com Received: from mail-pa0-f41.google.com (HELO mail-pa0-f41.google.com) (209.85.220.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 08 Jan 2015 14:14:14 +0000 Received: by mail-pa0-f41.google.com with SMTP id rd3so12016748pab.0 for ; Thu, 08 Jan 2015 06:14:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=S9vB5f8Uqcx1EhFxsK7Y7UCinA4Z85EFa9TzesfzCQA=; b=AIdpjtNHfDy2Bm4FH3jeh0zmGjoo53NxOIpF5GkJlv21IyJMtjT00yRQRvxRuaYYov X0/qTeHrfmrPPWJjKiJ+/D3pQHhLUASqJVcODHlp1ssiaMffiqIqn9NAowaaQxu3D58t maF9duIVglc1it/nii7AsWlugKgLUjIi/okS/oeraUgHuQelweGdJfJJLaUA7HtDaprQ 6T0J7z7G5q04VjUE65ef3g9pX3ev47C8XqAyobaZ4Svxs7Eo4yMOYcFw0gcncuFAKlgd 1xoF68h/bNIo3Cjg6lP3M6iuWGHahwMMq1ZUzjY1r2cAa0Szco7vrSCjZNdkeIqZoXsz IS9A== X-Gm-Message-State: ALoCoQl6Pihpsd3xYU0aIK0kSq4LY8U2IdndcrY3aYX6dKXTJzS6FubO4uJnZl/LobfB7nHKRzA9 X-Received: by 10.68.167.36 with SMTP id zl4mr15057204pbb.83.1420726452804; Thu, 08 Jan 2015 06:14:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.70.22.145 with HTTP; Thu, 8 Jan 2015 06:13:52 -0800 (PST) In-Reply-To: References: <1420689048-23538-1-git-send-email-patrick@parcs.ath.cx> <54AE640B.3000701@redhat.com> <54AE8BDB.3050100@redhat.com> From: Patrick Palka Date: Thu, 08 Jan 2015 14:14:00 -0000 Message-ID: Subject: Re: [PATCH] TUI: rewrite tui_query_hook() To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-01/txt/msg00190.txt.bz2 On Thu, Jan 8, 2015 at 9:10 AM, Patrick Palka wrote: > On Thu, Jan 8, 2015 at 8:53 AM, Pedro Alves wrote: >> On 01/08/2015 12:40 PM, Patrick Palka wrote: >> >>> If we use >>> gdb_readline_wrapper to print the query and wait for input then the >>> 2nd annotation will not be printed in a timely manner because >>> gdb_readline_wrapper blocks until a response is given by the user. >> >> Can't we just cat the annotations bits into the query string >> itself? IOW, make them part of the secondary prompt. > > I'm not sure because the annotations contain newlines, so (with > annotations enabled) the prompt passed to readline would have > newlines. I do not know if readline supports multi-line prompts. > > But IMO a consolidation of the custom TUI query hook and the default > query hook is a quite separate endeavor. I think it should be left as > future work. And in the meantime this patch takes advantage of the existence of a custom TUI query hook to at least make queries within TUI to behave nicely. > >> >> Thanks, >> Pedro Alves >>