From: Patrick Palka <patrick@parcs.ath.cx>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/3] convert tui window names to lower case
Date: Thu, 09 Jul 2015 12:53:00 -0000 [thread overview]
Message-ID: <CA+C-WL_RL4dtGGtYgga4dNT93BX4v_J5-PHg-LWQ9C0yjX4GPw@mail.gmail.com> (raw)
In-Reply-To: <CA+C-WL_NZr0DDbJnMahi4CLJ+StnB7_Ogduzqei+xpT69--FtQ@mail.gmail.com>
On Wed, Jul 8, 2015 at 4:51 PM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> On Wed, Jul 8, 2015 at 4:37 PM, Andrew Burgess
> <andrew.burgess@embecosm.com> wrote:
>> This patch series converts the tui window names to lower case. The
>> window names are already lower case in the documentation, and the
>> recently added command completer for 'focus' reports window names as
>> lower case.
>>
>> The window names aren't actally shown in that many places, so this
>> change shouldn't be that big of a upset (I hope), plus all the
>> commands that take a window name already accepts both upper and lower
>> case.
>
> Cool, I thought about doing something like this too, after I added the
> "focus" completer.
>
> What about the occurrences of "SRC", "CMD", etc in tui-layout.c?
> These do not seem to be changed in this series but it seems like they
> should.
On second thought, never mind this concern. The occurrences of "SRC",
"CMD", etc in tui-layout.c are referring to layout names, not window
names, so they should not necessarily be replaced by the window-name
macros. Besides, it can always be done in a separate patch. So FWIW
I am happy with this series :)
prev parent reply other threads:[~2015-07-09 12:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 20:37 Andrew Burgess
2015-07-08 20:37 ` [PATCH 3/3] gdb/tui: Use cleanups to free string copies Andrew Burgess
2015-07-08 20:37 ` [PATCH 1/3] gdb: Convert TUI windows names to lower case Andrew Burgess
2015-07-08 20:37 ` [PATCH 2/3] gdb/tui: Define tui window names once Andrew Burgess
2015-07-08 20:52 ` [PATCH 0/3] convert tui window names to lower case Patrick Palka
2015-07-09 10:44 ` Pedro Alves
2015-07-09 12:53 ` Patrick Palka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+C-WL_RL4dtGGtYgga4dNT93BX4v_J5-PHg-LWQ9C0yjX4GPw@mail.gmail.com \
--to=patrick@parcs.ath.cx \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).