From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60497 invoked by alias); 9 Jul 2015 12:53:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60488 invoked by uid 89); 9 Jul 2015 12:53:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-ob0-f175.google.com Received: from mail-ob0-f175.google.com (HELO mail-ob0-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 09 Jul 2015 12:53:16 +0000 Received: by obdbs4 with SMTP id bs4so171096884obd.3 for ; Thu, 09 Jul 2015 05:53:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=Djsdna3VoR//Y5rjAQV7i6d+bgKjYYJRkOF40MJX52k=; b=C1ZhtuFgsFBWPUKF7zNnUhB0jgPy9KffEPGFZ0LanSbvKaWb+iMGOhl5d+ZF5w3yrq pf8QEVkzL7wMxV2y4tiky9ZAaNx/odjvxcGZDxusPE1PE2iRqqcXGjXbn2QoAyjmUwOA de7YIP76NRWMFx/krXSEdmBvS5ARNFAZuCQWKfWIN3ZoV/PtpyBzNhd/9YMtGMqKUk8X gS/Fpqheo2/AZvZynwNVCKzlaCdGUwB/kdMf7PqeMcVcFJWhXxtNCBit3RdFEQe6b2Na 2PuYjZI0MUk2n6VZzBk0gLMeT9AGK4XG54MgJ8jKm9cfk2Q+wcqjB5bs3sK528n513Yu WOSg== X-Gm-Message-State: ALoCoQnuAWqMKnF5ypAVEcYobMI6lXnpYOnv/jz9VywuA+5hdZR6RLwUeG2kjY/xCA7W4WZZvox5 X-Received: by 10.60.82.168 with SMTP id j8mr14961462oey.65.1436446395098; Thu, 09 Jul 2015 05:53:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.96.167 with HTTP; Thu, 9 Jul 2015 05:52:55 -0700 (PDT) In-Reply-To: References: From: Patrick Palka Date: Thu, 09 Jul 2015 12:53:00 -0000 Message-ID: Subject: Re: [PATCH 0/3] convert tui window names to lower case To: Andrew Burgess Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-07/txt/msg00288.txt.bz2 On Wed, Jul 8, 2015 at 4:51 PM, Patrick Palka wrote: > On Wed, Jul 8, 2015 at 4:37 PM, Andrew Burgess > wrote: >> This patch series converts the tui window names to lower case. The >> window names are already lower case in the documentation, and the >> recently added command completer for 'focus' reports window names as >> lower case. >> >> The window names aren't actally shown in that many places, so this >> change shouldn't be that big of a upset (I hope), plus all the >> commands that take a window name already accepts both upper and lower >> case. > > Cool, I thought about doing something like this too, after I added the > "focus" completer. > > What about the occurrences of "SRC", "CMD", etc in tui-layout.c? > These do not seem to be changed in this series but it seems like they > should. On second thought, never mind this concern. The occurrences of "SRC", "CMD", etc in tui-layout.c are referring to layout names, not window names, so they should not necessarily be replaced by the window-name macros. Besides, it can always be done in a separate patch. So FWIW I am happy with this series :)