From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id 57E4A3858CDB for ; Wed, 21 Sep 2022 19:52:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 57E4A3858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-ed1-x529.google.com with SMTP id a41so10353195edf.4 for ; Wed, 21 Sep 2022 12:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=LbQtH1ofFWk177AZpmyeDeL3dhtXX4W+7U1fpXUamtg=; b=hH9uQwS4TQkIsivWbWIIFMJjHchk5vtictfQD4RHcTCMui7sKonK+kQxRSJHanCv2V PAKQU10C271/gbxPxxfulPtbWxieii8G2BibqccUE2qQdM8EN4ao/2McB1zDatMVp9fJ BBWyo9nfuLz8Byn4ctGdIovG+8BmeUr555qQJFMFw4YMH+eCR8VHMelyZ41r/0xNj6oH O+93yVojkwscV+3kQ9JnCD1KmQCQI+K6or0/bJaWZoMEZiLRXIGfP2QL67GMHy3m0pAi 20oTr77deaSrmEGI/RwWzfWLh499C2cC5C9moDBFdsBA7Yce5IiT8z++b1Cd2n4i0sth nSXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=LbQtH1ofFWk177AZpmyeDeL3dhtXX4W+7U1fpXUamtg=; b=ZArLo0JGB1iJpNmZyFNhozjp3SJLwWMuAuxc8q86F4i3dsuGM+VNVV0dcisBLtY+Ez VMpNhps7/X+nj3t22FIp+oMxzw8NVz5+9K/Im/QHSA3pu/xYth8nd9wXKJnwxnYAS+Su AzKPa6EbWdNviM5jDlHkDdWNQioVOpG9IcrmdHEfavpcJunX31H81CuY+gubOUiRtTIU 0werauIvbWKq5GsGOZajuDTbbQjCNaZ2qjlqvti4xS4qTRTCjjv08dLiJKlpzjkJe7K2 gcHA8iCqwY9WzCHh2VC9jF1D7B1oESt2iA+aZkzwlNZK1QggDYF8CgRpFc2hZG9M+mdn UGNw== X-Gm-Message-State: ACrzQf2eF4y1SbEUKXojXg6arBeenyzUQcRk9TBD4aMzZsthNhHPEJ96 B5gk6Sbxg0CfafvacVvRELApqZWFa5DUk3iGla7JJx/goek= X-Google-Smtp-Source: AMsMyM7oqb8FTBjpB+lsb9PziUWvONpNqVfc2crctriEcrBkAcAy4PEipIHf88EBepEBLLanuayIE0I6jLY2wRiKdEQ= X-Received: by 2002:a05:6402:2804:b0:439:83c2:8be2 with SMTP id h4-20020a056402280400b0043983c28be2mr26887693ede.292.1663789940792; Wed, 21 Sep 2022 12:52:20 -0700 (PDT) MIME-Version: 1.0 References: <20220711175746.76137-1-hugues.delassus@sifive.com> In-Reply-To: From: Hugues de Lassus Date: Wed, 21 Sep 2022 12:52:09 -0700 Message-ID: Subject: Re: [PING^2] [PATCH] RISC-V: fix FRM register display mask value To: gdb-patches@sourceware.org X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2022 19:52:24 -0000 I see this issue has been fixed by Andrew, thanks! Please disregard my ping. Best regards, Hugues On Wed, Sep 21, 2022 at 12:34 PM Hugues de Lassus < hugues.delassus@sifive.com> wrote: > On Wed, Aug 3, 2022 at 11:45 AM Hugues de Lassus < > hugues.delassus@sifive.com> wrote: > >> Ping. >> >> On Mon, Jul 11, 2022 at 10:58 AM Hugues de Lassus < >> hugues.delassus@sifive.com> wrote: >> >>> The FRM register is 3-bit long, but the top-most bit was masked off for >>> display, resulting in incorrectly displayed values and format strings >>> when FRM >= 4. >>> >>> Tested on riscv64-unknown-linux-gnu target, with FPU support. >>> --- >>> gdb/riscv-tdep.c | 2 +- >>> gdb/testsuite/gdb.base/float.exp | 4 +++- >>> 2 files changed, 4 insertions(+), 2 deletions(-) >>> >>> diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c >>> index 69f2123dcdb..a3afab3b998 100644 >>> --- a/gdb/riscv-tdep.c >>> +++ b/gdb/riscv-tdep.c >>> @@ -1185,7 +1185,7 @@ riscv_print_one_register_info (struct gdbarch >>> *gdbarch, >>> "dynamic rounding mode", >>> }; >>> int frm = ((regnum == RISCV_CSR_FCSR_REGNUM) >>> - ? (d >> 5) : d) & 0x3; >>> + ? (d >> 5) : d) & 0x7; >>> >>> gdb_printf (file, "%sFRM:%i [%s]", >>> (regnum == RISCV_CSR_FCSR_REGNUM >>> diff --git a/gdb/testsuite/gdb.base/float.exp >>> b/gdb/testsuite/gdb.base/float.exp >>> index 62e8346928b..10c0692a976 100644 >>> --- a/gdb/testsuite/gdb.base/float.exp >>> +++ b/gdb/testsuite/gdb.base/float.exp >>> @@ -112,14 +112,16 @@ if { [is_aarch64_target] } then { >>> gdb_test "info float" "f0.*f1.*f31.*d0.*d30.*" "info float" >>> } elseif [istarget "riscv*-*-*"] then { >>> # RISC-V may or may not have an FPU >>> + send_gdb "set \$frm = 7\n" >>> gdb_test_multiple "info float" "info float" { >>> - -re "ft0.*ft1.*ft11.*fflags.*frm.*fcsr.*$gdb_prompt $" { >>> + -re "ft0.*ft1.*ft11.*fflags.*frm.*0x7.*FRM:7.*fcsr.*$gdb_prompt >>> $" { >>> pass "info float (with FPU)" >>> } >>> -re "No floating.point info available for this >>> processor.*$gdb_prompt $" { >>> pass "info float (without FPU)" >>> } >>> } >>> + send_gdb "set \$frm = 0\n" >>> } else { >>> gdb_test "info float" "No floating.point info available for this >>> processor." "info float (unknown target)" >>> } >>> -- >>> 2.35.1 >>> >>> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id 57E4A3858CDB for ; Wed, 21 Sep 2022 19:52:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 57E4A3858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-ed1-x529.google.com with SMTP id a41so10353195edf.4 for ; Wed, 21 Sep 2022 12:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=LbQtH1ofFWk177AZpmyeDeL3dhtXX4W+7U1fpXUamtg=; b=hH9uQwS4TQkIsivWbWIIFMJjHchk5vtictfQD4RHcTCMui7sKonK+kQxRSJHanCv2V PAKQU10C271/gbxPxxfulPtbWxieii8G2BibqccUE2qQdM8EN4ao/2McB1zDatMVp9fJ BBWyo9nfuLz8Byn4ctGdIovG+8BmeUr555qQJFMFw4YMH+eCR8VHMelyZ41r/0xNj6oH O+93yVojkwscV+3kQ9JnCD1KmQCQI+K6or0/bJaWZoMEZiLRXIGfP2QL67GMHy3m0pAi 20oTr77deaSrmEGI/RwWzfWLh499C2cC5C9moDBFdsBA7Yce5IiT8z++b1Cd2n4i0sth nSXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=LbQtH1ofFWk177AZpmyeDeL3dhtXX4W+7U1fpXUamtg=; b=ZArLo0JGB1iJpNmZyFNhozjp3SJLwWMuAuxc8q86F4i3dsuGM+VNVV0dcisBLtY+Ez VMpNhps7/X+nj3t22FIp+oMxzw8NVz5+9K/Im/QHSA3pu/xYth8nd9wXKJnwxnYAS+Su AzKPa6EbWdNviM5jDlHkDdWNQioVOpG9IcrmdHEfavpcJunX31H81CuY+gubOUiRtTIU 0werauIvbWKq5GsGOZajuDTbbQjCNaZ2qjlqvti4xS4qTRTCjjv08dLiJKlpzjkJe7K2 gcHA8iCqwY9WzCHh2VC9jF1D7B1oESt2iA+aZkzwlNZK1QggDYF8CgRpFc2hZG9M+mdn UGNw== X-Gm-Message-State: ACrzQf2eF4y1SbEUKXojXg6arBeenyzUQcRk9TBD4aMzZsthNhHPEJ96 B5gk6Sbxg0CfafvacVvRELApqZWFa5DUk3iGla7JJx/goek= X-Google-Smtp-Source: AMsMyM7oqb8FTBjpB+lsb9PziUWvONpNqVfc2crctriEcrBkAcAy4PEipIHf88EBepEBLLanuayIE0I6jLY2wRiKdEQ= X-Received: by 2002:a05:6402:2804:b0:439:83c2:8be2 with SMTP id h4-20020a056402280400b0043983c28be2mr26887693ede.292.1663789940792; Wed, 21 Sep 2022 12:52:20 -0700 (PDT) MIME-Version: 1.0 References: <20220711175746.76137-1-hugues.delassus@sifive.com> In-Reply-To: From: Hugues de Lassus Date: Wed, 21 Sep 2022 12:52:09 -0700 Message-ID: Subject: Re: [PING^2] [PATCH] RISC-V: fix FRM register display mask value To: gdb-patches@sourceware.org Content-Type: multipart/alternative; boundary="00000000000066f62b05e935480d" X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20220921195209.3hSp_K9AWSDDp1ZUDIjroDtJ6Y1zTAFyitxKWwWF8P8@z> --00000000000066f62b05e935480d Content-Type: text/plain; charset="UTF-8" I see this issue has been fixed by Andrew, thanks! Please disregard my ping. Best regards, Hugues On Wed, Sep 21, 2022 at 12:34 PM Hugues de Lassus < hugues.delassus@sifive.com> wrote: > On Wed, Aug 3, 2022 at 11:45 AM Hugues de Lassus < > hugues.delassus@sifive.com> wrote: > >> Ping. >> >> On Mon, Jul 11, 2022 at 10:58 AM Hugues de Lassus < >> hugues.delassus@sifive.com> wrote: >> >>> The FRM register is 3-bit long, but the top-most bit was masked off for >>> display, resulting in incorrectly displayed values and format strings >>> when FRM >= 4. >>> >>> Tested on riscv64-unknown-linux-gnu target, with FPU support. >>> --- >>> gdb/riscv-tdep.c | 2 +- >>> gdb/testsuite/gdb.base/float.exp | 4 +++- >>> 2 files changed, 4 insertions(+), 2 deletions(-) >>> >>> diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c >>> index 69f2123dcdb..a3afab3b998 100644 >>> --- a/gdb/riscv-tdep.c >>> +++ b/gdb/riscv-tdep.c >>> @@ -1185,7 +1185,7 @@ riscv_print_one_register_info (struct gdbarch >>> *gdbarch, >>> "dynamic rounding mode", >>> }; >>> int frm = ((regnum == RISCV_CSR_FCSR_REGNUM) >>> - ? (d >> 5) : d) & 0x3; >>> + ? (d >> 5) : d) & 0x7; >>> >>> gdb_printf (file, "%sFRM:%i [%s]", >>> (regnum == RISCV_CSR_FCSR_REGNUM >>> diff --git a/gdb/testsuite/gdb.base/float.exp >>> b/gdb/testsuite/gdb.base/float.exp >>> index 62e8346928b..10c0692a976 100644 >>> --- a/gdb/testsuite/gdb.base/float.exp >>> +++ b/gdb/testsuite/gdb.base/float.exp >>> @@ -112,14 +112,16 @@ if { [is_aarch64_target] } then { >>> gdb_test "info float" "f0.*f1.*f31.*d0.*d30.*" "info float" >>> } elseif [istarget "riscv*-*-*"] then { >>> # RISC-V may or may not have an FPU >>> + send_gdb "set \$frm = 7\n" >>> gdb_test_multiple "info float" "info float" { >>> - -re "ft0.*ft1.*ft11.*fflags.*frm.*fcsr.*$gdb_prompt $" { >>> + -re "ft0.*ft1.*ft11.*fflags.*frm.*0x7.*FRM:7.*fcsr.*$gdb_prompt >>> $" { >>> pass "info float (with FPU)" >>> } >>> -re "No floating.point info available for this >>> processor.*$gdb_prompt $" { >>> pass "info float (without FPU)" >>> } >>> } >>> + send_gdb "set \$frm = 0\n" >>> } else { >>> gdb_test "info float" "No floating.point info available for this >>> processor." "info float (unknown target)" >>> } >>> -- >>> 2.35.1 >>> >>> --00000000000066f62b05e935480d--