From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id C42CD3858D28 for ; Sat, 11 Mar 2023 11:59:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C42CD3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=undo.io Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=undo.io Received: by mail-ed1-x52f.google.com with SMTP id cn21so777897edb.0 for ; Sat, 11 Mar 2023 03:59:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=undo.io; s=google2; t=1678535950; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=57DWmo5o8S97rSRPz+RwsC/H8jKXcHi+1wD/SqBAGn0=; b=DBGXj6gBk1QIBG052qLtfB33T8W/PbExZ3NR3u3aSrn9ToCkyhW0yx6AmfGmkK+Nr7 8VVOCbzD/pKdHQjQme8isy2j5QPDg5wEkkgkAoIX7f2QV6c/ZgpaJ6clyR6EoHvT+Z7Q ALhkF/OwaupghlSvn2jAveUIxMLQydMgfmpvbSlmZ4G5ympz3+XnsZ0KA+R7YmDGKQNr qbESdccR8C8pwu29BOau5U7xE/DDouOeujBHgtSx2oLWIMc2XuIVYMTcAb3zt7AOtS7s 48Sos7qmhT4YXCMJR8HhPngpUx4/tmSEA8h2dEbdLDurFwRDz4K4/VyVYut6sFHOoGVA 0+7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678535950; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=57DWmo5o8S97rSRPz+RwsC/H8jKXcHi+1wD/SqBAGn0=; b=kzXzEGWnxdAjHgarnO8jsKZFc7tNDNsm6VDqOysd9VUWE5J9y+46nYcjmtvC/kh72c vvlcrCYvwPU2AFZGL11BxoBBTjgEWpsAdlUtl7C+f6MkL6YukgYTdJXTZnf2REjqNCuA NCeMhLxfSrezQoUTufXCM+GxnnkA7fBYMseFwpzl6SCdm3WNfkklIYvNx7UwpNxYZ2EY QchsM7auqZ8h1w/JLTxSO2g1IQ+mC3IUkorqf3UGX+lqEJLY6eAqfZtwPJpk4OqWpU/o nL5vIOmD2l8Dpd3dWp4RcvosHscFzPlm+HTzBVl3RnZybCuZkRab3uZX94y/m8m+f/rT ub2Q== X-Gm-Message-State: AO0yUKWIRl1SowoKYrR2t2N0TJZmuEV/ucQawyHKv8mDbFsuYkzHHQJj KNyZYK5m+tyhvSyagiLv7unObHqNz+kNVQb3IjlO/w== X-Google-Smtp-Source: AK7set860BfIkjf1gWqavmfTG7x7K8Pap9z82txd+aiWnCWXdIhboGXUK0tyS6rDCKB/MJRypQM8z7K3CPBb4X/FlDE= X-Received: by 2002:a17:906:f47:b0:877:747f:f6e5 with SMTP id h7-20020a1709060f4700b00877747ff6e5mr13955387ejj.11.1678535950617; Sat, 11 Mar 2023 03:59:10 -0800 (PST) MIME-Version: 1.0 References: <87fsftateu.fsf@redhat.com> <20221020174702.514681-1-grees@undo.io> <87bkl3h153.fsf@redhat.com> In-Reply-To: From: Gareth Rees Date: Sat, 11 Mar 2023 11:58:59 +0000 Message-ID: Subject: Re: [PATCH v5] [PR mi/29554] New PRINT-VALUES option '--scalar-values'. To: Andrew Burgess Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andrew Burgess wrote: > I'm happy to go with option #2, but I still think option #1 would be a > better choice. It would change IDE behaviour in some cases, but I don't > see why that change would break any IDEs, and I can't imagine how the > current behaviour can be considered the right thing to do. I've posted a patch v6 implementing solution #1 (that is, updating the --simple-values option). I've also taken account of all your review comments, where they applied to solution #1. I rebased the patch so that it now applies cleanly to the GDB master branch. I think it's worth trying to see if we can get agreement on solution #1 as it is the simpler solution. But I'd also be happy to go with solution #2 (that is, adding a new --scalar-values option) if the GDB maintainers agree that is the better solution.