From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <grees@undo.io>
Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com
 [IPv6:2a00:1450:4864:20::42c])
 by sourceware.org (Postfix) with ESMTPS id 157E73858D1E
 for <gdb-patches@sourceware.org>; Thu,  8 Sep 2022 11:09:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 157E73858D1E
Received: by mail-wr1-x42c.google.com with SMTP id b5so25453497wrr.5
 for <gdb-patches@sourceware.org>; Thu, 08 Sep 2022 04:09:13 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date;
 bh=fQgHzYEViKLjTG5rclWpJF9LWHl6fWa5fienl7gHlW4=;
 b=GbYtrSx90SWlbeBTAagXGUlPRFzsGRTy+zqIcmoMrLJdX1Jnq97cYGDJQUm4ACfhO2
 wvu0hT2Sg7Ev1qXs8BjDmBFaRFilPh0/TkZQJgzMZ1Xaf5nhS3ps2mvdkH88tiHeuCoa
 TgNA7ZclP0/UEXEOHV9oI/34UxhHZKuq74PL/7ZF2EEL2EBkEdUfG9juqcmgOy4CT0T2
 DnWPxt15d3KFQMxciD6aL0tmzz/49vMD3CxAPecij6a+85VhMjdDEWonQd88EOiT//MW
 s6nELN3b8IkKDYqibJQA53aaZ3JlDZBdxNKXCD+TZ6HGuchgeZyK0FblsnV1JjSJrmmc
 eEfw==
X-Gm-Message-State: ACgBeo39Zhf8WXboLeS3LEcDbBdf5P2tytNf7IWxVBZYyq3dXZAjHq/x
 iqvhHiqF/T1RoNMB3pzj1f4tMIrhAntqCtAqir3RoA==
X-Google-Smtp-Source: AA6agR6OHDZs6AdpGtfZfEv691bNuvwlpG2vkxvuc63muMM/gNRmfuDFNWdLXc+1Hg37NY9Wpp4FPP50aHSSQ8vOLK8=
X-Received: by 2002:a5d:4745:0:b0:228:d9ec:6b5d with SMTP id
 o5-20020a5d4745000000b00228d9ec6b5dmr4821639wrs.257.1662635351916; Thu, 08
 Sep 2022 04:09:11 -0700 (PDT)
MIME-Version: 1.0
References: <20220908071831.10166-1-grees@undo.io> <877d2ema8q.fsf@redhat.com>
In-Reply-To: <877d2ema8q.fsf@redhat.com>
From: Gareth Rees <grees@undo.io>
Date: Thu, 8 Sep 2022 12:09:00 +0100
Message-ID: <CAA8DSpGW9U4+FOXH7aNe1Z_xu0zk44SkkD+zpAYozZ1C_aNWVA@mail.gmail.com>
Subject: Re: [PATCH] [gdb/mi] Don't treat references to compound values as
 "simple".
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,
 SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Sep 2022 11:09:14 -0000

Andrew Burgess <aburgess@redhat.com> wrote:
> Thanks for this patch.  I have a few notes, in line below.

Thank you for the detailed review. I believe I've addressed all your
comments in version 2 of the patch but let me know if there's anything
else I need to do.