From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id A18033858002 for ; Wed, 18 May 2022 21:14:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A18033858002 Received: by mail-lf1-x12d.google.com with SMTP id bq30so5791420lfb.3 for ; Wed, 18 May 2022 14:14:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zXQLIGj896i/HqMzd5tLi1xBPan8iRZTQSIhoku0d94=; b=n85IWTUjzkhVIWNura4PmiAk6uYs1K1PLmu27RlA1bOkg8LWWWdxvCWWv6mQEoZ5Du Y7iLZRCAbLhgCgMxzALHthgupwA4qWLaujuKwZpNlK4QblVRS4SHQEd052chDOJZWfFn aBvvRlqQ7XCHpBx6RIMqnEFpo6gKOFOunqNjW3NPosZXPXiBjZRAyXfL4utMkfyzGEmT pY2IGngNApVcGtBh5CDixo12HEdwEMb4hi711VCqIcQsq+ch75RLmCcoCJfxfRcfQ3jg GJCWiyi5sGmWxuALp9SrWN7GzLPrKCROWS1s6MbllHH54+cDm+gqMv/X3whguTu5omzN 4nYg== X-Gm-Message-State: AOAM531SkhcKFGmrOG/xirXlsj6EsTIb5+ysyM+zJ3TrzEd10fCFE0Me 26H+SLRrv+t4TSH4DUta48V4DVZKscBwuyPml3k= X-Google-Smtp-Source: ABdhPJyEB1CCnvoDgbByPuUgFLeSMsZO+HYB4Mj7dRHe/QUo6x8lFDgRz2J4Qa3d//Dagh8+gxxzgV1QrbFA0Y4E/hc= X-Received: by 2002:a05:6512:b1e:b0:44a:9b62:3201 with SMTP id w30-20020a0565120b1e00b0044a9b623201mr1004192lfu.42.1652908462972; Wed, 18 May 2022 14:14:22 -0700 (PDT) MIME-Version: 1.0 References: <87y1yyj1sl.fsf@redhat.com> In-Reply-To: <87y1yyj1sl.fsf@redhat.com> From: Nikolaos Chatzikonstantinou Date: Thu, 19 May 2022 06:14:11 +0900 Message-ID: Subject: Re: [PATCH] Fix inconsistent input/output of example To: Andrew Burgess Cc: Nikolaos Chatzikonstantinou via Gdb-patches Content-Type: multipart/mixed; boundary="000000000000c83e5705df4fbdc3" X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2022 21:14:26 -0000 --000000000000c83e5705df4fbdc3 Content-Type: text/plain; charset="UTF-8" On Thu, May 19, 2022 at 12:30 AM Andrew Burgess wrote: > This change looks correct to me, however, the same mistake is repeated a > few lines earlier in the example, it would be good to fix them both at > the same time I think. I'm attaching a patch that fixes both. --000000000000c83e5705df4fbdc3 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-inconsistent-input-output-of-example.patch" Content-Disposition: attachment; filename="0001-Fix-inconsistent-input-output-of-example.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l3c30e9k0 RnJvbSAyNmE5MWI0OTNlMzgzZDdjNjQwNWZlZmU1OGIxNWEzN2M0OTdmMTBiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWtvbGFvcyBDaGF0emlrb25zdGFudGlub3UgPG5jaGF0ejMx NEBnbWFpbC5jb20+CkRhdGU6IFdlZCwgMTggTWF5IDIwMjIgMjI6Mjg6MDIgKzA5MDAKU3ViamVj dDogW1BBVENIXSBGaXggaW5jb25zaXN0ZW50IGlucHV0L291dHB1dCBvZiBleGFtcGxlClRvOiBn ZGItcGF0Y2hlc0Bzb3VyY2V3YXJlLm9yZwoKLS0tCiBnZGIvZG9jL2dkYi50ZXhpbmZvIHwgNCAr LS0tCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDMgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvZ2RiL2RvYy9nZGIudGV4aW5mbyBiL2dkYi9kb2MvZ2RiLnRleGluZm8KaW5kZXgg OWRmMTA5YmEzMzAuLjhiODJhNjViZWViIDEwMDY0NAotLS0gYS9nZGIvZG9jL2dkYi50ZXhpbmZv CisrKyBiL2dkYi9kb2MvZ2RiLnRleGluZm8KQEAgLTEyMTAxLDggKzEyMTAxLDYgQEAgbGlicmFy eTIuc286CiAxIHByaW50ZXIgZGlzYWJsZWQKIDEgb2YgMyBwcmludGVycyBlbmFibGVkCiAoZ2Ri KSBpbmZvIHByZXR0eS1wcmludGVyIGxpYnJhcnkyCi1saWJyYXJ5MS5zbzoKLSAgZm9vIFtkaXNh YmxlZF0KIGxpYnJhcnkyLnNvOgogICBiYXIKICAgICBiYXIxIFtkaXNhYmxlZF0KQEAgLTEyMTEw LDcgKzEyMTA4LDcgQEAgbGlicmFyeTIuc286CiAoZ2RiKSBkaXNhYmxlIHByZXR0eS1wcmludGVy IGxpYnJhcnkyIGJhcgogMSBwcmludGVyIGRpc2FibGVkCiAwIG9mIDMgcHJpbnRlcnMgZW5hYmxl ZAotKGdkYikgaW5mbyBwcmV0dHktcHJpbnRlciBsaWJyYXJ5MgorKGdkYikgaW5mbyBwcmV0dHkt cHJpbnRlcgogbGlicmFyeTEuc286CiAgIGZvbyBbZGlzYWJsZWRdCiBsaWJyYXJ5Mi5zbzoKLS0g CjIuMzUuMQoK --000000000000c83e5705df4fbdc3--