From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by sourceware.org (Postfix) with ESMTPS id C6F43385840F for ; Mon, 18 Jul 2022 15:32:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C6F43385840F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=mail.api.win Authentication-Results: sourceware.org; spf=none smtp.mailfrom=api.win Received: by mail-pg1-f175.google.com with SMTP id 23so10905627pgc.8 for ; Mon, 18 Jul 2022 08:32:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NWmx7dBVktYnIKxsDPMMLOIWJae7QMmH/5xtXGjIXFs=; b=gxZEDBanDXPQJmGU2RF55IUtryje6DfyfYLhFRgR+ZxLMdnF5z4uR8j4yFqfK3CKMf d+uaWZJFwfkWDqC0aW+CHoD+BuSmnNyt1K56pyjTssQmR88e0fkjiY6wA/vu4YUmKomm eMTDkLQO0KCiaU6ZGydKj9Xfur6iAG+mkUVvJDWjypiaiqCoJL7mk+hxZy4ovk/9DQih xGDeeZLU8gjbOl0XSNmgduNq5RC8PHvqCkLWT/zCV2X6vw8YSF1k77PG9t8T/m6pZ/dk MxWfUX637uxHHzu+k8pYnLER0/yFkxU60EzMTIshghCBj7xdsZ2RwR1mVcKEXE8+wu7M 99Iw== X-Gm-Message-State: AJIora+KH/54N4LQNzzdUnkhAANsv0XeIrxiidZ1UTqyZYf85r/QlRfz 8UALJSXEcdTQY9T8Hrw6ZvXQkUqc1ksKC68UegAtPg== X-Google-Smtp-Source: AGRyM1vkb8P4Ki5WYK/VQQ7UsKFX+PfNkfWnvNrnhwZ2Zw5nHpTX9paUEcmtKLO49y10b1IM4geDkYITHDOawequc/o= X-Received: by 2002:a05:6a00:450d:b0:52b:84ca:9509 with SMTP id cw13-20020a056a00450d00b0052b84ca9509mr959733pfb.74.1658158369711; Mon, 18 Jul 2022 08:32:49 -0700 (PDT) MIME-Version: 1.0 References: <83sfn91rvt.fsf@gnu.org> <20220710101003.4245-1-gdb@mail.api.win> <87tu7imafv.fsf@tromey.com> <87tu7eqzfa.fsf@redhat.com> In-Reply-To: <87tu7eqzfa.fsf@redhat.com> From: Andrei Pikas Date: Mon, 18 Jul 2022 18:32:39 +0300 Message-ID: Subject: Re: [PATCH v2 (mentions of reverse mode eliminated)] Add style tui-cursorline command to colorize TUI current line. To: Andrew Burgess Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2022 15:32:52 -0000 > > This is to support all 256 colors > > https://www.ditig.com/256-colors-cheat-sheet . I want to use the > > lightest shade of gray #255 for the background. > > Thanks. I've been playing with adding 256 colour support to GDB. > > I think this change is big enough that it should be split into a > separate patch. Do you think it's OK to set colors as enum without corresponding numbers for colors 0-7? Or maybe it would be better to add something like case var_color: into do_set_command to support all possible colors which ui_file_style::color supports? Or maybe just to store value as simple var_string, but to extend struct cmd_list_element with custom validation function, to validate color string at the time of setting, rather then on first use?