From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 88E0B3858D37 for ; Sat, 29 Apr 2023 07:37:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 88E0B3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-32ec968434eso718155ab.0 for ; Sat, 29 Apr 2023 00:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682753825; x=1685345825; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SdmcILyxZ2SYku4tngciahLxK33doPp6E7nEXyVc0TU=; b=l8UznH78PQTfFuw34qOyVG+iMERbFZDibqMmOjYREsGKSydpoEFqMJfzHDRcxrfQcC KP+vJAv3xnNOZzKzLKr0YsE4q88czPe6mTCmurH6VL67K3d4sKohuu8O0ydI7hVK3GW6 ng7nKgcICYRazipJFKZ1oztfN7ttEuACoD9eVD+idpguKe4sdvyVS6JR3Yv6XPIRUfQ5 GXkkhLKcDdIMxJxW5aDNTSdRfbEWnqWeMS6IU0SwSZetIgd3VNff4EAppwKW6KDtpkTy 4Qs1Eeqmw1A6vdC7X91hKo63wmoXPT7BJAkol+7oFkRJHe9AD8i0Zd1bQHU5TTerkkgL a/WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682753825; x=1685345825; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SdmcILyxZ2SYku4tngciahLxK33doPp6E7nEXyVc0TU=; b=OqQoqnxVCoj2QQ6cJdlR1/vGa7cQtkacojCiv3ZszNY1v6PqgIBhVFHB/y+RLT+RwN vQnHkonwpuA3eBGMBdzaMleF6Ia/B46cDyuloARHM+ZXhWR996C7SDvReLwm4NcmnTJ/ foizajkgxTT2eXkb9ZYRDC4TWMSqOMM6rXN4dTpqvGIJHB3Su170wGH+Tqw5/NFNO18b egLGXCoZOgZC9FQQIOLM//gXmRj3Ug6YpX5CLc36IUMN7J3QsqYxnN5cT7Eid2RkmTDu ezuLa7YvnCm5F8NjBOxmvfGiTffUo9BL6Olce97QZ79km8jTHoAqyGYrhBG2k2LL4Ki6 k/yA== X-Gm-Message-State: AC+VfDzpHResvtRKA1u1s+JseoMHdYX1vAAZ79qZktZdpmTDtQ3dXST0 3x+VQtkGV4L4azBfQtsDEFX//dqK+eLYacKlHNu8uQ== X-Google-Smtp-Source: ACHHUZ5TrF8w46La4JQQ1dv3Qm9/j3gnzHbhY8kfIKyckAyY6Iw2wOdmXVNAnM2DBZBwGsYEGJ4BU/EtiRA0rXSOLFY= X-Received: by 2002:a05:6e02:12cf:b0:32a:dc6a:3b97 with SMTP id i15-20020a056e0212cf00b0032adc6a3b97mr171665ilm.0.1682753825477; Sat, 29 Apr 2023 00:37:05 -0700 (PDT) MIME-Version: 1.0 References: <87ildlxkkx.fsf@tromey.com> In-Reply-To: From: Roland McGrath Date: Sat, 29 Apr 2023 00:36:54 -0700 Message-ID: Subject: Re: [PATCH users/roland/safe-ctype] Uniformly put `#include "safe-ctype.h"` last among #include directives To: Tom Tromey Cc: Roland McGrath via Gdb-patches , Binutils , Manoj Gupta Content-Type: multipart/alternative; boundary="000000000000037cce05fa74a842" X-Spam-Status: No, score=-19.5 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000037cce05fa74a842 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Since his v3 seems to address all your feedback and seems like a clear fix (WFM), I've committed to trunk on Manoj's behalf. Thanks, Roland On Mon, Apr 24, 2023 at 10:40=E2=80=AFAM Roland McGrath wrote: > That seems easier to maintain without breakage over the long term than my > version. Can we get that landed forthwith? > > Thanks, > Roland > > > On Mon, Apr 24, 2023 at 10:21=E2=80=AFAM Tom Tromey wrot= e: > >> >>>>> "Roland" =3D=3D Roland McGrath via Gdb-patches < >> gdb-patches@sourceware.org> writes: >> >> Roland> I didn't touch anything in the libiberty subdirectory since AIUI >> Roland> that's still copied from the gcc repository. >> >> There's also this patch to fix it differently: >> >> https://sourceware.org/pipermail/gdb-patches/2023-April/198954.html >> >> which isolates the damage to gdb. >> >> Tom >> > --000000000000037cce05fa74a842--