From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by sourceware.org (Postfix) with ESMTPS id 9FA833858D1E for ; Mon, 24 Apr 2023 17:40:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FA833858D1E Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-qt1-x835.google.com with SMTP id d75a77b69052e-3ef36d814a5so1609851cf.0 for ; Mon, 24 Apr 2023 10:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682358053; x=1684950053; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UjrdFJtzPLn8+gFOfwekp2Kpbx/0QGQRh53rxeJdXbU=; b=j6DTTxarCidgzhi5q3bDpYw982burDBeSY5M1uIxevTBL6MyvWsKgKVj7qBrv+ZlXa 2lWQ1RaRYc4tHdDLJNV5yv50O8amHofHviKJhJxi3NHfz5WgC2uZewQ/uHzwvFtC3gWK ZnJb+HW7ATWgb8LveIxS+MCsLMqIH/qPxVM52nnu3WrtgrLVw+AIgE0Rs+gMhqkD4oT+ DU/aVrII+oAEdflpzT3zyo7TxGDB5ZZflQexvgh21YT/Z6Jg9eMBqCJ7j6JB61uBfJjr 2mahkKZ0CO4gLa6tB8acKOwA1XWRa9pZ37sgTliMnx6ZXdZEJlM62/uLkOCmnRSvECml 0VNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682358053; x=1684950053; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UjrdFJtzPLn8+gFOfwekp2Kpbx/0QGQRh53rxeJdXbU=; b=Fhst0Oqh0K55hYPbJXY70Ny+lkWc8YSIIe9rqsnmqD9xq5azF0iQzffOsOvLb7FaQx DTwZ1S6vAvVaT0DdiyCbr+XQ9RDNLmd0TrVF8QLj6E5wUoCD3An1WjEDYQix2BZNY39y friA0f4JKPLUemaQ27/oJPl7q9cSGYwOIlayhy6O52n2jvaNEftuX5Mj/fZKjRX+Rmno 9DrVcpHrt7z6RdMZmUJ9LNkoGaGJjHVeT3D1D9hDenmjRiTeVvfAAtdsCpwziBIeVh0/ KQfLwi6DnkyU/JuEHKbMBj7nkp3lKYGpJuthlmw9T1iCTuhnO07JidNxBcC8OlZ/yUkv 1v2Q== X-Gm-Message-State: AAQBX9dcoAuOHletvJH8c2MAj0o9PGdCinRFAiRGHfmVpZM6ZeAhf4eU YbFIJ8use9E6m80oehyqGrsJ1NweBiHNCBpVLa7lcQ== X-Google-Smtp-Source: AKy350YUr1/O9dgdXt3+5kIvyNQwKHFA36/mmMeNyQaVyeerJ1wEAsvunD/jR2BJkT2K31iGhQMBYVDj+1BElYt8bJU= X-Received: by 2002:a05:622a:86:b0:3ef:2ffe:a961 with SMTP id o6-20020a05622a008600b003ef2ffea961mr20165qtw.2.1682358052706; Mon, 24 Apr 2023 10:40:52 -0700 (PDT) MIME-Version: 1.0 References: <87ildlxkkx.fsf@tromey.com> In-Reply-To: <87ildlxkkx.fsf@tromey.com> From: Roland McGrath Date: Mon, 24 Apr 2023 10:40:41 -0700 Message-ID: Subject: Re: [PATCH users/roland/safe-ctype] Uniformly put `#include "safe-ctype.h"` last among #include directives To: Tom Tromey Cc: Roland McGrath via Gdb-patches , Binutils Content-Type: multipart/alternative; boundary="0000000000001e7ce805fa18828d" X-Spam-Status: No, score=-19.4 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000001e7ce805fa18828d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable That seems easier to maintain without breakage over the long term than my version. Can we get that landed forthwith? Thanks, Roland On Mon, Apr 24, 2023 at 10:21=E2=80=AFAM Tom Tromey wrote: > >>>>> "Roland" =3D=3D Roland McGrath via Gdb-patches < > gdb-patches@sourceware.org> writes: > > Roland> I didn't touch anything in the libiberty subdirectory since AIUI > Roland> that's still copied from the gcc repository. > > There's also this patch to fix it differently: > > https://sourceware.org/pipermail/gdb-patches/2023-April/198954.html > > which isolates the damage to gdb. > > Tom > --0000000000001e7ce805fa18828d--