Re: [PATCH 4/5] Implement D primitive types in GDB

[Iain Buclaw <ibuclaw@gdcproject.org>]

On 9 January 2014 18:33, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
>
> Iain> D has it's own type system separate from C.  This defines all
> Iain> primitive types all found in D.
>
> Thanks.  I think the guts of this patch are fine, just some nits around
> the edges.
>
>
> Iain> +enum d_primitive_types {
>
> Comment before the new type.
>
> Iain> +  d_primitive_type_cent,
> Iain> +  d_primitive_type_ucent,
>
> I don't think we need a comment for each enum constant, but it would be
> nice for the ones that are "not obvious to C developers".  Subjective I
> realize; but at least here I have no idea what "cent" means.
>
> Iain> +  d_primitive_type_ifloat,
> Iain> +  d_primitive_type_idouble,
> Iain> +  d_primitive_type_ireal,
>
> Or what the "i" prefix means.
>
> Iain> +  d_primitive_type_cfloat,
> Iain> +  d_primitive_type_cdouble,
> Iain> +  d_primitive_type_creal,
>
> "c" means complex maybe?
>

Sure, not a problem.  For reference, cent/ucent are 128bit types - not
actually implemented at all, but they have been kept around as
keywords for possible future use.  The "i" prefix is for Imaginary
numbers, and the "c" prefix is for Complex numbers.


>
> Iain> +# NOTE: The tests here intentionally do not require a go compiler.
>
> Cut-and-pasto :)
>

Aww..... :-)