From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29451 invoked by alias); 9 Jan 2014 18:41:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29433 invoked by uid 89); 9 Jan 2014 18:41:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qa0-f43.google.com Received: from mail-qa0-f43.google.com (HELO mail-qa0-f43.google.com) (209.85.216.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 09 Jan 2014 18:41:06 +0000 Received: by mail-qa0-f43.google.com with SMTP id k15so3295560qaq.30 for ; Thu, 09 Jan 2014 10:41:04 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.49.12.43 with SMTP id v11mr10478511qeb.50.1389292864689; Thu, 09 Jan 2014 10:41:04 -0800 (PST) Received: by 10.229.195.196 with HTTP; Thu, 9 Jan 2014 10:41:04 -0800 (PST) In-Reply-To: <87sisx80oo.fsf@fleche.redhat.com> References: <87sisx80oo.fsf@fleche.redhat.com> Date: Thu, 09 Jan 2014 18:41:00 -0000 Message-ID: Subject: Re: [PATCH 4/5] Implement D primitive types in GDB From: Iain Buclaw To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00253.txt.bz2 On 9 January 2014 18:33, Tom Tromey wrote: >>>>>> "Iain" == Iain Buclaw writes: > > Iain> D has it's own type system separate from C. This defines all > Iain> primitive types all found in D. > > Thanks. I think the guts of this patch are fine, just some nits around > the edges. > > > Iain> +enum d_primitive_types { > > Comment before the new type. > > Iain> + d_primitive_type_cent, > Iain> + d_primitive_type_ucent, > > I don't think we need a comment for each enum constant, but it would be > nice for the ones that are "not obvious to C developers". Subjective I > realize; but at least here I have no idea what "cent" means. > > Iain> + d_primitive_type_ifloat, > Iain> + d_primitive_type_idouble, > Iain> + d_primitive_type_ireal, > > Or what the "i" prefix means. > > Iain> + d_primitive_type_cfloat, > Iain> + d_primitive_type_cdouble, > Iain> + d_primitive_type_creal, > > "c" means complex maybe? > Sure, not a problem. For reference, cent/ucent are 128bit types - not actually implemented at all, but they have been kept around as keywords for possible future use. The "i" prefix is for Imaginary numbers, and the "c" prefix is for Complex numbers. > > Iain> +# NOTE: The tests here intentionally do not require a go compiler. > > Cut-and-pasto :) > Aww..... :-)